Skip to contentSkip to conversation

FAILED: patch "[PATCH] ice: initialize local variable 'tlv'" failed to apply to 5.10-stable tree

PATCH [email protected] 1 participant 1 message Feb 25, 2022

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 5950bdc88dd1d158f2845fdff8fb1de86476806c Mon Sep 17 00:00:00 2001
From: Tom Rix <[email protected]>
Date: Mon, 14 Feb 2022 07:40:43 -0800
Subject: [PATCH] ice: initialize local variable 'tlv'

Clang static analysis reports this issues ice_common.c:5008:21: warning: The left expression of the compound
assignment is an uninitialized value. The computed value will also be garbage
ldo->phy_type_low |= ((u64)buf << (i * 16)); ~~~~~~~~~~~~~~~~~ ^

When called from ice_cfg_phy_fec() ldo is the uninitialized local variable tlv. So initialize.

Fixes ea78ce4dab05 ("ice: add link lenient and default override support")
drivers/net/ethernet/intel/ice/ice_common.c +1 -1
index a6d7d3eff186..e2af99a763ed 100644
@@ -3340,7 +3340,7 @@ ice_cfg_phy_fec(struct ice_port_info *pi, struct ice_aqc_set_phy_cfg_data *cfg,
 
 	if (fec == ICE_FEC_AUTO && ice_fw_supports_link_override(hw) &&
 	    !ice_fw_supports_report_dflt_cfg(hw)) {
-		struct ice_link_default_override_tlv tlv;
+		struct ice_link_default_override_tlv tlv = { 0 };
 
 		status = ice_get_link_default_override(&tlv, pi);
 		if (status)