Skip to contentSkip to conversation

extcon: usb-gpio: Remove disable irq operation in system sleep.

PATCH RESEND Superseded Bruce Chen 1 participant 1 message Mar 11, 2022 External connector subsystem (extcon)

lore
Share & tools
lore

Bruce Chen

author
#0 lore raw

PATCH RESEND v2 1/1 extcon: usb-gpio: Remove disable irq operation in system sleep.

From: Bruce Chen <[email protected]>

If disable vbus/id irq, it will lead to wakeup system fail in unisoc platform. In unisoc platform, Irq enable and irq wakeup are the same interrupt line. So remove disable vbus/id irq operation is a way to solve the issue.

---
 drivers/extcon/extcon-usb-gpio.c | 15 ---------------
 1 file changed, 15 deletions(-)
drivers/extcon/extcon-usb-gpio.c +0 -15
index f2b65d9..40d967a 100644
@@ -226,16 +226,6 @@ static int usb_extcon_suspend(struct device *dev)
 		}
 	}
 
-	/*
-	 * We don't want to process any IRQs after this point
-	 * as GPIOs used behind I2C subsystem might not be
-	 * accessible until resume completes. So disable IRQ.
-	 */
-	if (info->id_gpiod)
-		disable_irq(info->id_irq);
-	if (info->vbus_gpiod)
-		disable_irq(info->vbus_irq);
-
 	if (!device_may_wakeup(dev))
 		pinctrl_pm_select_sleep_state(dev);
 
@@ -267,11 +257,6 @@ static int usb_extcon_resume(struct device *dev)
 		}
 	}
 
-	if (info->id_gpiod)
-		enable_irq(info->id_irq);
-	if (info->vbus_gpiod)
-		enable_irq(info->vbus_irq);
-
 	queue_delayed_work(system_power_efficient_wq,
 			   &info->wq_detcable, 0);
 
Signature · 1 line
1.9.1