scsi: libsas and users: Factor out internal abort code
Subsystems (4)
v2 cover scsi: libsas and users: Factor out internal abort code
This is a follow-on from the series to factor out the TMF code shared between libsas LLDDs.
The hisi_sas and pm8001 have an internal abort feature to abort pending commands in the host controller, prior to being sent to the target. The driver support implementation is naturally quite similar, so factor it out.
Again, testing and review would be appreciated.
This is based on mkp-scsi 5.18 staging queue @ commit 2bd3b6b75946
Changes since v1:
- fixup small coding issues (Damien)
- Add Tested-by tags (thanks!)
John Garry (4):
scsi: libsas: Add sas_execute_internal_abort_single()
scsi: libsas: Add sas_execute_internal_abort_dev()
scsi: pm8001: Use libsas internal abort support
scsi: hisi_sas: Use libsas internal abort support
drivers/scsi/hisi_sas/hisi_sas.h | 8 +- drivers/scsi/hisi_sas/hisi_sas_main.c | 453 +++++++++---------------- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 11 +- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 18 +- drivers/scsi/libsas/sas_scsi_host.c | 89 +++++ drivers/scsi/pm8001/pm8001_hwi.c | 27 +- drivers/scsi/pm8001/pm8001_hwi.h | 5 - drivers/scsi/pm8001/pm8001_sas.c | 178 +++------- drivers/scsi/pm8001/pm8001_sas.h | 6 +- drivers/scsi/pm8001/pm80xx_hwi.h | 5 - include/scsi/libsas.h | 24 ++ include/scsi/sas.h | 2 + 12 files changed, 360 insertions(+), 466 deletions(-)
Signature · 1 line
2.26.2
PATCH v2 1/4 scsi: libsas: Add sas_execute_internal_abort_single()
The internal abort feature is common to hisi_sas and pm8001 HBAs, and the driver support is similar also, so add a common handler.
Two modes of operation will be supported:
- single: Abort a single tagged command
- device: Abort all commands associated with a specific domain device
A new protocol is added, SAS_PROTOCOL_INTERNAL_ABORT, so the common queue command API may be re-used.
Only add "single" support as a first step.
--- drivers/scsi/libsas/sas_scsi_host.c | 74 +++++++++++++++++++++++++++++ include/scsi/libsas.h | 14 ++++++ include/scsi/sas.h | 2 + 3 files changed, 90 insertions(+)
drivers/scsi/libsas/sas_scsi_host.c +74 -0
@@ -920,6 +920,80 @@ void sas_task_internal_timedout(struct timer_list *t)#define TASK_TIMEOUT (20 * HZ)#define TASK_RETRY 3 +static int sas_execute_internal_abort (struct domain_device *device, +enum sas_internal_abort type,u16 tag, +unsigned int qid,void *data) +{ +struct sas_ha_struct *ha = device->port->ha; +struct sas_internal *i =to_sas_internal (ha->core.shost->transportt); +struct sas_task *task =NULL ; +int res, retry; + +for (retry =0 ; retry <TASK_RETRY ; retry++) { + task =sas_alloc_slow_task (GFP_KERNEL ); +if (!task) +return -ENOMEM ; + + task->dev = device; + task->task_proto =SAS_PROTOCOL_INTERNAL_ABORT ; + task->task_done = sas_task_internal_done; + task->slow_task->timer.function = sas_task_internal_timedout; + task->slow_task->timer.expires = jiffies +TASK_TIMEOUT ; +add_timer (&task->slow_task->timer); + + task->abort_task.tag = tag; + task->abort_task.type = type; + + res = i->dft->lldd_execute_task (task,GFP_KERNEL ); +if (res) { +del_timer_sync (&task->slow_task->timer); +pr_err ("Executing internal abort failed %016llx (%d)\n" , +SAS_ADDR (device->sas_addr), res); +break ; + } + +wait_for_completion (&task->slow_task->completion); + res =TMF_RESP_FUNC_FAILED ; + +/* Even if the internal abort timed out, return direct. */ +if (task->task_state_flags &SAS_TASK_STATE_ABORTED ) { +pr_err ("Internal abort: timeout %016llx\n" , +SAS_ADDR (device->sas_addr)); + res = -EIO ; +break ; + } + +if (task->task_status.resp ==SAS_TASK_COMPLETE && + task->task_status.stat ==SAS_SAM_STAT_GOOD ) { + res =TMF_RESP_FUNC_COMPLETE ; +break ; + } + +if (task->task_status.resp ==SAS_TASK_COMPLETE && + task->task_status.stat ==TMF_RESP_FUNC_SUCC ) { + res =TMF_RESP_FUNC_SUCC ; +break ; + } + +pr_err ("Internal abort: task to dev %016llx response: 0x%x status 0x%x\n" , +SAS_ADDR (device->sas_addr), task->task_status.resp, + task->task_status.stat); +sas_free_task (task); + task =NULL ; + } +BUG_ON (retry ==TASK_RETRY && task !=NULL ); +sas_free_task (task); +return res; +} + +int sas_execute_internal_abort_single (struct domain_device *device,u16 tag, +unsigned int qid,void *data) +{ +return sas_execute_internal_abort (device,SAS_INTERNAL_ABORT_SINGLE , + tag, qid, data); +} +EXPORT_SYMBOL_GPL (sas_execute_internal_abort_single); +int sas_execute_tmf (struct domain_device *device,void *parameter,int para_len,int force_phy_id,struct sas_tmf_task *tmf)
include/scsi/libsas.h +14 -0
@@ -557,6 +557,16 @@ struct sas_ata_task {int force_phy_id; }; +/* LLDDs rely on these values */ +enum sas_internal_abort { +SAS_INTERNAL_ABORT_SINGLE =0 , +}; + +struct sas_internal_abort_task { +enum sas_internal_abort type; +u16 tag; +}; +struct sas_smp_task {struct scatterlist smp_req;struct scatterlist smp_resp;
@@ -596,6 +606,7 @@ struct sas_task {struct sas_ata_task ata_task;struct sas_smp_task smp_task;struct sas_ssp_task ssp_task; +struct sas_internal_abort_task abort_task; };struct scatterlist *scatter;
@@ -683,6 +694,9 @@ extern int sas_slave_configure(struct scsi_device *);extern int sas_change_queue_depth (struct scsi_device *,int new_depth);extern int sas_bios_param (struct scsi_device *,struct block_device *,sector_t capacity,int *hsc); +int sas_execute_internal_abort_single (struct domain_device *device, +u16 tag,unsigned int qid, +void *data);extern struct scsi_transport_template *sas_domain_attach_transport (struct sas_domain_function_template *);extern struct device_attribute dev_attr_phy_event_threshold;
include/scsi/sas.h +2 -0
@@ -95,6 +95,8 @@ enum sas_protocol {SAS_PROTOCOL_SSP =0x08 ,SAS_PROTOCOL_ALL =0x0E ,SAS_PROTOCOL_STP_ALL =SAS_PROTOCOL_STP |SAS_PROTOCOL_SATA , +/* these are internal to libsas */ + SAS_PROTOCOL_INTERNAL_ABORT = 0x10, };/* From the spec; local phys only */
Signature · 1 line
2.26.2
PATCH v2 2/4 scsi: libsas: Add sas_execute_internal_abort_dev()
In reply to John GarryAdd support for a "device" variant of internal abort, which will abort all pending IOs for a specific device.
--- drivers/scsi/libsas/sas_scsi_host.c | 8 ++++++++ include/scsi/libsas.h | 8 ++++++++ 2 files changed, 16 insertions(+)
drivers/scsi/libsas/sas_scsi_host.c +8 -0
@@ -994,6 +994,14 @@ int sas_execute_internal_abort_single(struct domain_device *device, u16 tag, }EXPORT_SYMBOL_GPL (sas_execute_internal_abort_single); +int sas_execute_internal_abort_dev (struct domain_device *device, +unsigned int qid,void *data) +{ +return sas_execute_internal_abort (device,SAS_INTERNAL_ABORT_DEV , +SCSI_NO_TAG , qid, data); +} +EXPORT_SYMBOL_GPL (sas_execute_internal_abort_dev); +int sas_execute_tmf (struct domain_device *device,void *parameter,int para_len,int force_phy_id,struct sas_tmf_task *tmf)
include/scsi/libsas.h +8 -0
@@ -560,6 +560,7 @@ struct sas_ata_task {/* LLDDs rely on these values */ enum sas_internal_abort {SAS_INTERNAL_ABORT_SINGLE =0 , +SAS_INTERNAL_ABORT_DEV =1 , };struct sas_internal_abort_task {
@@ -641,6 +642,11 @@ extern struct sas_task *sas_alloc_task(gfp_t flags);extern struct sas_task *sas_alloc_slow_task (gfp_t flags);extern void sas_free_task (struct sas_task *task); +static inline bool sas_is_internal_abort (struct sas_task *task) +{ +return task->task_proto ==SAS_PROTOCOL_INTERNAL_ABORT ; +} +struct sas_domain_function_template {/* The class calls these to notify the LLDD of an event. */ void (*lldd_port_formed)(struct asd_sas_phy *);
@@ -697,6 +703,8 @@ extern int sas_bios_param(struct scsi_device *, struct block_device *,int sas_execute_internal_abort_single (struct domain_device *device,u16 tag,unsigned int qid,void *data); +int sas_execute_internal_abort_dev (struct domain_device *device, +unsigned int qid,void *data);extern struct scsi_transport_template *sas_domain_attach_transport (struct sas_domain_function_template *);extern struct device_attribute dev_attr_phy_event_threshold;
Signature · 1 line
2.26.2
PATCH v2 3/4 scsi: pm8001: Use libsas internal abort support
In reply to John GarryNew special handling is added for SAS_PROTOCOL_INTERNAL_ABORT proto so that we may use the common queue command API.
--- drivers/scsi/pm8001/pm8001_hwi.c | 27 +++-- drivers/scsi/pm8001/pm8001_hwi.h | 5 - drivers/scsi/pm8001/pm8001_sas.c | 178 ++++++++++--------------------- drivers/scsi/pm8001/pm8001_sas.h | 6 +- drivers/scsi/pm8001/pm80xx_hwi.h | 5 - 5 files changed, 74 insertions(+), 147 deletions(-)
drivers/scsi/pm8001/pm8001_hwi.c +17 -10
@@ -4477,22 +4477,25 @@ pm8001_chip_isr(struct pm8001_hba_info *pm8001_ha, u8 vec) }static int send_task_abort (struct pm8001_hba_info *pm8001_ha,u32 opc, -u32 dev_id,u8 flag,u32 task_tag,u32 cmd_tag) +u32 dev_id,enum sas_internal_abort type,u32 task_tag,u32 cmd_tag) {struct task_abort_req task_abort;memset (&task_abort,0 ,sizeof (task_abort)); -if (ABORT_SINGLE == (flag &ABORT_MASK )) { +if (type ==SAS_INTERNAL_ABORT_SINGLE ) { task_abort.abort_all =0 ; task_abort.device_id =cpu_to_le32 (dev_id); task_abort.tag_to_abort =cpu_to_le32 (task_tag); - task_abort.tag =cpu_to_le32 (cmd_tag); - }else if (ABORT_ALL == (flag &ABORT_MASK )) { + }else if (type ==SAS_INTERNAL_ABORT_DEV ) { task_abort.abort_all =cpu_to_le32 (1 ); task_abort.device_id =cpu_to_le32 (dev_id); - task_abort.tag =cpu_to_le32 (cmd_tag); + }else { +pm8001_dbg (pm8001_ha,EH ,"unknown type (%d)\n" , type); +return -EIO ; } + task_abort.tag =cpu_to_le32 (cmd_tag); +return pm8001_mpi_build_cmd (pm8001_ha,0 , opc, &task_abort,sizeof (task_abort),0 ); }
@@ -4501,12 +4504,16 @@ static int send_task_abort(struct pm8001_hba_info *pm8001_ha, u32 opc,* pm8001_chip_abort_task - SAS abort task when error or exception happened. */ int pm8001_chip_abort_task (struct pm8001_hba_info *pm8001_ha, -struct pm8001_device *pm8001_dev,u8 flag,u32 task_tag,u32 cmd_tag) +struct pm8001_ccb_info *ccb) { -u32 opc, device_id; +struct sas_task *task = ccb->task; +struct sas_internal_abort_task *abort = &task->abort_task; +struct pm8001_device *pm8001_dev = ccb->device;int rc =TMF_RESP_FUNC_FAILED ; +u32 opc, device_id; +pm8001_dbg (pm8001_ha,EH ,"cmd_tag = %x, abort task tag = 0x%x\n" , - cmd_tag, task_tag); + ccb->ccb_tag, abort->tag);if (pm8001_dev->dev_type ==SAS_END_DEVICE ) opc =OPC_INB_SSP_ABORT ;else if (pm8001_dev->dev_type ==SAS_SATA_DEV )
@@ -4514,8 +4521,8 @@ int pm8001_chip_abort_task(struct pm8001_hba_info *pm8001_ha,else opc =OPC_INB_SMP_ABORT ;/* SMP */ device_id = pm8001_dev->device_id; - rc =send_task_abort (pm8001_ha, opc, device_id, flag, - task_tag, cmd_tag); + rc =send_task_abort (pm8001_ha, opc, device_id, abort->type, + abort->tag, ccb->ccb_tag);if (rc !=TMF_RESP_FUNC_COMPLETE )pm8001_dbg (pm8001_ha,EH ,"rc= %d\n" , rc);return rc;
drivers/scsi/pm8001/pm8001_hwi.h +0 -5
@@ -434,11 +434,6 @@ struct task_abort_req {u32 reserved[11 ]; } __attribute__((packed, aligned(4))); -/* These flags used for SSP SMP & SATA Abort */ -#define ABORT_MASK 0x3 -#define ABORT_SINGLE 0x0 -#define ABORT_ALL 0x1 -/** * brief the data structure of SSP SATA SMP Abort Response * use to describe SSP SMP & SATA Abort Response ( 64 bytes)
drivers/scsi/pm8001/pm8001_sas.c +55 -123
274 lines not on this page · raw message
drivers/scsi/pm8001/pm8001_sas.h +2 -4
@@ -196,8 +196,7 @@ struct pm8001_dispatch {int (*phy_ctl_req)(struct pm8001_hba_info *pm8001_ha,u32 phy_id,u32 phy_op);int (*task_abort)(struct pm8001_hba_info *pm8001_ha, -struct pm8001_device *pm8001_dev,u8 flag,u32 task_tag, -u32 cmd_tag); +struct pm8001_ccb_info *ccb);int (*ssp_tm_req)(struct pm8001_hba_info *pm8001_ha,struct pm8001_ccb_info *ccb,struct sas_tmf_task *tmf);int (*get_nvmd_req)(struct pm8001_hba_info *pm8001_ha,void *payload);
@@ -683,8 +682,7 @@ int pm8001_chip_ssp_tm_req(struct pm8001_hba_info *pm8001_ha,struct pm8001_ccb_info *ccb, struct sas_tmf_task *tmf);int pm8001_chip_abort_task (struct pm8001_hba_info *pm8001_ha, -struct pm8001_device *pm8001_dev, -u8 flag,u32 task_tag,u32 cmd_tag); +struct pm8001_ccb_info *ccb);int pm8001_chip_dereg_dev_req (struct pm8001_hba_info *pm8001_ha,u32 device_id);void pm8001_chip_make_sg (struct scatterlist *scatter,int nr,void *prd);void pm8001_work_fn (struct work_struct *work);
drivers/scsi/pm8001/pm80xx_hwi.h +0 -5
@@ -672,11 +672,6 @@ struct task_abort_req {u32 reserved[27 ]; } __attribute__((packed, aligned(4))); -/* These flags used for SSP SMP & SATA Abort */ -#define ABORT_MASK 0x3 -#define ABORT_SINGLE 0x0 -#define ABORT_ALL 0x1 -/** * brief the data structure of SSP SATA SMP Abort Response * use to describe SSP SMP & SATA Abort Response ( 64 bytes)
Signature · 1 line
2.26.2
PATCH v2 4/4 scsi: hisi_sas: Use libsas internal abort support
In reply to John GarryUse the common libsas internal abort functionality.
In addition, this driver has special handling for internal abort timeouts - specifically whether to reset the controller in that instance, so extend the API for that.
Timeout is now increased to 20 * Hz from 6 * Hz.
We also retry for failure now, but this should not make a difference.
--- drivers/scsi/hisi_sas/hisi_sas.h | 8 +- drivers/scsi/hisi_sas/hisi_sas_main.c | 453 +++++++++---------------- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 11 +- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 18 +- drivers/scsi/libsas/sas_scsi_host.c | 13 +- include/scsi/libsas.h | 2 + 6 files changed, 183 insertions(+), 322 deletions(-)
drivers/scsi/hisi_sas/hisi_sas.h +1 -7
@@ -133,11 +133,6 @@ struct hisi_sas_rst {bool done; }; -struct hisi_sas_internal_abort { -unsigned int flag; -unsigned int tag; -}; -#define HISI_SAS_RST_WORK_INIT (r, c) \ { .hisi_hba = hisi_hba, \ .completion = &c, \
@@ -325,8 +320,7 @@ struct hisi_sas_hw {void (*prep_stp)(struct hisi_hba *hisi_hba,struct hisi_sas_slot *slot);void (*prep_abort)(struct hisi_hba *hisi_hba, -struct hisi_sas_slot *slot, -int device_id,int abort_flag,int tag_to_abort); +struct hisi_sas_slot *slot);void (*phys_init)(struct hisi_hba *hisi_hba);void (*phy_start)(struct hisi_hba *hisi_hba,int phy_no);void (*phy_disable)(struct hisi_hba *hisi_hba,int phy_no);
drivers/scsi/hisi_sas/hisi_sas_main.c +155 -298
627 lines not on this page · raw message
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c +6 -5
@@ -2603,14 +2603,15 @@ static void hisi_sas_internal_abort_quirk_timeout(struct timer_list *t) }static void prep_abort_v2_hw (struct hisi_hba *hisi_hba, -struct hisi_sas_slot *slot, -int device_id,int abort_flag,int tag_to_abort) +struct hisi_sas_slot *slot) {struct sas_task *task = slot->task; +struct sas_internal_abort_task *abort = &task->abort_task;struct domain_device *dev = task->dev;struct hisi_sas_cmd_hdr *hdr = slot->cmd_hdr;struct hisi_sas_port *port = slot->port;struct timer_list *timer = &slot->internal_abort_timer; +struct hisi_sas_device *sas_dev = dev->lldd_dev;/* setup the quirk timer */ timer_setup (timer, hisi_sas_internal_abort_quirk_timeout,0 );
@@ -2622,13 +2623,13 @@ static void prep_abort_v2_hw(struct hisi_hba *hisi_hba, (port->id <<CMD_HDR_PORT_OFF ) | (dev_is_sata (dev) <<CMD_HDR_ABORT_DEVICE_TYPE_OFF ) | - (abort_flag << CMD_HDR_ABORT_FLAG_OFF)); + (abort->type << CMD_HDR_ABORT_FLAG_OFF));/* dw1 */ - hdr->dw1 =cpu_to_le32 (device_id <<CMD_HDR_DEV_ID_OFF ); + hdr->dw1 =cpu_to_le32 (sas_dev->device_id <<CMD_HDR_DEV_ID_OFF );/* dw7 */ - hdr->dw7 =cpu_to_le32 (tag_to_abort <<CMD_HDR_ABORT_IPTT_OFF ); + hdr->dw7 =cpu_to_le32 (abort->tag <<CMD_HDR_ABORT_IPTT_OFF ); hdr->transfer_tags =cpu_to_le32 (slot->idx); }
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +9 -9
@@ -1452,28 +1452,28 @@ static void prep_ata_v3_hw(struct hisi_hba *hisi_hba, }static void prep_abort_v3_hw (struct hisi_hba *hisi_hba, -struct hisi_sas_slot *slot, -int device_id,int abort_flag,int tag_to_abort) +struct hisi_sas_slot *slot) {struct sas_task *task = slot->task; +struct sas_internal_abort_task *abort = &task->abort_task;struct domain_device *dev = task->dev;struct hisi_sas_cmd_hdr *hdr = slot->cmd_hdr;struct hisi_sas_port *port = slot->port; +struct hisi_sas_device *sas_dev = dev->lldd_dev; +bool sata =dev_is_sata (dev);/* dw0 */ - hdr->dw0 =cpu_to_le32 ((5U <<CMD_HDR_CMD_OFF ) |/*abort*/ + hdr->dw0 =cpu_to_le32 ((5U <<CMD_HDR_CMD_OFF ) |/* abort */ (port->id <<CMD_HDR_PORT_OFF ) | - (dev_is_sata (dev) - <<CMD_HDR_ABORT_DEVICE_TYPE_OFF ) | - (abort_flag - <<CMD_HDR_ABORT_FLAG_OFF )); + (sata <<CMD_HDR_ABORT_DEVICE_TYPE_OFF ) | + (abort->type <<CMD_HDR_ABORT_FLAG_OFF ));/* dw1 */ - hdr->dw1 =cpu_to_le32 (device_id + hdr->dw1 =cpu_to_le32 (sas_dev->device_id <<CMD_HDR_DEV_ID_OFF );/* dw7 */ - hdr->dw7 =cpu_to_le32 (tag_to_abort <<CMD_HDR_ABORT_IPTT_OFF ); + hdr->dw7 =cpu_to_le32 (abort->tag <<CMD_HDR_ABORT_IPTT_OFF ); hdr->transfer_tags =cpu_to_le32 (slot->idx); }
drivers/scsi/libsas/sas_scsi_host.c +10 -3
@@ -943,6 +943,7 @@ static int sas_execute_internal_abort(struct domain_device *device, task->abort_task.tag = tag; task->abort_task.type = type; + task->abort_task.qid = qid; res = i->dft->lldd_execute_task (task,GFP_KERNEL );if (res) {
@@ -957,10 +958,16 @@ static int sas_execute_internal_abort(struct domain_device *device,/* Even if the internal abort timed out, return direct. */ if (task->task_state_flags &SAS_TASK_STATE_ABORTED ) { -pr_err ("Internal abort: timeout %016llx\n" , -SAS_ADDR (device->sas_addr)); +bool quit = true; + +if (i->dft->lldd_abort_timeout) + quit = i->dft->lldd_abort_timeout (task, data); +else +pr_err ("Internal abort: timeout %016llx\n" , +SAS_ADDR (device->sas_addr)); res = -EIO ; -break ; +if (quit) +break ; } if (task->task_status.resp == SAS_TASK_COMPLETE &&
include/scsi/libsas.h +2 -0
@@ -565,6 +565,7 @@ enum sas_internal_abort {struct sas_internal_abort_task {enum sas_internal_abort type; +unsigned int qid;u16 tag; };
@@ -671,6 +672,7 @@ struct sas_domain_function_template {/* Special TMF callbacks */ void (*lldd_tmf_exec_complete)(struct domain_device *dev);void (*lldd_tmf_aborted)(struct sas_task *task); +bool (*lldd_abort_timeout)(struct sas_task *task,void *data);/* Port and Adapter management */ int (*lldd_clear_nexus_port)(struct asd_sas_port *);
Signature · 1 line
2.26.2
Quoted 17 lines · John Garry
This is a follow-on from the series to factor out the TMF code shared between libsas LLDDs.
The
hisi_sasand pm8001 have an internal abort feature to abort pending commands in the host controller, prior to being sent to the target. The driver support implementation is naturally quite similar, so factor it out.Again, testing and review would be appreciated.
This is based on mkp-scsi 5.18 staging queue @ commit
2bd3b6b75946Changes since v1:
- fixup small coding issues (Damien)
- Add Tested-by tags (thanks!)
Quoted 5 lines
John Garry (4):
scsi: libsas: Addsas_execute_internal_abort_single()
scsi: libsas: Addsas_execute_internal_abort_dev()
scsi: pm8001: Use libsas internal abort support
scsi:hisi_sas: Use libsas internal abort support
Looks good to me!
Thanks John for doing it!
Quoted 18 lines
drivers/scsi/hisi_sas/hisi_sas.h | 8 +- drivers/scsi/hisi_sas/hisi_sas_main.c | 453 +++++++++---------------- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 11 +- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 18 +- drivers/scsi/libsas/sas_scsi_host.c | 89 +++++ drivers/scsi/pm8001/pm8001_hwi.c | 27 +- drivers/scsi/pm8001/pm8001_hwi.h | 5 - drivers/scsi/pm8001/pm8001_sas.c | 178 +++------- drivers/scsi/pm8001/pm8001_sas.h | 6 +- drivers/scsi/pm8001/pm80xx_hwi.h | 5 - include/scsi/libsas.h | 24 ++ include/scsi/sas.h | 2 + 12 files changed, 360 insertions(+), 466 deletions(-)--
2.26.2
Martin K. Petersen
AppliedJohn,
Quoted 7 lines
This is a follow-on from the series to factor out the TMF code shared between libsas LLDDs.
The
hisi_sasand pm8001 have an internal abort feature to abort pending commands in the host controller, prior to being sent to the target. The driver support implementation is naturally quite similar, so factor it out.
Applied to 5.18/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 9 lines · John Garry
This is a follow-on from the series to factor out the TMF code shared between libsas LLDDs.
The
hisi_sasand pm8001 have an internal abort feature to abort pending commands in the host controller, prior to being sent to the target. The driver support implementation is naturally quite similar, so factor it out.[...]
Applied to 5.18/scsi-queue, thanks!
[1/4] scsi: libsas: Add sas_execute_internal_abort_single()
https://git.kernel.org/mkp/scsi/c/5c9bf3635b66 [2/4] scsi: libsas: Add sas_execute_internal_abort_dev() https://git.kernel.org/mkp/scsi/c/6a91c3e31578 [3/4] scsi: pm8001: Use libsas internal abort support https://git.kernel.org/mkp/scsi/c/2cbbf489778e [4/4] scsi: hisi_sas: Use libsas internal abort support https://git.kernel.org/mkp/scsi/c/095478a6e5bf
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering