Skip to contentSkip to conversation

rng-tools: enable macro JENT_CONF_ENABLE_INTERNAL_TIMER

PATCH In review Wang Mingyu 2 participants 4 messages Mar 23, 2022 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rng-tools: enable macro JENT_CONF_ENABLE_INTERNAL_TIMER

do_compile error :

| ../git/rngd_jitter.c: In function 'rngd_notime_start':
| ../git/rngd_jitter.c:56:45: error: invalid use of undefined type 'struct jent_notime_ctx'
|    56 |         ret = -pthread_attr_init(&thread_ctx->notime_pthread_attr);

enable macro JENT_CONF_ENABLE_INTERNAL_TIMER to use struct jent_notime_ctx

---
 meta/recipes-support/rng-tools/rng-tools_6.15.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/rng-tools/rng-tools_6.15.bb +2 -0
index ae974f9f6f..0696351903 100644
@@ -34,6 +34,8 @@ INITSCRIPT_PARAMS = "start 03 2 3 4 5 . stop 30 0 6 1 ."
 
 SYSTEMD_SERVICE:${PN} = "rngd.service"
 
+CFLAGS += " -DJENT_CONF_ENABLE_INTERNAL_TIMER "
+
 # Refer autogen.sh in rng-tools
 do_configure:prepend() {
     cp ${S}/README.md ${S}/README
Signature · 1 line
2.25.1
#1 lore raw

This error is not seen on the autobuilder, can you please check why it occurs only in your local setup? The macro probably needs to be enabled in a more targeted way.

Alex

Quoted 38 lines · wangmy

do_compile error :

| ../git/rngd_jitter.c: In function 'rngd_notime_start':
| ../git/rngd_jitter.c:56:45: error: invalid use of undefined type 'struct jent_notime_ctx'
|    56 |         ret = -pthread_attr_init(&thread_ctx->notime_pthread_attr);

enable macro JENT_CONF_ENABLE_INTERNAL_TIMER to use struct jent_notime_ctx

---
 meta/recipes-support/rng-tools/rng-tools_6.15.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/rng-tools/rng-tools_6.15.bb +2 -1
index ae974f9f6f..0696351903 100644
@@ -34,6 +34,8 @@ INITSCRIPT_PARAMS = "start 03 2 3 4 5 . stop 30 0 6 1 ."
 
 SYSTEMD_SERVICE:${PN} = "rngd.service"
 
+CFLAGS += " -DJENT_CONF_ENABLE_INTERNAL_TIMER "
+
 # Refer autogen.sh in rng-tools
 do_configure:prepend() {
     cp ${S}/README.md ${S}/README
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#163579): https://lists.openembedded.org/g/openembedded-core/message/163579
Mute This Topic: https://lists.openembedded.org/mt/89971134/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

A message that is not in the archive (sent off-list or not yet received): OSBPR01MB1845F67F2E4385E4EBFB4F38DC189@OSBPR01MB1845.jpnprd01.prod.outlook.com

#3 lore raw

Please keep the replies on the mailing list. This patch should probably be merged with the libjitterentropy update?

Alex

Quoted 78 lines · On Wed, 23 Mar 2022 at 09:55, [email protected] <[email protected]> wrote:

After libjitterentropy is updated to 3.4, a macro JENT_CONF_ENABLE_INTERNAL_TIMER is added to jitterentropy.h used to control struct jent_notime_ct. rng-tools needs this struct, so it's need to make this macro enable.

--
Best Regards
---------------------------------------------------
Wang Mingyu
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: [email protected]
http://www.fujitsu.com/cn/fnst/

Quoted 62 lines

-----Original Message-----
From: Alexander Kanavin <[email protected]>
Sent: Wednesday, March 23, 2022 4:40 PM
To: Wang, Mingyu/王 鸣瑜 <[email protected]>
Cc: OE-core <[email protected]>
Subject: Re: [OE-core] [PATCH] rng-tools: enable macro JENT_CONF_ENABLE_INTERNAL_TIMER

This error is not seen on the autobuilder, can you please check why it occurs only in your local setup? The macro probably needs to be enabled in a more targeted way.

Alex

Quoted 4 lines · wangmy

do_compile error :
| ../git/rngd_jitter.c: In function 'rngd_notime_start':
| ../git/rngd_jitter.c:56:45: error: invalid use of undefined type 'struct

jent_notime_ctx'

Quoted 1 line

| 56 | ret =

-pthread_attr_init(&thread_ctx->notime_pthread_attr);

meta/recipes-support/rng-tools/rng-tools_6.15.bb INITSCRIPT_PARAMS = "start 03 2 3 4 5 . stop 30 0 6

Quoted 15 lines

enable macro JENT_CONF_ENABLE_INTERNAL_TIMER to use struct jent_notime_ctx

---
 meta/recipes-support/rng-tools/rng-tools_6.15.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/rng-tools/rng-tools_6.15.bb +0 -0
index ae974f9f6f..0696351903 100644
@@ -34,6 +34,8 @@ INITSCRIPT_PARAMS = "start 03 2 3 4 5 . stop 30 0 6

1 ."

Quoted 12 lines
meta/recipes-support/rng-tools/rng-tools_6.15.bb +2 -1
 SYSTEMD_SERVICE:${PN} = "rngd.service"
 
+CFLAGS += " -DJENT_CONF_ENABLE_INTERNAL_TIMER "
+
 # Refer autogen.sh in rng-tools
 do_configure:prepend() {
     cp ${S}/README.md ${S}/README
--

2.25.1

Quoted 4 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#163579):

https://lists.openembedded.org/g/openembedded-core/message/163579

Quoted 3 lines

Mute This Topic: https://lists.openembedded.org/mt/89971134/1686489
Group Owner: [email protected] Unsubscribe:

https://lists.openembedded.org/g/openembedded-core/unsub

Quoted 3 lines

[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#4 lore raw

Yes, if libjitterentropy is updated, rng-tools must be modified, otherwise do_compile errors will occur

  --
Best Regards
---------------------------------------------------
Wang Mingyu
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: [email protected]
http://www.fujitsu.com/cn/fnst/

Quoted 101 lines

-----Original Message-----
From: Alexander Kanavin <[email protected]>
Sent: Wednesday, March 23, 2022 5:02 PM
To: Wang, Mingyu/王 鸣瑜 <[email protected]>; OE-core <[email protected]>
Subject: Re: [OE-core] [PATCH] rng-tools: enable macro JENT_CONF_ENABLE_INTERNAL_TIMER

Please keep the replies on the mailing list. This patch should probably be merged with the libjitterentropy update?

Alex

Quoted 2 lines · On Wed, 23 Mar 2022 at 09:55, [email protected] <[email protected]> wrote:

After libjitterentropy is updated to 3.4, a macro

JENT_CONF_ENABLE_INTERNAL_TIMER is added to jitterentropy.h used to control struct jent_notime_ct.

Quoted 72 lines

rng-tools needs this struct, so it's need to make this macro enable.

--
Best Regards
---------------------------------------------------
Wang Mingyu
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: [email protected]
http://www.fujitsu.com/cn/fnst/

Quoted 57 lines

-----Original Message-----
From: Alexander Kanavin <[email protected]>
Sent: Wednesday, March 23, 2022 4:40 PM
To: Wang, Mingyu/王 鸣瑜 <[email protected]>
Cc: OE-core <[email protected]>
Subject: Re: [OE-core] [PATCH] rng-tools: enable macro JENT_CONF_ENABLE_INTERNAL_TIMER

This error is not seen on the autobuilder, can you please check why it occurs only in your local setup? The macro probably needs to be enabled in a more targeted way.

Alex

Quoted 5 lines · wangmy

do_compile error :

| ../git/rngd_jitter.c: In function 'rngd_notime_start':
| ../git/rngd_jitter.c:56:45: error: invalid use of undefined type
| 'struct

jent_notime_ctx'

Quoted 1 line

| 56 | ret =

-pthread_attr_init(&thread_ctx->notime_pthread_attr);

Quoted 15 lines

enable macro JENT_CONF_ENABLE_INTERNAL_TIMER to use struct jent_notime_ctx

---
 meta/recipes-support/rng-tools/rng-tools_6.15.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/rng-tools/rng-tools_6.15.bb +0 -0
index ae974f9f6f..0696351903 100644
@@ -34,6 +34,8 @@ INITSCRIPT_PARAMS = "start 03 2 3 4 5 . stop 30
Quoted 1 line

0 6

1 ."

Quoted 16 lines

SYSTEMD_SERVICE:${PN} = "rngd.service"

meta/recipes-support/rng-tools/rng-tools_6.15.bb +2 -1
+CFLAGS += " -DJENT_CONF_ENABLE_INTERNAL_TIMER "
+
 # Refer autogen.sh in rng-tools
 do_configure:prepend() {
     cp ${S}/README.md ${S}/README
--

2.25.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#163579):

https://lists.openembedded.org/g/openembedded-core/message/163579

Quoted 8 lines
Quoted 8 lines
Quoted 4 lines

Mute This Topic:
https://lists.openembedded.org/mt/89971134/1686489
Group Owner: [email protected] Unsubscribe:

https://lists.openembedded.org/g/openembedded-core/unsub

Quoted 3 lines

[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-