mtd: rawnand: mxs_nand: Fix use_minimum_ecc for spl driver
Subsystems (3)
PATCH 1/1 mtd: rawnand: mxs_nand: Fix use_minimum_ecc for spl driver
Because mxs_nand_spl driver does not support DM, to use the minimum ECC layout, it needs to handle the CONFIG_NAND_MXS_USE_MINIMUM_ECC.
--- drivers/mtd/nand/raw/mxs_nand.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/mtd/nand/raw/mxs_nand.c +4 -0
@@ -1380,6 +1380,10 @@ int mxs_nand_init_spl(struct nand_chip *nand)else nand_info->max_ecc_strength_supported =40 ; +#ifdef CONFIG_NAND_MXS_USE_MINIMUM_ECC + nand_info->use_minimum_ecc = true; +#endif + err =mxs_nand_alloc_buffers (nand_info);if (err)return err;
Signature · 1 line
2.7.4
Quoted 2 lines · Ye Li
Because
mxs_nand_spldriver does not support DM, to use the minimum ECC layout, it needs to handle theCONFIG_NAND_MXS_USE_MINIMUM_ECC.
Yes, spl also need the CONFIG_NAND_MXS_USE_MINIMUM_ECC flag.
Quoted 24 lines
Signed-off-by Ye Li <[email protected]>--- drivers/mtd/nand/raw/mxs_nand.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/mtd/nand/raw/mxs_nand.c +4
-0@@ -1380,6 +1380,10 @@ int mxs_nand_init_spl(struct nand_chip *nand)else nand_info->max_ecc_strength_supported =40 ; +#ifdef CONFIG_NAND_MXS_USE_MINIMUM_ECC + nand_info->use_minimum_ecc = true; +#endif + err =mxs_nand_alloc_buffers (nand_info);if (err)return err;Signature · 1 line
2.7.4
Fabio Estevam
reviewerHi Ye Li,
Quoted 14 lines · Ye Li
Because
mxs_nand_spldriver does not support DM, to use the minimum ECC layout, it needs to handle theCONFIG_NAND_MXS_USE_MINIMUM_ECC.Signed-off-by Ye Li <[email protected]>--- drivers/mtd/nand/raw/mxs_nand.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/mtd/nand/raw/mxs_nand.c +0
-0
drivers/mtd/nand/raw/mxs_nand.c int mxs_nand_init_spl(struct nand_chip *nand) · line 1385
Quoted 6 lines
drivers/mtd/nand/raw/mxs_nand.c +3
-0@@ -1380,6 +1380,10 @@ int mxs_nand_init_spl(struct nand_chip *nand)else nand_info->max_ecc_strength_supported =40 ; +#ifdef CONFIG_NAND_MXS_USE_MINIMUM_ECC + nand_info->use_minimum_ecc = true; +#endif
Please use if (IS_ENABLED(CONFIG_NAND_MXS_USE_MINIMUM_ECC)) as suggested by checkpatch:
WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible
#17: FILE: drivers/mtd/nand/raw/mxs_nand.c:1383:
+#ifdef CONFIG_NAND_MXS_USE_MINIMUM_ECC
Thanks