Skip to contentSkip to conversation

FAILED: patch "[PATCH] scsi: qla2xxx: Fix incorrect reporting of task management" failed to apply to 4.14-stable tree

PATCH [email protected] 1 participant 1 message Apr 2, 2022

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 58ca5999e0367d131de82a75257fbfd5aed0195d Mon Sep 17 00:00:00 2001
From: Quinn Tran <[email protected]>
Date: Thu, 10 Mar 2022 01:25:52 -0800
Subject: [PATCH] scsi: qla2xxx: Fix incorrect reporting of task management
failure

User experienced no task management error while target device is responding with error. The RSP_CODE field in the status IOCB is in little endian. Driver assumes it's big endian and it picked up erroneous data.

Convert the data back to big endian as is on the wire.

Fixes faef62d13463 ("[SCSI] qla2xxx: Fix Task Management command asynchronous handling")
drivers/scsi/qla2xxx/qla_isr.c +1 -0
index 092e4b5da65a..21b31d6359c8 100644
@@ -2498,6 +2498,7 @@ qla24xx_tm_iocb_entry(scsi_qla_host_t *vha, struct req_que *req, void *tsk)
 		iocb->u.tmf.data = QLA_FUNCTION_FAILED;
 	} else if ((le16_to_cpu(sts->scsi_status) &
 	    SS_RESPONSE_INFO_LEN_VALID)) {
+		host_to_fcp_swap(sts->data, sizeof(sts->data));
 		if (le32_to_cpu(sts->rsp_data_len) < 4) {
 			ql_log(ql_log_warn, fcport->vha, 0x503b,
 			    "Async-%s error - hdl=%x not enough response(%d).\n",