Skip to contentSkip to conversation

drm/hyperv: Add error message for fb size greater than allocated

PATCH Applied Saurabh Sengar 3 participants 4 messages Apr 12, 2022 – May 3, 2022

Subsystems (5)
lore
Share & tools
lore

Saurabh Sengar

author maintainer
#0 lore raw

PATCH v4 1/1 drm/hyperv: Add error message for fb size greater than allocated

Add error message when the size of requested framebuffer is more than the allocated size by vmbus mmio region for framebuffer

---
v3 -> v4 :
* Shorter error message
* Alignment match for open parenthesis
* Added -> Add (typo fix in commit message)

 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/hyperv/hyperv_drm_modeset.c +4 -1
index e82b815..27f4fcb 100644
@@ -123,8 +123,11 @@ static int hyperv_pipe_check(struct drm_simple_display_pipe *pipe,
 	if (fb->format->format != DRM_FORMAT_XRGB8888)
 		return -EINVAL;
 
-	if (fb->pitches[0] * fb->height > hv->fb_size)
+	if (fb->pitches[0] * fb->height > hv->fb_size) {
+		drm_err(&hv->dev, "fb size requested by %s for %dX%d (pitch %d) greater than %ld\n",
+			current->comm, fb->width, fb->height, fb->pitches[0], hv->fb_size);
 		return -EINVAL;
+	}
 
 	return 0;
 }
Signature · 1 line
1.8.3.1
author maintainer
#2 lore raw
Quoted 11 lines · Dexuan Cui
Quoted 5 lines

From: Saurabh Sengar <[email protected]>
Sent: Monday, April 11, 2022 9:29 PM
...
Add error message when the size of requested framebuffer is more than the allocated size by vmbus mmio region for framebuffer

The line lacks a period, but I guess the maintainer may help fix it for you :-)

Quoted 1 line

Can this be queued for next ? please let me know in case any clarification required.

maintainer Applied
#3 lore raw
Quoted 7 lines · Saurabh Singh Sengar
Quoted 6 lines · Dexuan Cui
Quoted 5 lines

From: Saurabh Sengar <[email protected]>
Sent: Monday, April 11, 2022 9:29 PM
...
Add error message when the size of requested framebuffer is more than the allocated size by vmbus mmio region for framebuffer

Quoted 7 lines
Quoted 5 lines

The line lacks a period, but I guess the maintainer may help fix it for you :-)

Quoted 1 line

Can this be queued for next ? please let me know in case any clarification required.

Applied to hyperv-next. Thanks.