Skip to contentSkip to conversation

libxl/arm: Insert "xen,dev-domid" property to virtio-mmio device node

PATCH In review Oleksandr Tyshchenko 2 participants 2 messages May 10, 2022 – May 17, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libxl/arm: Insert "xen,dev-domid" property to virtio-mmio device node

From: Oleksandr Tyshchenko <[email protected]>

Use specific binding for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled.

Based on device-tree binding from Linux:
Documentation/devicetree/bindings/arm/xen,dev-domid.yaml

---
!!! This patch is based on non upstreamed yet “Virtio support for toolstack on Arm” V8 series which is on review now:
https://lore.kernel.org/xen-devel/[email protected]/

New device-tree binding (commit #5) is a part of solution to restrict memory access under Xen using xen-grant DMA-mapping layer (which is also on review):
https://lore.kernel.org/xen-devel/[email protected]/

Changes RFC -> V1:
- update commit description
- rebase according to the recent changes to "libxl: Introduce basic virtio-mmio support on Arm"

---
 tools/libs/light/libxl_arm.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
tools/libs/light/libxl_arm.c +12 -2
index 37403a2..27ff328 100644
@@ -862,7 +862,8 @@ static int make_vpci_node(libxl__gc *gc, void *fdt,
 
 
 static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
-                                 uint64_t base, uint32_t irq)
+                                 uint64_t base, uint32_t irq,
+                                 uint32_t backend_domid)
 {
     int res;
     gic_interrupt intr;
@@ -887,6 +888,14 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt,
     res = fdt_property(fdt, "dma-coherent", NULL, 0);
     if (res) return res;
 
+    if (backend_domid != LIBXL_TOOLSTACK_DOMID) {
+        uint32_t domid[1];
+
+        domid[0] = cpu_to_fdt32(backend_domid);
+        res = fdt_property(fdt, "xen,dev-domid", domid, sizeof(domid));
+        if (res) return res;
+    }
+
     res = fdt_end_node(fdt);
     if (res) return res;
 
@@ -1205,7 +1214,8 @@ next_resize:
             libxl_device_disk *disk = &d_config->disks[i];
 
             if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO)
-                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) );
+                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq,
+                                           disk->backend_domid) );
         }
 
         if (pfdt)
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#1 lore raw

Hi Oleksandr,

Quoted 7 lines

-----Original Message-----
From: Oleksandr Tyshchenko <[email protected]>
Subject: [PATCH V1] libxl/arm: Insert "xen,dev-domid" property to virtio- mmio device node

From: Oleksandr Tyshchenko <[email protected]>

Quoted 7 lines

Use specific binding for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled.

Based on device-tree binding from Linux:
Documentation/devicetree/bindings/arm/xen,dev-domid.yaml

This patch looks good to me. So

Kind regards,
Henry