Skip to contentSkip to conversation

rewrite public API according to convention of GNOME project

PATCH New GitHub pull_request - opened 1 participant 1 message May 30, 2022 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

cover rewrite public API according to convention of GNOME project

alsa-project/alsa-gobject pull request #70 was opened from takaswie:

In GNOME convention for throw function which has an argument of GError to report failure, the function is programmed to return value of gboolean type to report whether the argument is filled with instance of GError. On the other hand, I wrote the throw functions to return nothing (void).

This patchset rewrite public API according to it. Unfortunately, it brings loss of backward compatibility.

```
Takashi Sakamoto (15):
  ctl: remove useless exposed symbols
  timer: user-instance: fix closure marshaller for event signal
  ctl: query: rewrite public API to return gboolean according to GNOME convention
  ctl: card: rewrite public API to return gboolean according to GNOME convention
  ctl: elem_info: rewrite public API to return gboolean according to GNOME convention
  rawmidi: query: rewrite public API to return gboolean according to GNOME convention
  rawmidi: stream_pair: rewrite public API to return gboolean according to GNOME convention
  hwdep: query: rewrite public API to return gboolean according to GNOME convention
  timer: query: rewrite public API to return gboolean according to GNOME convention
  timer: user_instance: rewrite public API to return gboolean according to GNOME convention
  timer: instance-params: rewrite public API to return gboolean according to GNOME convention
  seq: query: rewrite public API to return gboolean according to GNOME convention
  seq: user_client: rewrite public API to return gboolean according to GNOME convention
  seq: client_info: rewrite public API to return gboolean according to GNOME convention
  seq: event_cntr: rewrite public API to return gboolean according to GNOME convention

 samples/ctl                 |  21 +-
 samples/hwdep               |   8 +-
 samples/rawmidi             |  14 +-
 samples/seq                 |  37 +-
 samples/timer               |   9 +-
 src/ctl/alsactl.map         |  73 ++--
 src/ctl/card.c              | 322 +++++++++-------
 src/ctl/card.h              |  82 ++---
 src/ctl/elem-info.c         |  84 +++--
 src/ctl/elem-info.h         |  12 +-
 src/ctl/query.c             |  59 ++-
 src/ctl/query.h             |   8 +-
 src/hwdep/alsahwdep.map     |  13 +-
 src/hwdep/query.c           |  64 ++--
 src/hwdep/query.h           |  17 +-
 src/rawmidi/alsarawmidi.map |  37 +-
 src/rawmidi/privates.h      |   2 +-
 src/rawmidi/query.c         |  96 +++--
 src/rawmidi/query.h         |  37 +-
 src/rawmidi/stream-pair.c   | 163 +++++----
 src/rawmidi/stream-pair.h   |  31 +-
 src/seq/alsaseq.map         |  98 ++---
 src/seq/client-info.c       |  38 +-
 src/seq/client-info.h       |  16 +-
 src/seq/event-cntr.c        | 711 +++++++++++++++++++++---------------
 src/seq/event-cntr.h        | 203 +++++-----
 src/seq/query.c             | 298 +++++++++------
 src/seq/query.h             |  46 +--
 src/seq/user-client.c       | 413 +++++++++++++--------
 src/seq/user-client.h       | 140 +++----
 src/timer/alsatimer.map     |  44 ++-
 src/timer/instance-params.c |  30 +-
 src/timer/instance-params.h |   4 +-
 src/timer/query.c           | 163 ++++++---
 src/timer/query.h           |  23 +-
 src/timer/user-instance.c   | 192 ++++++----
 src/timer/user-instance.h   |  43 +--
 37 files changed, 2117 insertions(+), 1534 deletions(-)
```

Request URL : https://github.com/alsa-project/alsa-gobject/pull/70
Patch URL : https://github.com/alsa-project/alsa-gobject/pull/70.patch
Repository URL: https://github.com/alsa-project/alsa-gobject