Skip to contentSkip to conversation

FAILED: patch "[PATCH] zonefs: Clear inode information flags on inode creation" failed to apply to 5.18-stable tree

PATCH [email protected] 2 participants 2 messages Jun 6, 2022 – Jun 7, 2022

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.18-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From b954ebba296bb2eb2e38322f17aaa6426934bd7e Mon Sep 17 00:00:00 2001
From: Damien Le Moal <[email protected]>
Date: Tue, 12 Apr 2022 20:52:35 +0900
Subject: [PATCH] zonefs: Clear inode information flags on inode creation

Ensure that the i_flags field of struct zonefs_inode_info is cleared to 0 when initializing a zone file inode, avoiding seeing the flag ZONEFS_ZONE_OPEN being incorrectly set.

Fixes b5c00e975779 ("zonefs: open/close zone on file open/close")
fs/zonefs/super.c +1 -0
index 3614c7834007..75d8dabe0807 100644
@@ -1142,6 +1142,7 @@ static struct inode *zonefs_alloc_inode(struct super_block *sb)
 	inode_init_once(&zi->i_vnode);
 	mutex_init(&zi->i_truncate_mutex);
 	zi->i_wr_refcnt = 0;
+	zi->i_flags = 0;
 
 	return &zi->i_vnode;
 }
#1 lore raw
Quoted 9 lines · On 6/6/22 21:28, [email protected] wrote:

The patch below does not apply to the 5.18-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

Greg,

This patch is already applied to 5.18, 5.17, 5.15 and 5.10. I think that your bot picked it up again because of the bad PR I sent to Linus for 5.19 which had these patches included again.

My apologies for the noise.

Thanks !

Quoted 32 lines

------------------ original commit in Linus's tree ------------------

From b954ebba296bb2eb2e38322f17aaa6426934bd7e Mon Sep 17 00:00:00 2001
From: Damien Le Moal <[email protected]>
Date: Tue, 12 Apr 2022 20:52:35 +0900
Subject: [PATCH] zonefs: Clear inode information flags on inode creation

Ensure that the i_flags field of struct zonefs_inode_info is cleared to 0 when initializing a zone file inode, avoiding seeing the flag ZONEFS_ZONE_OPEN being incorrectly set.

Fixes b5c00e975779 ("zonefs: open/close zone on file open/close")
fs/zonefs/super.c +1 -0
index 3614c7834007..75d8dabe0807 100644
@@ -1142,6 +1142,7 @@ static struct inode *zonefs_alloc_inode(struct super_block *sb)
  	inode_init_once(&zi->i_vnode);
  	mutex_init(&zi->i_truncate_mutex);
  	zi->i_wr_refcnt = 0;
+	zi->i_flags = 0;
 
  	return &zi->i_vnode;
  }
Signature · 2 lines
Damien Le Moal
Western Digital Research