FAILED: patch "[PATCH] zonefs: fix handling of explicit_open option on mount" failed to apply to 5.18-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 5.18-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From a2a513be7139b279f1b5b2cee59c6c4950c34346 Mon Sep 17 00:00:00 2001
From: Damien Le Moal <[email protected]>
Date: Thu, 2 Jun 2022 23:16:57 +0900
Subject: [PATCH] zonefs: fix handling of explicit_open option on mount
Ignoring the explicit_open mount option on mount for devices that do not have a limit on the number of open zones must be done after the mount options are parsed and set in s_mount_opts. Move the check to ignore the explicit_open option after the call to zonefs_parse_options() in zonefs_fill_super().
fs/zonefs/super.c +6 -6
@@ -1760,12 +1760,6 @@ static int zonefs_fill_super(struct super_block *sb, void *data, int silent)atomic_set (&sbi->s_wro_seq_files,0 ); sbi->s_max_wro_seq_files =bdev_max_open_zones (sb->s_bdev); -if (!sbi->s_max_wro_seq_files && - sbi->s_mount_opts &ZONEFS_MNTOPT_EXPLICIT_OPEN ) { -zonefs_info (sb,"No open zones limit. Ignoring explicit_open mount option\n" ); - sbi->s_mount_opts &= ~ZONEFS_MNTOPT_EXPLICIT_OPEN ; - } -atomic_set (&sbi->s_active_seq_files,0 ); sbi->s_max_active_seq_files =bdev_max_active_zones (sb->s_bdev);
@@ -1790,6 +1784,12 @@ static int zonefs_fill_super(struct super_block *sb, void *data, int silent)zonefs_info (sb,"Mounting %u zones" ,blkdev_nr_zones (sb->s_bdev->bd_disk)); +if (!sbi->s_max_wro_seq_files && + sbi->s_mount_opts &ZONEFS_MNTOPT_EXPLICIT_OPEN ) { +zonefs_info (sb,"No open zones limit. Ignoring explicit_open mount option\n" ); + sbi->s_mount_opts &= ~ZONEFS_MNTOPT_EXPLICIT_OPEN ; + } +/* Create root directory inode */ ret = -ENOMEM ; inode =new_inode (sb);
PATCH 1/1 zonefs: fix handling of explicit_open option on mount
Commit a2a513be7139b279f1b5b2cee59c6c4950c34346 upstream.
Ignoring the explicit_open mount option on mount for devices that do not have a limit on the number of open zones must be done after the mount options are parsed and set in s_mount_opts. Move the check to ignore the explicit_open option after the call to zonefs_parse_options() in zonefs_fill_super().
--- fs/zonefs/super.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
fs/zonefs/super.c +6 -5
@@ -1690,11 +1690,6 @@ static int zonefs_fill_super(struct super_block *sb, void *data, int silent) sbi->s_mount_opts =ZONEFS_MNTOPT_ERRORS_RO ; sbi->s_max_open_zones =bdev_max_open_zones (sb->s_bdev);atomic_set (&sbi->s_open_zones,0 ); -if (!sbi->s_max_open_zones && - sbi->s_mount_opts &ZONEFS_MNTOPT_EXPLICIT_OPEN ) { -zonefs_info (sb,"No open zones limit. Ignoring explicit_open mount option\n" ); - sbi->s_mount_opts &= ~ZONEFS_MNTOPT_EXPLICIT_OPEN ; - } ret =zonefs_read_super (sb);if (ret)
@@ -1713,6 +1708,12 @@ static int zonefs_fill_super(struct super_block *sb, void *data, int silent)zonefs_info (sb,"Mounting %u zones" ,blkdev_nr_zones (sb->s_bdev->bd_disk)); +if (!sbi->s_max_open_zones && + sbi->s_mount_opts &ZONEFS_MNTOPT_EXPLICIT_OPEN ) { +zonefs_info (sb,"No open zones limit. Ignoring explicit_open mount option\n" ); + sbi->s_mount_opts &= ~ZONEFS_MNTOPT_EXPLICIT_OPEN ; + } +/* Create root directory inode */ ret = -ENOMEM ; inode =new_inode (sb);
Signature · 1 line
2.36.1
Quoted 9 lines · On 6/13/22 16:36, [email protected] wrote:
The patch below does not apply to the 5.18-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.thanks,
greg k-h
Hi Greg,
I sent you the fixed backported patch in reply to this email. The same patch also applies as-is to 5.17, 5.15 and 5.10.
Thanks !
Quoted 51 lines
------------------ original commit in Linus's tree ------------------
From
a2a513be7139b279f1b5b2cee59c6c4950c34346Mon Sep 17 00:00:00 2001
From: Damien Le Moal <[email protected]>
Date: Thu, 2 Jun 2022 23:16:57 +0900
Subject: [PATCH] zonefs: fix handling ofexplicit_openoption on mountIgnoring the
explicit_openmount option on mount for devices that do not have a limit on the number of open zones must be done after the mount options are parsed and set ins_mount_opts. Move the check to ignore theexplicit_openoption after the call tozonefs_parse_options()inzonefs_fill_super().Fixes b5c00e975779 ("zonefs: open/close zone on file open/close")Cc <[email protected]>Signed-off-by Damien Le Moal <[email protected]>Reviewed-by Christoph Hellwig <[email protected]>Reviewed-by Johannes Thumshirn <[email protected]>fs/zonefs/super.c +6
-6@@ -1760,12 +1760,6 @@ static int zonefs_fill_super(struct super_block *sb, void *data, int silent)atomic_set (&sbi->s_wro_seq_files,0 ); sbi->s_max_wro_seq_files =bdev_max_open_zones (sb->s_bdev); -if (!sbi->s_max_wro_seq_files && - sbi->s_mount_opts &ZONEFS_MNTOPT_EXPLICIT_OPEN ) { -zonefs_info (sb,"No open zones limit. Ignoring explicit_open mount option\n" ); - sbi->s_mount_opts &= ~ZONEFS_MNTOPT_EXPLICIT_OPEN ; - } -atomic_set (&sbi->s_active_seq_files,0 ); sbi->s_max_active_seq_files =bdev_max_active_zones (sb->s_bdev);@@ -1790,6 +1784,12 @@ static int zonefs_fill_super(struct super_block *sb, void *data, int silent)zonefs_info (sb,"Mounting %u zones" ,blkdev_nr_zones (sb->s_bdev->bd_disk)); +if (!sbi->s_max_wro_seq_files && + sbi->s_mount_opts &ZONEFS_MNTOPT_EXPLICIT_OPEN ) { +zonefs_info (sb,"No open zones limit. Ignoring explicit_open mount option\n" ); + sbi->s_mount_opts &= ~ZONEFS_MNTOPT_EXPLICIT_OPEN ; + } +/* Create root directory inode */ ret = -ENOMEM ; inode =new_inode (sb);
Signature · 2 lines
Damien Le Moal Western Digital Research
Greg KH
maintainerQuoted 7 lines · Damien Le Moal
Quoted 6 lines · On 6/13/22 16:36, [email protected] wrote:
The patch below does not apply to the 5.18-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
Quoted 8 lines
Quoted 3 lines
thanks,
greg k-h
Hi Greg,
I sent you the fixed backported patch in reply to this email. The same patch also applies as-is to 5.17, 5.15 and 5.10.
Thanks, now queued up.
greg k-h