Skip to contentSkip to conversation

rootfs: add option to allow delayed postinsts on read-only rootfs

PATCH Anton Kachalov 2 participants 4 messages Jan 19, 2021 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Ping on the patch

Quoted 51 lines · Anton Kachalov via lists.openembedded.org

Example use case in OpenBMC: rootfs is squashfs and the system has either overlayfs for whole rootfs or for some parts (e.g. /etc).

This option will allow to create migration one-shot postinsts using "pkg_postinst_ontarget_${PN}" routines defined in recipes to fix files under upper workdir in overlayfs.

---
 meta/classes/image.bbclass | 2 +-
 meta/lib/oe/rootfs.py      | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)
meta/classes/image.bbclass +0 -1
index 045f4494c8..3239d5cf5e 100644
@@ -33,7 +33,7 @@ INHIBIT_DEFAULT_DEPS = "1"
 # IMAGE_FEATURES may contain any available package group
 IMAGE_FEATURES ?= ""
 IMAGE_FEATURES[type] = "list"
-IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs

stateless-rootfs empty-root-password allow-empty-password allow-root-login post-install-logging"
+IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs read-only-rootfs-delayed-postinsts stateless-rootfs empty-root-password allow-empty-password allow-root-login post-install-logging"

# Generate companion debugfs?
IMAGE_GEN_DEBUGFS ?= "0"

meta/lib/oe/rootfs.py +3 -1
index 4b747dd0f4..249c685dcf 100644
@@ -217,6 +217,9 @@ class Rootfs(object, metaclass=ABCMeta):
             self.progress_reporter.next_stage()
 
         if bb.utils.contains("IMAGE_FEATURES", "read-only-rootfs",
+                         True, False, self.d) and \
+           not bb.utils.contains("IMAGE_FEATURES",
+                         "read-only-rootfs-delayed-postinsts",
                          True, False, self.d):
             delayed_postinsts = self._get_delayed_postinsts()
             if delayed_postinsts is not None:
--

2.30.0.284.gd98b1dd5eaa7-goog

#4 lore raw
Quoted 1 line · Anton Kachalov

Thanks! I've expected some kind of ack :)

That would add a lot of mailing list noise and work for me when its relatively obvious looking at the git tree! :)

Cheers,

Richard