FAILED: patch "[PATCH] mlx5: do not use RT_TOS for IPv6 flowlabel" failed to apply to 5.4-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From bcb0da7fffee9464073998b267ce5543da2356d2 Mon Sep 17 00:00:00 2001
From: Matthias May <[email protected]>
Date: Fri, 5 Aug 2022 21:19:05 +0200
Subject: [PATCH] mlx5: do not use RT_TOS for IPv6 flowlabel
According to Guillaume Nault RT_TOS should never be used for IPv6.
Quote:RT_TOS() is an old macro used to interprete IPv4 TOS as described in the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4 code, although, given the current state of the code, most of the existing calls have no consequence.
But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS" field to be interpreted the RFC 1349 way. There's no historical compatibility to worry about.
drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c +2 -2
@@ -506,7 +506,7 @@ int mlx5e_tc_tun_create_header_ipv6(struct mlx5e_priv *priv,int err; attr.ttl = tun_key->ttl; - attr.fl.fl6.flowlabel =ip6_make_flowinfo (RT_TOS (tun_key->tos), tun_key->label); + attr.fl.fl6.flowlabel =ip6_make_flowinfo (tun_key->tos, tun_key->label); attr.fl.fl6.daddr = tun_key->u.ipv6.dst; attr.fl.fl6.saddr = tun_key->u.ipv6.src;
@@ -620,7 +620,7 @@ int mlx5e_tc_tun_update_header_ipv6(struct mlx5e_priv *priv, attr.ttl = tun_key->ttl; - attr.fl.fl6.flowlabel =ip6_make_flowinfo (RT_TOS (tun_key->tos), tun_key->label); + attr.fl.fl6.flowlabel =ip6_make_flowinfo (tun_key->tos, tun_key->label); attr.fl.fl6.daddr = tun_key->u.ipv6.dst; attr.fl.fl6.saddr = tun_key->u.ipv6.src;