FAILED: patch "[PATCH] ASoC: SOF: Intel: hda: Fix potential buffer overflow by" failed to apply to 5.15-stable tree
Subsystems (4)
[email protected]
maintainerThe patch below does not apply to the 5.15-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 94c1ceb043c1a002de9649bb630c8e8347645982 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <[email protected]>
Date: Mon, 1 Aug 2022 18:54:20 +0200
Subject: [PATCH] ASoC: SOF: Intel: hda: Fix potential buffer overflow by
snprintf()
snprintf() returns the would-be-filled size when the string overflows the given buffer size, hence using this value may result in the buffer overflow (although it's unrealistic).
This patch replaces with a safer version, scnprintf() for papering over such a potential issue.
sound/soc/sof/intel/hda.c +1 -1
@@ -574,7 +574,7 @@ static void hda_dsp_dump_ext_rom_status(struct snd_sof_dev *sdev, const char *le chip =get_chip_info (sdev->pdata);for (i =0 ; i <HDA_EXT_ROM_STATUS_SIZE ; i++) { value =snd_sof_dsp_read (sdev,HDA_DSP_BAR , chip->rom_status_reg + i *0x4 ); - len +=snprintf (msg + len,sizeof (msg) - len," 0x%x" , value); + len +=scnprintf (msg + len,sizeof (msg) - len," 0x%x" , value); }dev_printk (level, sdev->dev,"extended rom status: %s" , msg);