Skip to contentSkip to conversation

ACPI: platform: Use PLATFORM_DEVID_NONE in acpi_create_platform_device()

PATCH Applied John Garry 3 participants 3 messages Sep 1, 2022 – Sep 3, 2022 ACPI

lore
Share & tools
lore

John Garry

author
#0 lore raw

PATCH 1/1 ACPI: platform: Use PLATFORM_DEVID_NONE in acpi_create_platform_device()

Instead of hardcoding the value for the id, use PLATFORM_DEVID_NONE.

drivers/acpi/acpi_platform.c +1 -1
index de3cbf152dee..d33334c9b8e5 100644
@@ -140,7 +140,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev,
 	pdevinfo.parent = adev->parent ?
 		acpi_get_first_physical_node(adev->parent) : NULL;
 	pdevinfo.name = dev_name(&adev->dev);
-	pdevinfo.id = -1;
+	pdevinfo.id = PLATFORM_DEVID_NONE;
 	pdevinfo.res = resources;
 	pdevinfo.num_res = count;
 	pdevinfo.fwnode = acpi_fwnode_handle(adev);
Signature · 1 line
2.35.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · John Garry

Instead of hardcoding the value for the id, use PLATFORM_DEVID_NONE.

Quoted 18 lines
drivers/acpi/acpi_platform.c +1 -2
index de3cbf152dee..d33334c9b8e5 100644
@@ -140,7 +140,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev,
        pdevinfo.parent = adev->parent ?
                acpi_get_first_physical_node(adev->parent) : NULL;
        pdevinfo.name = dev_name(&adev->dev);
-       pdevinfo.id = -1;
+       pdevinfo.id = PLATFORM_DEVID_NONE;
        pdevinfo.res = resources;
        pdevinfo.num_res = count;
        pdevinfo.fwnode = acpi_fwnode_handle(adev);
--

2.35.3

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Applied
#2 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 2 lines · John Garry

Instead of hardcoding the value for the id, use PLATFORM_DEVID_NONE.

Quoted 2 lines
Quoted 14 lines
Quoted 5 lines
drivers/acpi/acpi_platform.c +0 -0
index de3cbf152dee..d33334c9b8e5 100644

drivers/acpi/acpi_platform.c struct platform_device *acpi_create_platform_device(struct acpi_device *adev,

Quoted 9 lines
drivers/acpi/acpi_platform.c +1 -2
@@ -140,7 +140,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev,
        pdevinfo.parent = adev->parent ?
                acpi_get_first_physical_node(adev->parent) : NULL;
        pdevinfo.name = dev_name(&adev->dev);
-       pdevinfo.id = -1;
+       pdevinfo.id = PLATFORM_DEVID_NONE;
        pdevinfo.res = resources;
        pdevinfo.num_res = count;
        pdevinfo.fwnode = acpi_fwnode_handle(adev);
--

Applied as 6.1 material, thanks!