bpf: use kvmemdup_bpfptr helper
PATCH v2 1/1 bpf: use kvmemdup_bpfptr helper
Use kvmemdup_bpfptr helper instead of open-coding to simplify the code.
Signed-off-by Wang Yufen <[email protected]>
--- kernel/bpf/syscall.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)
kernel/bpf/syscall.c +4 -9
@@ -1416,19 +1416,14 @@ static int map_update_elem(union bpf_attr *attr, bpfptr_t uattr) } value_size =bpf_map_value_size (map); - - err = -ENOMEM ; - value =kvmalloc (value_size,GFP_USER | __GFP_NOWARN); -if (!value) + value =kvmemdup_bpfptr (uvalue, value_size); +if (IS_ERR (value)) { + err =PTR_ERR (value); goto free_key; - - err = -EFAULT ; -if (copy_from_bpfptr (value, uvalue, value_size) !=0 ) - goto free_value; + } err =bpf_map_update_value (map, f, key, value, attr->flags); -free_value:kvfree (value); free_key:kvfree (key);
Signature · 1 line
1.8.3.1
Quoted 5 lines · Wang Yufen
Use
kvmemdup_bpfptrhelper instead of open-coding to simplify the code.Signed-off-by Wang Yufen <[email protected]>
Quoted 35 lines
--- kernel/bpf/syscall.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)kernel/bpf/syscall.c +4
-10@@ -1416,19 +1416,14 @@ static int map_update_elem(union bpf_attr *attr, bpfptr_t uattr) } value_size =bpf_map_value_size (map); - - err = -ENOMEM ; - value =kvmalloc (value_size,GFP_USER | __GFP_NOWARN); -if (!value) + value =kvmemdup_bpfptr (uvalue, value_size); +if (IS_ERR (value)) { + err =PTR_ERR (value); goto free_key; - - err = -EFAULT ; -if (copy_from_bpfptr (value, uvalue, value_size) !=0 ) - goto free_value; + } err =bpf_map_update_value (map, f, key, value, attr->flags); -free_value:kvfree (value); free_key:kvfree (key); --1.8.3.1
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:
Quoted 7 lines · On Tue, 13 Sep 2022 16:40:33 +0800 you wrote:
Use
kvmemdup_bpfptrhelper instead of open-coding to simplify the code.Signed-off-by Wang Yufen <[email protected]>--- kernel/bpf/syscall.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)
Here is the summary with links:
- [bpf-next,v2] bpf: use kvmemdup_bpfptr helper
https://git.kernel.org/bpf/bpf-next/c/a02c118ee9e8
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html