ACPI: AC: Remove the leftover struct acpi_ac_bl
PATCH 1/1 ACPI: AC: Remove the leftover struct acpi_ac_bl
In commit 57a183222271 ("ACPI / x86: Introduce an acpi_quirk_skip_acpi_ac_and_battery() helper"), the usage of struct acpi_ac_bl was removed, but left the definition of the struct in the file, so remove the useless code.
--- drivers/acpi/ac.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/acpi/ac.c +0 -5
@@ -36,11 +36,6 @@static int acpi_ac_remove (struct acpi_device *device);static void acpi_ac_notify (struct acpi_device *device,u32 event); -struct acpi_ac_bl { -const char *hid; -int hrv; -}; -static const struct acpi_device_id ac_device_ids[] = { {"ACPI0003" ,0 }, {"" ,0 },
Signature · 1 line
1.7.12.4
Hi,
Quoted 6 lines · Hanjun Guo
In commit
57a183222271("ACPI / x86: Introduce anacpi_quirk_skip_acpi_ac_and_battery()helper"), the usage of structacpi_ac_blwas removed, but left the definition of the struct in the file, so remove the useless code.Signed-off-by Hanjun Guo <[email protected]>
Good catch, thanks. Patch looks good to me:
Regards,
Hans
Quoted 20 lines
--- drivers/acpi/ac.c | 5 ----- 1 file changed, 5 deletions(-)drivers/acpi/ac.c +0
-5@@ -36,11 +36,6 @@static int acpi_ac_remove (struct acpi_device *device);static void acpi_ac_notify (struct acpi_device *device,u32 event); -struct acpi_ac_bl { -const char *hid; -int hrv; -}; -static const struct acpi_device_id ac_device_ids[] = { {"ACPI0003" ,0 }, {"" ,0 },
Quoted 9 lines · Hans de Goede
Hi,
Quoted 5 lines · Hanjun Guo
In commit
57a183222271("ACPI / x86: Introduce anacpi_quirk_skip_acpi_ac_and_battery()helper"), the usage of structacpi_ac_blwas removed, but left the definition of the struct in the file, so remove the useless code.
Quoted 5 lines
Quoted 1 line
Signed-off-by Hanjun Guo <[email protected]>Good catch, thanks. Patch looks good to me:
Reviewed-by Hans de Goede <[email protected]>
Applied as 6.1 material, thanks!
Quoted 21 lines
Quoted 20 lines
--- drivers/acpi/ac.c | 5 ----- 1 file changed, 5 deletions(-)drivers/acpi/ac.c +0
-5@@ -36,11 +36,6 @@static int acpi_ac_remove (struct acpi_device *device);static void acpi_ac_notify (struct acpi_device *device,u32 event); -struct acpi_ac_bl { -const char *hid; -int hrv; -}; -static const struct acpi_device_id ac_device_ids[] = { {"ACPI0003" ,0 }, {"" ,0 },