Skip to contentSkip to conversation

dt-bindings: clocks: imx8mp: Add ID for usb suspend clock

PATCH Applied Li Jun 4 participants 12 messages Sep 30, 2022 – Jan 9, 2023 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore

Li Jun

author
#0 lore raw

PATCH v4 1/3 dt-bindings: clocks: imx8mp: Add ID for usb suspend clock

usb suspend clock has a gate shared with usb_root_clk.

Fixes 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
Cc [email protected] # v5.19+
---
 include/dt-bindings/clock/imx8mp-clock.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/dt-bindings/clock/imx8mp-clock.h +2 -1
index 9d5cc2ddde89..1417b7b1b7df 100644
@@ -324,8 +324,9 @@
 #define IMX8MP_CLK_CLKOUT2_SEL			317
 #define IMX8MP_CLK_CLKOUT2_DIV			318
 #define IMX8MP_CLK_CLKOUT2			319
+#define IMX8MP_CLK_USB_SUSP			320
 
-#define IMX8MP_CLK_END				320
+#define IMX8MP_CLK_END				321
 
 #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG		0
 #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1		1
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH v4 2/3 clk: imx: imx8mp: add shared clk gate for usb suspend clk

32K usb suspend clock gate is shared with usb_root_clk, this shared clock gate was initially defined only for usb suspend clock, usb suspend clk is kept on while system is active or system sleep with usb wakeup enabled, so usb root clock is fine with this situation; with the commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk parent"), this clock gate is changed to be for usb root clock, but usb root clock will be off while usb is suspended, so usb suspend clock will be gated too, this cause some usb functionalities will not work, so define this clock to be a shared clock gate to conform with the real HW status.

Fixes 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
Cc [email protected] # v5.19+

---
change for v4:
- improve the commit log to explain why this is stable stuff.

 drivers/clk/imx/clk-imx8mp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/clk/imx/clk-imx8mp.c +3 -1
index e89db568f5a8..5b66514bdd0c 100644
@@ -17,6 +17,7 @@
 
 static u32 share_count_nand;
 static u32 share_count_media;
+static u32 share_count_usb;
 
 static const char * const pll_ref_sels[] = { "osc_24m", "dummy", "dummy", "dummy", };
 static const char * const audio_pll1_bypass_sels[] = {"audio_pll1", "audio_pll1_ref_sel", };
@@ -673,7 +674,8 @@ static int imx8mp_clocks_probe(struct platform_device *pdev)
 	hws[IMX8MP_CLK_UART2_ROOT] = imx_clk_hw_gate4("uart2_root_clk", "uart2", ccm_base + 0x44a0, 0);
 	hws[IMX8MP_CLK_UART3_ROOT] = imx_clk_hw_gate4("uart3_root_clk", "uart3", ccm_base + 0x44b0, 0);
 	hws[IMX8MP_CLK_UART4_ROOT] = imx_clk_hw_gate4("uart4_root_clk", "uart4", ccm_base + 0x44c0, 0);
-	hws[IMX8MP_CLK_USB_ROOT] = imx_clk_hw_gate4("usb_root_clk", "hsio_axi", ccm_base + 0x44d0, 0);
+	hws[IMX8MP_CLK_USB_ROOT] = imx_clk_hw_gate2_shared2("usb_root_clk", "hsio_axi", ccm_base + 0x44d0, 0, &share_count_usb);
+	hws[IMX8MP_CLK_USB_SUSP] = imx_clk_hw_gate2_shared2("usb_suspend_clk", "osc_32k", ccm_base + 0x44d0, 0, &share_count_usb);
 	hws[IMX8MP_CLK_USB_PHY_ROOT] = imx_clk_hw_gate4("usb_phy_root_clk", "usb_phy_ref", ccm_base + 0x44f0, 0);
 	hws[IMX8MP_CLK_USDHC1_ROOT] = imx_clk_hw_gate4("usdhc1_root_clk", "usdhc1", ccm_base + 0x4510, 0);
 	hws[IMX8MP_CLK_USDHC2_ROOT] = imx_clk_hw_gate4("usdhc2_root_clk", "usdhc2", ccm_base + 0x4520, 0);
Signature · 1 line
2.34.1
author
#7 lore raw

PATCH v4 3/3 arm64: dts: imx8mp: correct usb clocks

In reply to Li Jun

After commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk parent"), usb_root_clk is no longer for suspend clock so update dts accordingly to use right bus clock and suspend clock.

Fixes fb8587a2c165 ("arm64: dtsi: imx8mp: add usb nodes")
Cc [email protected] # v5.19+
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/freescale/imx8mp.dtsi +6 -6
index 522ab47426c3..c3dfeb4f4b15 100644
@@ -1169,7 +1169,7 @@ usb3_0: usb@32f10100 {
 			reg = <0x32f10100 0x8>,
 			      <0x381f0000 0x20>;
 			clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
-				 <&clk IMX8MP_CLK_USB_ROOT>;
+				 <&clk IMX8MP_CLK_USB_SUSP>;
 			clock-names = "hsio", "suspend";
 			interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
 			power-domains = <&hsio_blk_ctrl IMX8MP_HSIOBLK_PD_USB>;
@@ -1182,9 +1182,9 @@ usb3_0: usb@32f10100 {
 			usb_dwc3_0: usb@38100000 {
 				compatible = "snps,dwc3";
 				reg = <0x38100000 0x10000>;
-				clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
+				clocks = <&clk IMX8MP_CLK_USB_ROOT>,
 					 <&clk IMX8MP_CLK_USB_CORE_REF>,
-					 <&clk IMX8MP_CLK_USB_ROOT>;
+					 <&clk IMX8MP_CLK_USB_SUSP>;
 				clock-names = "bus_early", "ref", "suspend";
 				interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
 				phys = <&usb3_phy0>, <&usb3_phy0>;
@@ -1211,7 +1211,7 @@ usb3_1: usb@32f10108 {
 			reg = <0x32f10108 0x8>,
 			      <0x382f0000 0x20>;
 			clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
-				 <&clk IMX8MP_CLK_USB_ROOT>;
+				 <&clk IMX8MP_CLK_USB_SUSP>;
 			clock-names = "hsio", "suspend";
 			interrupts = <GIC_SPI 149 IRQ_TYPE_LEVEL_HIGH>;
 			power-domains = <&hsio_blk_ctrl IMX8MP_HSIOBLK_PD_USB>;
@@ -1224,9 +1224,9 @@ usb3_1: usb@32f10108 {
 			usb_dwc3_1: usb@38200000 {
 				compatible = "snps,dwc3";
 				reg = <0x38200000 0x10000>;
-				clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
+				clocks = <&clk IMX8MP_CLK_USB_ROOT>,
 					 <&clk IMX8MP_CLK_USB_CORE_REF>,
-					 <&clk IMX8MP_CLK_USB_ROOT>;
+					 <&clk IMX8MP_CLK_USB_SUSP>;
 				clock-names = "bus_early", "ref", "suspend";
 				interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
 				phys = <&usb3_phy1>, <&usb3_phy1>;
Signature · 1 line
2.34.1
author
#2 lore raw

RE: [PATCH v4 2/3] clk: imx: imx8mp: add shared clk gate for usb suspend clk

In reply to Li Jun

Hi Stephen,

Quoted 24 lines

-----Original Message-----
From: Jun Li <[email protected]>
Sent: Friday, September 30, 2022 10:54 PM
To: [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>; [email protected]; [email protected]; Peng Fan <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [PATCH v4 2/3] clk: imx: imx8mp: add shared clk gate for usb suspend clk

32K usb suspend clock gate is shared with usb_root_clk, this shared clock gate was initially defined only for usb suspend clock, usb suspend clk is kept on while system is active or system sleep with usb wakeup enabled, so usb root clock is fine with this situation; with the commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk parent"), this clock gate is changed to be for usb root clock, but usb root clock will be off while usb is suspended, so usb suspend clock will be gated too, this cause some usb functionalities will not work, so define this clock to be a shared clock gate to conform with the real HW status.

Quoted 4 lines
Fixes 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
Cc [email protected] # v5.19+

Is this version okay for you?

Thanks
Li Jun

Quoted 34 lines

---
change for v4:
- improve the commit log to explain why this is stable stuff.

 drivers/clk/imx/clk-imx8mp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/clk/imx/clk-imx8mp.c +1 -0
index e89db568f5a8..5b66514bdd0c 100644
@@ -17,6 +17,7 @@
 
 static u32 share_count_nand;
 static u32 share_count_media;
+static u32 share_count_usb;
 
 static const char * const pll_ref_sels[] = { "osc_24m", "dummy", "dummy",

"dummy", }; static const char * const audio_pll1_bypass_sels[] = {"audio_pll1", "audio_pll1_ref_sel", }; @@ -673,7 +674,8 @@ static int imx8mp_clocks_probe(struct platform_device *pdev)
hws[IMX8MP_CLK_UART2_ROOT] = imx_clk_hw_gate4("uart2_root_clk",
"uart2", ccm_base + 0x44a0, 0);
hws[IMX8MP_CLK_UART3_ROOT] = imx_clk_hw_gate4("uart3_root_clk",
"uart3", ccm_base + 0x44b0, 0);
hws[IMX8MP_CLK_UART4_ROOT] = imx_clk_hw_gate4("uart4_root_clk",
"uart4", ccm_base + 0x44c0, 0);

drivers/clk/imx/clk-imx8mp.c +0 -1
-	hws[IMX8MP_CLK_USB_ROOT] = imx_clk_hw_gate4("usb_root_clk",

"hsio_axi", ccm_base + 0x44d0, 0);

drivers/clk/imx/clk-imx8mp.c +1 -0
+	hws[IMX8MP_CLK_USB_ROOT] = imx_clk_hw_gate2_shared2("usb_root_clk",

"hsio_axi", ccm_base + 0x44d0, 0, &share_count_usb);

drivers/clk/imx/clk-imx8mp.c +1 -0
+	hws[IMX8MP_CLK_USB_SUSP] =

imx_clk_hw_gate2_shared2("usb_suspend_clk", +"osc_32k", ccm_base + 0x44d0, 0, &share_count_usb);

Quoted 8 lines

hws[IMX8MP_CLK_USB_PHY_ROOT] = imx_clk_hw_gate4("usb_phy_root_clk",
"usb_phy_ref", ccm_base + 0x44f0, 0);
hws[IMX8MP_CLK_USDHC1_ROOT] = imx_clk_hw_gate4("usdhc1_root_clk",
"usdhc1", ccm_base + 0x4510, 0);
hws[IMX8MP_CLK_USDHC2_ROOT] = imx_clk_hw_gate4("usdhc2_root_clk",
"usdhc2", ccm_base + 0x4520, 0);
--
2.34.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Applied
#9 lore raw
In reply to Li Jun
Quoted 7 lines · Li Jun

usb suspend clock has a gate shared with usb_root_clk.

Fixes 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
Cc [email protected] # v5.19+

Applied all. Thanks.

Quoted 22 lines
---
 include/dt-bindings/clock/imx8mp-clock.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/dt-bindings/clock/imx8mp-clock.h +2 -1
index 9d5cc2ddde89..1417b7b1b7df 100644
@@ -324,8 +324,9 @@
 #define IMX8MP_CLK_CLKOUT2_SEL			317
 #define IMX8MP_CLK_CLKOUT2_DIV			318
 #define IMX8MP_CLK_CLKOUT2			319
+#define IMX8MP_CLK_USB_SUSP			320
 
-#define IMX8MP_CLK_END				320
+#define IMX8MP_CLK_END				321
 
 #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG		0
 #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1		1
Signature · 1 line
2.34.1
author
#10 lore raw
Quoted 20 lines

-----Original Message-----
From: Abel Vesa <[email protected]>
Sent: Monday, November 21, 2022 11:57 PM
To: Jun Li <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>; [email protected]; [email protected]; Peng Fan <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v4 1/3] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock

Quoted 2 lines · Li Jun

usb suspend clock has a gate shared with usb_root_clk.

Quoted 7 lines
Quoted 5 lines
Fixes 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
Cc [email protected] # v5.19+

Applied all. Thanks.

Hi Abel,

Could you please also take the dts patch[1] in this series? As the dts patch has a build dependency on the clk patches, So Shawn suggested you take the dts patch too [2].

[1] https://www.spinics.net/lists/linux-clk/msg75904.html
[2] https://www.spinics.net/lists/arm-kernel/msg1013220.html

Thanks
Li Jun

Quoted 24 lines

Review

Quoted 6 lines
---
 include/dt-bindings/clock/imx8mp-clock.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/include/dt-bindings/clock/imx8mp-clock.h

Quoted 17 lines

index 9d5cc2ddde89..1417b7b1b7df 100644

include/dt-bindings/clock/imx8mp-clock.h +2 -2
@@ -324,8 +324,9 @@
 #define IMX8MP_CLK_CLKOUT2_SEL			317
 #define IMX8MP_CLK_CLKOUT2_DIV			318
 #define IMX8MP_CLK_CLKOUT2			319
+#define IMX8MP_CLK_USB_SUSP			320
 
-#define IMX8MP_CLK_END				320
+#define IMX8MP_CLK_END				321
 
 #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG		0
 #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1		1
--

2.34.1

#11 lore raw
Quoted 28 lines · Jun Li
Quoted 20 lines

-----Original Message-----
From: Abel Vesa <[email protected]>
Sent: Monday, November 21, 2022 11:57 PM
To: Jun Li <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>; [email protected]; [email protected]; Peng Fan <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v4 1/3] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock

Quoted 2 lines · Li Jun

usb suspend clock has a gate shared with usb_root_clk.

Quoted 7 lines
Quoted 5 lines
Fixes 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
Cc [email protected] # v5.19+

Applied all. Thanks.

Quoted 8 lines

Hi Abel,

Could you please also take the dts patch[1] in this series? As the dts patch has a build dependency on the clk patches, So Shawn suggested you take the dts patch too [2].

[1] https://www.spinics.net/lists/linux-clk/msg75904.html
[2] https://www.spinics.net/lists/arm-kernel/msg1013220.html

DTS cannot go via driver tree. Share the header from DTS tree to driver to solve it... or add defines to your DTS.

Best regards,
Krzysztof

Applied
#8 lore raw

Re: [PATCH v4 3/3] arm64: dts: imx8mp: correct usb clocks

In reply to Li Jun
Quoted 10 lines · Li Jun

After commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk parent"), usb_root_clk is no longer for suspend clock so update dts accordingly to use right bus clock and suspend clock.

Fixes fb8587a2c165 ("arm64: dtsi: imx8mp: add usb nodes")
Cc [email protected] # v5.19+

Applied, thanks!

#4 lore raw

Re: [PATCH v4 2/3] clk: imx: imx8mp: add shared clk gate for usb suspend clk

In reply to a message not in the archive
Quoted 32 lines · Stephen Boyd

Quoting Jun Li (2022-10-19 02:26:00)

Quoted 31 lines

Hi Stephen,

Quoted 28 lines

-----Original Message-----
From: Jun Li <[email protected]>
Sent: Friday, September 30, 2022 10:54 PM
To: [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>; [email protected]; [email protected]; Peng Fan <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [PATCH v4 2/3] clk: imx: imx8mp: add shared clk gate for usb suspend clk

32K usb suspend clock gate is shared with usb_root_clk, this shared clock gate was initially defined only for usb suspend clock, usb suspend clk is kept on while system is active or system sleep with usb wakeup enabled, so usb root clock is fine with this situation; with the commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk parent"), this clock gate is changed to be for usb root clock, but usb root clock will be off while usb is suspended, so usb suspend clock will be gated too, this cause some usb functionalities will not work, so define this clock to be a shared clock gate to conform with the real HW status.

Fixes 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
Cc [email protected] # v5.19+
Quoted 4 lines
Quoted 2 lines

Is this version okay for you?

I thought that Abel was going to pick these up.

Oh, sorry, I thought the fixes will be picked up by you.

I'll apply it to my tree then.

Reviewed-by on v4 2/3
#6 lore raw

Re: [PATCH v4 2/3] clk: imx: imx8mp: add shared clk gate for usb suspend clk

In reply to Li Jun
Quoted 12 lines · Li Jun

32K usb suspend clock gate is shared with usb_root_clk, this shared clock gate was initially defined only for usb suspend clock, usb suspend clk is kept on while system is active or system sleep with usb wakeup enabled, so usb root clock is fine with this situation; with the commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk parent"), this clock gate is changed to be for usb root clock, but usb root clock will be off while usb is suspended, so usb suspend clock will be gated too, this cause some usb functionalities will not work, so define this clock to be a shared clock gate to conform with the real HW status.

Quoted 4 lines
Fixes 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
Cc [email protected] # v5.19+
Quoted 32 lines

---
change for v4:
- improve the commit log to explain why this is stable stuff.

 drivers/clk/imx/clk-imx8mp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/clk/imx/clk-imx8mp.c +3 -1
index e89db568f5a8..5b66514bdd0c 100644
@@ -17,6 +17,7 @@
 
 static u32 share_count_nand;
 static u32 share_count_media;
+static u32 share_count_usb;
 
 static const char * const pll_ref_sels[] = { "osc_24m", "dummy", "dummy", "dummy", };
 static const char * const audio_pll1_bypass_sels[] = {"audio_pll1", "audio_pll1_ref_sel", };
@@ -673,7 +674,8 @@ static int imx8mp_clocks_probe(struct platform_device *pdev)
 	hws[IMX8MP_CLK_UART2_ROOT] = imx_clk_hw_gate4("uart2_root_clk", "uart2", ccm_base + 0x44a0, 0);
 	hws[IMX8MP_CLK_UART3_ROOT] = imx_clk_hw_gate4("uart3_root_clk", "uart3", ccm_base + 0x44b0, 0);
 	hws[IMX8MP_CLK_UART4_ROOT] = imx_clk_hw_gate4("uart4_root_clk", "uart4", ccm_base + 0x44c0, 0);
-	hws[IMX8MP_CLK_USB_ROOT] = imx_clk_hw_gate4("usb_root_clk", "hsio_axi", ccm_base + 0x44d0, 0);
+	hws[IMX8MP_CLK_USB_ROOT] = imx_clk_hw_gate2_shared2("usb_root_clk", "hsio_axi", ccm_base + 0x44d0, 0, &share_count_usb);
+	hws[IMX8MP_CLK_USB_SUSP] = imx_clk_hw_gate2_shared2("usb_suspend_clk", "osc_32k", ccm_base + 0x44d0, 0, &share_count_usb);
 	hws[IMX8MP_CLK_USB_PHY_ROOT] = imx_clk_hw_gate4("usb_phy_root_clk", "usb_phy_ref", ccm_base + 0x44f0, 0);
 	hws[IMX8MP_CLK_USDHC1_ROOT] = imx_clk_hw_gate4("usdhc1_root_clk", "usdhc1", ccm_base + 0x4510, 0);
 	hws[IMX8MP_CLK_USDHC2_ROOT] = imx_clk_hw_gate4("usdhc2_root_clk", "usdhc2", ccm_base + 0x4520, 0);
Signature · 1 line
2.34.1
Reviewed-by on v4 1/3
#12 lore raw
In reply to Li Jun
Quoted 7 lines · Li Jun

usb suspend clock has a gate shared with usb_root_clk.

Fixes 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
Cc [email protected] # v5.19+
Quoted 22 lines
---
 include/dt-bindings/clock/imx8mp-clock.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/dt-bindings/clock/imx8mp-clock.h +2 -1
index 9d5cc2ddde89..1417b7b1b7df 100644
@@ -324,8 +324,9 @@
 #define IMX8MP_CLK_CLKOUT2_SEL			317
 #define IMX8MP_CLK_CLKOUT2_DIV			318
 #define IMX8MP_CLK_CLKOUT2			319
+#define IMX8MP_CLK_USB_SUSP			320
 
-#define IMX8MP_CLK_END				320
+#define IMX8MP_CLK_END				321
 
 #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG		0
 #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1		1
Signature · 1 line
2.34.1
#5 lore raw

Re: [PATCH v4 2/3] clk: imx: imx8mp: add shared clk gate for usb suspend clk

In reply to Abel Vesa
Quoted 33 lines · Abel Vesa
Quoted 32 lines · Stephen Boyd

Quoting Jun Li (2022-10-19 02:26:00)

Quoted 31 lines

Hi Stephen,

Quoted 28 lines

-----Original Message-----
From: Jun Li <[email protected]>
Sent: Friday, September 30, 2022 10:54 PM
To: [email protected]; [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>; [email protected]; [email protected]; Peng Fan <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: [PATCH v4 2/3] clk: imx: imx8mp: add shared clk gate for usb suspend clk

32K usb suspend clock gate is shared with usb_root_clk, this shared clock gate was initially defined only for usb suspend clock, usb suspend clk is kept on while system is active or system sleep with usb wakeup enabled, so usb root clock is fine with this situation; with the commit cf7f3f4fa9e5 ("clk: imx8mp: fix usb_root_clk parent"), this clock gate is changed to be for usb root clock, but usb root clock will be off while usb is suspended, so usb suspend clock will be gated too, this cause some usb functionalities will not work, so define this clock to be a shared clock gate to conform with the real HW status.

Fixes 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver")
Cc [email protected] # v5.19+
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Is this version okay for you?

I thought that Abel was going to pick these up.

Oh, sorry, I thought the fixes will be picked up by you.

I'll apply it to my tree then.

Ugrh, ignore this.

Already applied.

My inbox is messed up a bit right now.

Sorry about that.