patch "usb: gadget: uvc: fix sg handling during video encode" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
usb: gadget: uvc: fix sg handling during video encode
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From b57b08e6f431348363adffa5b6643fe3ec9dc7fe Mon Sep 17 00:00:00 2001
From: Jeff Vanhoof <[email protected]>
Date: Tue, 18 Oct 2022 16:50:40 -0500
Subject: usb: gadget: uvc: fix sg handling during video encode
In uvc_video_encode_isoc_sg, the uvc_request's sg list is incorrectly being populated leading to corrupt video being received by the remote end. When building the sg list the usage of buf->sg's 'dma_length' field is not correct and instead its 'length' field should be used.
--- drivers/usb/gadget/function/uvc_video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/gadget/function/uvc_video.c +2 -2
@@ -157,10 +157,10 @@ uvc_video_encode_isoc_sg(struct usb_request *req, struct uvc_video *video, sg =sg_next (sg);for_each_sg (sg, iter, ureq->sgt.nents -1 , i) { -if (!len || !buf->sg || !sg_dma_len (buf->sg)) +if (!len || !buf->sg || !buf->sg->length)break ; - sg_left =sg_dma_len (buf->sg) - buf->offset; + sg_left = buf->sg->length - buf->offset; part = min_t(unsigned int, len, sg_left);sg_set_page (iter,sg_page (buf->sg), part, buf->offset);
Signature · 1 line
2.38.1