Skip to contentSkip to conversation

RDMA/rxe: Remove the duplicate assignment of mr->map_shift

PATCH Applied Xiao Yang 3 participants 3 messages Oct 27, 2022 – Oct 28, 2022

Subsystems (2)
lore
Share & tools
lore

Xiao Yang

author
#0 lore raw

PATCH 1/1 RDMA/rxe: Remove the duplicate assignment of mr->map_shift

mr->map_shift is set to ilog2(RXE_BUF_PER_MAP) in both rxe_mr_init() and rxe_mr_alloc() so remove the duplicate one in rxe_mr_init().

---
 drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/sw/rxe/rxe_mr.c +0 -1
index d4f10c2d1aa7..279fac4c21d0 100644
@@ -62,7 +62,6 @@ static void rxe_mr_init(int access, struct rxe_mr *mr)
 	mr->rkey = mr->ibmr.rkey = rkey;
 
 	mr->state = RXE_MR_STATE_INVALID;
-	mr->map_shift = ilog2(RXE_BUF_PER_MAP);
 }
 
 static int rxe_mr_alloc(struct rxe_mr *mr, int num_buf)
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Xiao Yang

mr->map_shift is set to ilog2(RXE_BUF_PER_MAP) in both rxe_mr_init() and rxe_mr_alloc() so remove the duplicate one in rxe_mr_init().

---
  drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
  1 file changed, 1 deletion(-)
drivers/infiniband/sw/rxe/rxe_mr.c +0 -0
index d4f10c2d1aa7..279fac4c21d0 100644

drivers/infiniband/sw/rxe/rxe_mr.c static void rxe_mr_init(int access, struct rxe_mr *mr) · line 65

Quoted 4 lines
drivers/infiniband/sw/rxe/rxe_mr.c +0 -1
@@ -62,7 +62,6 @@ static void rxe_mr_init(int access, struct rxe_mr *mr)
  	mr->rkey = mr->ibmr.rkey = rkey;
 
  	mr->state = RXE_MR_STATE_INVALID;
-	mr->map_shift = ilog2(RXE_BUF_PER_MAP);

Good catch.

Quoted 3 lines
drivers/infiniband/sw/rxe/rxe_mr.c +0 -0
  }
 
  static int rxe_mr_alloc(struct rxe_mr *mr, int num_buf)