Skip to contentSkip to conversation

FAILED: patch "[PATCH] drm/msm/hdmi: fix IRQ lifetime" failed to apply to 5.4-stable tree

PATCH [email protected] 1 participant 1 message Oct 31, 2022

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

Possible dependencies:

152d394842bb ("drm/msm/hdmi: fix IRQ lifetime") 088604d37e23 ("drm/msm/hdmi: Remove spurious IRQF_ONESHOT flag")

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 152d394842bb564148e68b92486a87db0bf54859 Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Tue, 13 Sep 2022 10:53:18 +0200
Subject: [PATCH] drm/msm/hdmi: fix IRQ lifetime

Device-managed resources allocated post component bind must be tied to the lifetime of the aggregate DRM device or they will not necessarily be released when binding of the aggregate device is deferred.

This is specifically true for the HDMI IRQ, which will otherwise remain requested so that the next bind attempt fails when requesting the IRQ a second time.

Fix this by tying the device-managed lifetime of the HDMI IRQ to the DRM device so that it is released when bind fails.

Fixes 067fef372c73 ("drm/msm/hdmi: refactor bind/init")

Patchwork: https://patchwork.freedesktop.org/patch/502666/

drivers/gpu/drm/msm/hdmi/hdmi.c +1 -1
index a0ed6aa8e4e1..f28fb21e3891 100644
@@ -344,7 +344,7 @@ int msm_hdmi_modeset_init(struct hdmi *hdmi,
 		goto fail;
 	}
 
-	ret = devm_request_irq(&pdev->dev, hdmi->irq,
+	ret = devm_request_irq(dev->dev, hdmi->irq,
 			msm_hdmi_irq, IRQF_TRIGGER_HIGH,
 			"hdmi_isr", hdmi);
 	if (ret < 0) {