Skip to contentSkip to conversation

x86/Hyper-V: Expand definition of struct hv_vp_assist_page

PATCH Superseded Saurabh Sengar 3 participants 4 messages Nov 4, 2022

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/Hyper-V: Expand definition of struct hv_vp_assist_page

The struct hv_vp_assist_page has 24 bytes which is defined as u64[3], expand that to expose vtl_entry_reason, vtl_ret_x64rax and vtl_ret_x64rcx field. vtl_entry_reason is updated by hypervisor for the entry reason as to why the VTL was entered on the virtual processor.
Guest updates the vtl_ret_* fields to provide the register values to restore on VTL return. The specific register values that are restored which will be updated on vtl_ret_x64rax and vtl_ret_x64rcx. Also added the missing fields for synthetic_time_unhalted_timer_expired, virtualization_fault_information and intercept_message.

---
 arch/x86/include/asm/hyperv-tlfs.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
arch/x86/include/asm/hyperv-tlfs.h +10 -1
index f769b9db4630..b3d0f42853d2 100644
@@ -377,11 +377,20 @@ struct hv_nested_enlightenments_control {
 struct hv_vp_assist_page {
 	__u32 apic_assist;
 	__u32 reserved1;
-	__u64 vtl_control[3];
+	__u8  vtl_entry_reason;
+	__u8  vtl_reserved[7];
+	__u64 vtl_ret_x64rax;
+	__u64 vtl_ret_x64rcx;
 	struct hv_nested_enlightenments_control nested_control;
 	__u8 enlighten_vmentry;
 	__u8 reserved2[7];
 	__u64 current_nested_vmcs;
+	__u8 synthetic_time_unhalted_timer_expired;
+	__u8 reserved3[7];
+	__u8 virtualization_fault_information[40];
+	__u8 reserved4[8];
+	__u8 intercept_message[256];
+	__u8 vtl_ret_actions[256];
 } __packed;
 
 struct hv_enlightened_vmcs {
Signature · 1 line
2.34.1
#1 lore raw
Quoted 20 lines · Saurabh Sengar

The struct hv_vp_assist_page has 24 bytes which is defined as u64[3], expand that to expose vtl_entry_reason, vtl_ret_x64rax and vtl_ret_x64rcx field. vtl_entry_reason is updated by hypervisor for the entry reason as to why the VTL was entered on the virtual processor.
Guest updates the vtl_ret_* fields to provide the register values to restore on VTL return. The specific register values that are restored which will be updated on vtl_ret_x64rax and vtl_ret_x64rcx. Also added the missing fields for synthetic_time_unhalted_timer_expired, virtualization_fault_information and intercept_message.

---
 arch/x86/include/asm/hyperv-tlfs.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
arch/x86/include/asm/hyperv-tlfs.h +0 -0
index f769b9db4630..b3d0f42853d2 100644

arch/x86/include/asm/hyperv-tlfs.h struct hv_nested_enlightenments_control { · line 380

Quoted 5 lines
arch/x86/include/asm/hyperv-tlfs.h +1 -1
@@ -377,11 +377,20 @@ struct hv_nested_enlightenments_control {
 struct hv_vp_assist_page {
 	__u32 apic_assist;
 	__u32 reserved1;
-	__u64 vtl_control[3];
+	__u8  vtl_entry_reason;

This is defined as an enum in the TLFS [1]. We should do the same. And since the TLFS defines it as an enum it is a 32 bit value and not a u8.

arch/x86/include/asm/hyperv-tlfs.h struct hv_nested_enlightenments_control { · line 383

Quoted 3 lines
arch/x86/include/asm/hyperv-tlfs.h +3 -0
+	__u8  vtl_reserved[7];
+	__u64 vtl_ret_x64rax;
+	__u64 vtl_ret_x64rcx;

The TLFS groups the above VTL related fields into a struct HV_VP_VTL_CONTROL. Any reason to not do the same?

[1] https://learn.microsoft.com/en-us/virtualization/hyper-v-on-windows/tlfs/datatypes/hv_vp_vtl_control

Thanks,
Anirudh.

Quoted 15 lines
arch/x86/include/asm/hyperv-tlfs.h +6 -0
 	struct hv_nested_enlightenments_control nested_control;
 	__u8 enlighten_vmentry;
 	__u8 reserved2[7];
 	__u64 current_nested_vmcs;
+	__u8 synthetic_time_unhalted_timer_expired;
+	__u8 reserved3[7];
+	__u8 virtualization_fault_information[40];
+	__u8 reserved4[8];
+	__u8 intercept_message[256];
+	__u8 vtl_ret_actions[256];
 } __packed;
 
 struct hv_enlightened_vmcs {
Signature · 1 line
2.34.1
#2 lore raw
Quoted 16 lines · Anirudh Rayabharam
Quoted 15 lines · Saurabh Sengar

The struct hv_vp_assist_page has 24 bytes which is defined as u64[3], expand that to expose vtl_entry_reason, vtl_ret_x64rax and vtl_ret_x64rcx field. vtl_entry_reason is updated by hypervisor for the entry reason as to why the VTL was entered on the virtual processor.
Guest updates the vtl_ret_* fields to provide the register values to restore on VTL return. The specific register values that are restored which will be updated on vtl_ret_x64rax and vtl_ret_x64rcx. Also added the missing fields for synthetic_time_unhalted_timer_expired, virtualization_fault_information and intercept_message.

---
 arch/x86/include/asm/hyperv-tlfs.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Quoted 14 lines

arch/x86/include/asm/hyperv-tlfs.h struct hv_nested_enlightenments_control { · line 380

Quoted 10 lines
arch/x86/include/asm/hyperv-tlfs.h +1 -1
index f769b9db4630..b3d0f42853d2 100644
@@ -377,11 +377,20 @@ struct hv_nested_enlightenments_control {
 struct hv_vp_assist_page {
 	__u32 apic_assist;
 	__u32 reserved1;
-	__u64 vtl_control[3];
+	__u8  vtl_entry_reason;

This is defined as an enum in the TLFS [1]. We should do the same. And since the TLFS defines it as an enum it is a 32 bit value and not a u8.

I think we can do that. Let me check this and update on v2.

Quoted 7 lines

arch/x86/include/asm/hyperv-tlfs.h struct hv_nested_enlightenments_control { · line 383

Quoted 4 lines
arch/x86/include/asm/hyperv-tlfs.h +3 -0
+	__u8  vtl_reserved[7];
+	__u64 vtl_ret_x64rax;
+	__u64 vtl_ret_x64rcx;

The TLFS groups the above VTL related fields into a struct HV_VP_VTL_CONTROL. Any reason to not do the same?

No particular reason, but this change is simple and sufficient. We can expand in future as the need arises.

Quoted 21 lines

[1] https://learn.microsoft.com/en-us/virtualization/hyper-v-on-windows/tlfs/datatypes/hv_vp_vtl_control

Thanks,
Anirudh.

Quoted 15 lines
arch/x86/include/asm/hyperv-tlfs.h +6 -0
 	struct hv_nested_enlightenments_control nested_control;
 	__u8 enlighten_vmentry;
 	__u8 reserved2[7];
 	__u64 current_nested_vmcs;
+	__u8 synthetic_time_unhalted_timer_expired;
+	__u8 reserved3[7];
+	__u8 virtualization_fault_information[40];
+	__u8 reserved4[8];
+	__u8 intercept_message[256];
+	__u8 vtl_ret_actions[256];
 } __packed;
 
 struct hv_enlightened_vmcs {
Signature · 1 line
2.34.1
#3 lore raw
In reply to Anirudh Rayabharam

From: Anirudh Rayabharam <[email protected]> Sent: Friday, November 4, 2022 12:17 AM

Quoted 19 lines · Saurabh Sengar

arch/x86/include/asm/hyperv-

Quoted 16 lines

The struct hv_vp_assist_page has 24 bytes which is defined as u64[3], expand that to expose vtl_entry_reason, vtl_ret_x64rax and vtl_ret_x64rcx field. vtl_entry_reason is updated by hypervisor for the entry reason as to why the VTL was entered on the virtual processor.
Guest updates the vtl_ret_* fields to provide the register values to restore on VTL return. The specific register values that are restored which will be updated on vtl_ret_x64rax and vtl_ret_x64rcx. Also added the missing fields for synthetic_time_unhalted_timer_expired, virtualization_fault_information and intercept_message.

---
 arch/x86/include/asm/hyperv-tlfs.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
arch/x86/include/asm/hyperv- renamed from arch/x86/include/asm/hyperv-tlfs.h +0 -0

tlfs.h

Quoted 13 lines

arch/x86/include/asm/hyperv-tlfs.h struct hv_nested_enlightenments_control { · line 380

Quoted 9 lines

index f769b9db4630..b3d0f42853d2 100644

arch/x86/include/asm/hyperv-tlfs.h +1 -1
@@ -377,11 +377,20 @@ struct hv_nested_enlightenments_control {
 struct hv_vp_assist_page {
 	__u32 apic_assist;
 	__u32 reserved1;
-	__u64 vtl_control[3];
+	__u8  vtl_entry_reason;

This is defined as an enum in the TLFS [1]. We should do the same. And since the TLFS defines it as an enum it is a 32 bit value and not a u8.

In the *tlfs.h files we have avoided defining fields with type "enum" because of the potential for variability in number of bytes it occupies. The TLFS documentation assumes an enum is 4 bytes, so in these structure definitions we use a __u32 type to be explicit about the size.

We do have enum types defined in the *tlfs.h files, but these are just lists of related constant values, and that's OK.

Michael

Quoted 28 lines

arch/x86/include/asm/hyperv-tlfs.h struct hv_nested_enlightenments_control { · line 383

Quoted 4 lines
arch/x86/include/asm/hyperv-tlfs.h +3 -0
+	__u8  vtl_reserved[7];
+	__u64 vtl_ret_x64rax;
+	__u64 vtl_ret_x64rcx;

The TLFS groups the above VTL related fields into a struct HV_VP_VTL_CONTROL. Any reason to not do the same?

[1] https://learn.microsoft.com/en-us/virtualization/hyper-v-on-windows/tlfs/datatypes/hv_vp_vtl_control

Thanks,
Anirudh.

Quoted 15 lines
arch/x86/include/asm/hyperv-tlfs.h +6 -1
 	struct hv_nested_enlightenments_control nested_control;
 	__u8 enlighten_vmentry;
 	__u8 reserved2[7];
 	__u64 current_nested_vmcs;
+	__u8 synthetic_time_unhalted_timer_expired;
+	__u8 reserved3[7];
+	__u8 virtualization_fault_information[40];
+	__u8 reserved4[8];
+	__u8 intercept_message[256];
+	__u8 vtl_ret_actions[256];
 } __packed;
 
 struct hv_enlightened_vmcs {
--

2.34.1