WTF: patch "[PATCH] KVM: debugfs: Return retval of simple_attr_open() if it fails" was seriously submitted to be applied to the 6.0-stable tree?
Subsystems (2)
[email protected]
maintainerThe patch below was submitted to be applied to the 6.0-stable tree.
I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable-kernel-rules.rst.
I could be totally wrong, and if so, please respond to <[email protected]> and let me know why this patch should be applied. Otherwise, it is now dropped from my patch queues, never to be seen again.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 180418e2eb33be5c8d0b703c843e0ebc045aef80 Mon Sep 17 00:00:00 2001
From: Hou Wenlong <[email protected]>
Date: Mon, 17 Oct 2022 11:06:10 +0800
Subject: [PATCH] KVM: debugfs: Return retval of simple_attr_open() if it fails
Although simple_attr_open() fails only with -ENOMEM with current code base, it would be nicer to return retval of simple_attr_open() directly in kvm_debugfs_open().
No functional change intended.
Message-Id: <69d64d93accd1f33691b8a383ae555baee80f943.1665975828.git.houwenlong.hwl@antgroup.com>
virt/kvm/kvm_main.c +6 -7
@@ -5409,6 +5409,7 @@ static int kvm_debugfs_open(struct inode *inode, struct file *file, int (*get)(void *, u64 *), int (*set)(void *, u64), const char *fmt) { + int ret;struct kvm_stat_data *stat_data = (struct kvm_stat_data *) inode->i_private;
@@ -5420,15 +5421,13 @@ static int kvm_debugfs_open(struct inode *inode, struct file *file,if (!kvm_get_kvm_safe (stat_data->kvm))return -ENOENT ; -if (simple_attr_open (inode, file, get, -kvm_stats_debugfs_mode (stat_data->desc) &0222 - ? set :NULL , - fmt)) { + ret =simple_attr_open (inode, file, get, +kvm_stats_debugfs_mode (stat_data->desc) &0222 + ? set :NULL , fmt); +if (ret)kvm_put_kvm (stat_data->kvm); -return -ENOMEM ; - } -return 0 ; +return ret; }static int kvm_debugfs_release (struct inode *inode,struct file *file)