Skip to contentSkip to conversation

Patch "kbuild: fix -Wimplicit-function-declaration in license_is_gpl_compatible" has been added to the 6.0-stable tree

DISCUSSION Sam James 2 participants 2 messages Dec 1, 2022 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Sam James

author
#1 lore raw
Quoted 19 lines · On 29 Nov 2022, at 17:01, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

kbuild: fix -Wimplicit-function-declaration in license_is_gpl_compatible

to the 6.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
kbuild-fix-wimplicit-function-declaration-in-license_is_gpl_compatible.patch
and it can be found in the queue-6.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 8 lines

From 50c697215a8cc22f0e58c88f06f2716c05a26e85 Mon Sep 17 00:00:00 2001
From: Sam James <[email protected]>
Date: Wed, 16 Nov 2022 18:26:34 +0000
Subject: kbuild: fix -Wimplicit-function-declaration in license_is_gpl_compatible

From: Sam James <[email protected]>

commit 50c697215a8cc22f0e58c88f06f2716c05a26e85 upstream.

Hi Greg,

Please yank this commit from all the stable queues -- it needs Some further baking, and a revert is queued in Andrew's tree.

Thanks,
sam

Quoted 23 lines

Add missing <linux/string.h> include for strcmp.

Clang 16 makes -Wimplicit-function-declaration an error by default. Unfortunately, out of tree modules may use this in configure scripts, which means failure might cause silent miscompilation or misconfiguration.

For more information, see LWN.net [0] or LLVM's Discourse [1], gentoo-dev@ [2], or the (new) c-std-porting mailing list [3].

[0] https://lwn.net/Articles/913505/
[1] https://discourse.llvm.org/t/configure-script-breakage-with-the-new-werror-implicit-function-declaration/65213
[2] https://archives.gentoo.org/gentoo-dev/message/dd9f2d3082b8b6f8dfbccb0639e6e240
[3] hosted at lists.linux.dev.

---
include/linux/license.h | 2 ++

maintainer
#2 lore raw
Quoted 24 lines · Sam James
Quoted 24 lines · On 29 Nov 2022, at 17:01, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

kbuild: fix -Wimplicit-function-declaration in license_is_gpl_compatible

to the 6.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
kbuild-fix-wimplicit-function-declaration-in-license_is_gpl_compatible.patch
and it can be found in the queue-6.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From 50c697215a8cc22f0e58c88f06f2716c05a26e85 Mon Sep 17 00:00:00 2001
From: Sam James <[email protected]>
Date: Wed, 16 Nov 2022 18:26:34 +0000
Subject: kbuild: fix -Wimplicit-function-declaration in license_is_gpl_compatible

Quoted 8 lines
Quoted 3 lines

From: Sam James <[email protected]>

commit 50c697215a8cc22f0e58c88f06f2716c05a26e85 upstream.

Hi Greg,

Please yank this commit from all the stable queues -- it needs Some further baking, and a revert is queued in Andrew's tree.

Ok, now deleted from all queues, thanks.

greg k-h