Skip to contentSkip to conversation

FAILED: patch "[PATCH] f2fs: allow to read node block after shutdown" failed to apply to 4.19-stable tree

PATCH [email protected] 1 participant 1 message Jan 2, 2023

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

Possible dependencies:

e6ecb1424291 ("f2fs: allow to read node block after shutdown") b7ec2061737f ("f2fs: do not submit NEW_ADDR to read node block")

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From e6ecb142429183cef4835f31d4134050ae660032 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim <[email protected]>
Date: Tue, 8 Nov 2022 17:59:34 -0800
Subject: [PATCH] f2fs: allow to read node block after shutdown

If block address is still alive, we should give a valid node block even after shutdown. Otherwise, we can see zero data when reading out a file.

Fixes 83a3bfdb5a8a ("f2fs: indicate shutdown f2fs to allow unmount successfully")
fs/f2fs/node.c +1 -2
index 983572f23896..b9ee5a1176a0 100644
@@ -1360,8 +1360,7 @@ static int read_node_page(struct page *page, blk_opf_t op_flags)
 		return err;
 
 	/* NEW_ADDR can be seen, after cp_error drops some dirty node pages */
-	if (unlikely(ni.blk_addr == NULL_ADDR || ni.blk_addr == NEW_ADDR) ||
-			is_sbi_flag_set(sbi, SBI_IS_SHUTDOWN)) {
+	if (unlikely(ni.blk_addr == NULL_ADDR || ni.blk_addr == NEW_ADDR)) {
 		ClearPageUptodate(page);
 		return -ENOENT;
 	}