libpng: Enable NEON for aarch64 to enensure consistency with arm32.
PATCH 1/1 libpng: Enable NEON for aarch64 to enensure consistency with arm32.
- When NEON is not enabled for arm32, it shouldn't be disable enable-arm-neon for other arches.
- NEON is enabled for aarch64 by default, so, to ensure consistency with arm32, reference to libpng-1.6.38/configure, added enable_hardware_optimizations option for aarch64.
--- meta/recipes-multimedia/libpng/libpng_1.6.39.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-multimedia/libpng/libpng_1.6.39.bb +2 -1
@@ -22,7 +22,8 @@ BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" inherit autotools binconfig-disabled pkgconfig # Work around missing symbols -EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", " ", d)}" +EXTRA_OECONF:append:aarch64 = " --enable-hardware-optimizations=on " PACKAGES =+ "${PN}-tools"
Signature · 1 line
1.8.3.1
Quoted 13 lines · leimaohui
- When NEON is not enabled for arm32, it shouldn't be disable enable-arm-neon for other arches.
- NEON is enabled for aarch64 by default, so, to ensure consistency with arm32, reference to libpng-1.6.38/configure, addedenable_hardware_optimizationsoption for aarch64.Signed-off-by Lei Maohui <[email protected]>--- meta/recipes-multimedia/libpng/libpng_1.6.39.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta/recipes-multimedia/libpng/libpng_1.6.39.bb +0
-0
meta/recipes-multimedia/libpng/libpng_1.6.39.bb BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" · line 28
Quoted 8 lines
meta/recipes-multimedia/libpng/libpng_1.6.39.bb +2
-1@@ -22,7 +22,8 @@ BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" inherit autotools binconfig-disabled pkgconfig # Work around missing symbols -EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" +EXTRA_OECONF:append:class-target = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", " ", d)}" +EXTRA_OECONF:append:aarch64 = " --enable-hardware-optimizations=on " PACKAGES =+ "${PN}-tools"
I'm a bit worried that we don't want this option floating. How about something like:
ARMNEON = "${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" ARMNEON:aarch64 = "--enable-hardware-optimizations=on"EXTRA_OECONF += "${ARMNEON}"
?
Cheers,
Richard
Hi, Richard
Quoted 7 lines
I'm a bit worried that we don't want this option floating. How about something like:
ARMNEON = "${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" ARMNEON:aarch64 = "--enable-hardware-optimizations=on"
EXTRA_OECONF+= "${ARMNEON}"
Thanks, it does work and I will send V2 patch.
Best regards
Lei
Quoted 54 lines
-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Richard Purdie
Sent: Monday, January 9, 2023 6:44 PM
To: Lei, Maohui <[email protected]>; [email protected]
Subject: Re: [OE-core] [PATCH] libpng: Enable NEON for aarch64 to enensure consistency with arm32.Quoted 1 line · leimaohui
- When NEON is not enabled for arm32, it shouldn't be disable enable-arm-neon
for other arches.
Quoted 1 line
- NEON is enabled for aarch64 by default, so, to ensure consistency with arm32,
reference to libpng-1.6.38/configure, added
enable_hardware_optimizationsoption for aarch64.meta/recipes-multimedia/libpng/libpng_1.6.39.bb BINCONFIG = "${bindir}/libpng-config
Quoted 12 lines
Signed-off-by Lei Maohui <[email protected]>--- meta/recipes-multimedia/libpng/libpng_1.6.39.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta/recipes-multimedia/libpng/libpng_1.6.39.bb +0
-0@@ -22,7 +22,8 @@ BINCONFIG = "${bindir}/libpng-config${bindir}/libpng16-config"
meta/recipes-multimedia/libpng/libpng_1.6.39.bb BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config"
Quoted 4 lines
meta/recipes-multimedia/libpng/libpng_1.6.39.bb +0
-1inherit autotools binconfig-disabled pkgconfig # Work around missing symbols -EXTRA_OECONF:append:class-target = "${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}"
meta/recipes-multimedia/libpng/libpng_1.6.39.bb BINCONFIG = "${bindir}/libpng-config · line 25
Quoted 1 line
meta/recipes-multimedia/libpng/libpng_1.6.39.bb +1
-0+EXTRA_OECONF:append:class-target = "${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", " ", d)}"
meta/recipes-multimedia/libpng/libpng_1.6.39.bb BINCONFIG = "${bindir}/libpng-config ${bindir}/libpng16-config" · line 28
Quoted 3 lines
meta/recipes-multimedia/libpng/libpng_1.6.39.bb +1
-0+EXTRA_OECONF:append:aarch64 = " --enable-hardware-optimizations=on " PACKAGES =+ "${PN}-tools"I'm a bit worried that we don't want this option floating. How about something like:
ARMNEON = "${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off", d)}" ARMNEON:aarch64 = "--enable-hardware-optimizations=on"
EXTRA_OECONF+= "${ARMNEON}"?
Cheers,
Richard