FAILED: patch "[PATCH] iommu/mediatek-v1: Fix an error handling path in" failed to apply to 5.10-stable tree
Subsystems (4)
[email protected]
maintainerThe patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
Possible dependencies:
142e821f68cf ("iommu/mediatek-v1: Fix an error handling path in mtk_iommu_v1_probe()") ac304c070c54 ("iommu/mediatek-v1: Add error handle for mtk_iommu_probe")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 142e821f68cf5da79ce722cb9c1323afae30e185 Mon Sep 17 00:00:00 2001
From: Christophe JAILLET <[email protected]>
Date: Mon, 19 Dec 2022 19:06:22 +0100
Subject: [PATCH] iommu/mediatek-v1: Fix an error handling path in
mtk_iommu_v1_probe()
A clk, prepared and enabled in mtk_iommu_v1_hw_init(), is not released in the error handling path of mtk_iommu_v1_probe().
Add the corresponding clk_disable_unprepare(), as already done in the remove function.
drivers/iommu/mtk_iommu_v1.c +3 -1
@@ -683,7 +683,7 @@ static int mtk_iommu_v1_probe(struct platform_device *pdev) ret =iommu_device_sysfs_add (&data->iommu, &pdev->dev,NULL ,dev_name (&pdev->dev));if (ret) -return ret; + goto out_clk_unprepare; ret =iommu_device_register (&data->iommu, &mtk_iommu_v1_ops, dev);if (ret)
@@ -698,6 +698,8 @@ out_dev_unreg:iommu_device_unregister (&data->iommu); out_sysfs_remove:iommu_device_sysfs_remove (&data->iommu); +out_clk_unprepare: +clk_disable_unprepare (data->bclk);return ret; }