FAILED: patch "[PATCH] drm/i915: Allow switching away via vga-switcheroo if" failed to apply to 5.15-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 5.15-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
Possible dependencies:
a273e95721e9 ("drm/i915: Allow switching away via vga-switcheroo if uninitialized")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From a273e95721e96885971a05f1b34cb6d093904d9d Mon Sep 17 00:00:00 2001
From: Thomas Zimmermann <[email protected]>
Date: Mon, 16 Jan 2023 12:54:23 +0100
Subject: [PATCH] drm/i915: Allow switching away via vga-switcheroo if
uninitialized
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Always allow switching away via vga-switcheroo if the display is uninitalized. Instead prevent switching to i915 if the device has not been initialized.
This issue was introduced by commit 5df7bd130818 ("drm/i915: skip display initialization when there is no display") protected, which protects code paths from being executed on uninitialized devices. In the case of vga-switcheroo, we want to allow a switch away from i915's device. So run vga_switcheroo_process_delayed_switch() and test in the switcheroo callbacks if the i915 device is available.
drivers/gpu/drm/i915/i915_driver.c +1 -2
@@ -1073,8 +1073,7 @@ static void i915_driver_lastclose(struct drm_device *dev)intel_fbdev_restore_mode (dev); -if (HAS_DISPLAY (i915)) -vga_switcheroo_process_delayed_switch (); +vga_switcheroo_process_delayed_switch (); }static void i915_driver_postclose (struct drm_device *dev,struct drm_file *file)
drivers/gpu/drm/i915/i915_switcheroo.c +5 -1
@@ -19,6 +19,10 @@ static void i915_switcheroo_set_state(struct pci_dev *pdev,dev_err (&pdev->dev,"DRM not initialized, aborting switch.\n" );return ; } +if (!HAS_DISPLAY (i915)) { +dev_err (&pdev->dev,"Device state not initialized, aborting switch.\n" ); +return ; + }if (state ==VGA_SWITCHEROO_ON ) {drm_info (&i915->drm,"switched on\n" );
@@ -44,7 +48,7 @@ static bool i915_switcheroo_can_switch(struct pci_dev *pdev)* locking inversion with the driver load path. And the access here is * completely racy anyway. So don't bother with locking for now. */ -return i915 &&atomic_read (&i915->drm.open_count) ==0 ; +return i915 &&HAS_DISPLAY (i915) &&atomic_read (&i915->drm.open_count) ==0 ; }static const struct vga_switcheroo_client_ops i915_switcheroo_ops = {