Skip to contentSkip to conversation

FAILED: patch "[PATCH] cifs: Fix oops due to uncleared server->smbd_conn in" failed to apply to 4.19-stable tree

PATCH [email protected] 1 participant 1 message Jan 28, 2023 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

Possible dependencies:

b7ab9161cf5d ("cifs: Fix oops due to uncleared server->smbd_conn in reconnect")

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From b7ab9161cf5ddc42a288edf9d1a61f3bdffe17c7 Mon Sep 17 00:00:00 2001
From: David Howells <[email protected]>
Date: Wed, 25 Jan 2023 14:02:13 +0000
Subject: [PATCH] cifs: Fix oops due to uncleared server->smbd_conn in
reconnect

In smbd_destroy(), clear the server->smbd_conn pointer after freeing the smbd_connection struct that it points to so that reconnection doesn't get confused.

Fixes 8ef130f9ec27 ("CIFS: SMBD: Implement function to destroy a SMB Direct connection")
Cc Long Li <[email protected]>
Cc Pavel Shilovsky <[email protected]>
Cc Ronnie Sahlberg <[email protected]>
fs/cifs/smbdirect.c +1 -0
index 90789aaa6567..8c816b25ce7c 100644
@@ -1405,6 +1405,7 @@ void smbd_destroy(struct TCP_Server_Info *server)
 	destroy_workqueue(info->workqueue);
 	log_rdma_event(INFO,  "rdma session destroyed\n");
 	kfree(info);
+	server->smbd_conn = NULL;
 }
 
 /*