FAILED: patch "[PATCH] net/sched: act_ctinfo: use percpu stats" failed to apply to 5.10-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
Possible dependencies:
21c167aa0ba9 ("net/sched: act_ctinfo: use percpu stats") 40bd094d65fc ("flow_offload: fill flags to action structure")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 21c167aa0ba943a7cac2f6969814f83bb701666b Mon Sep 17 00:00:00 2001
From: Pedro Tammela <[email protected]>
Date: Fri, 10 Feb 2023 17:08:25 -0300
Subject: [PATCH] net/sched: act_ctinfo: use percpu stats
The tc action act_ctinfo was using shared stats, fix it to use percpu stats since bstats_update() must be called with locks or with a percpu pointer argument.
tdc results:
1..12
ok 1 c826 - Add ctinfo action with default setting
ok 2 0286 - Add ctinfo action with dscp
ok 3 4938 - Add ctinfo action with valid cpmark and zone ok 4 7593 - Add ctinfo action with drop control
ok 5 2961 - Replace ctinfo action zone and action control ok 6 e567 - Delete ctinfo action with valid index
ok 7 6a91 - Delete ctinfo action with invalid index
ok 8 5232 - List ctinfo actions
ok 9 7702 - Flush ctinfo actions
ok 10 3201 - Add ctinfo action with duplicate index
ok 11 8295 - Add ctinfo action with invalid index
ok 12 3964 - Replace ctinfo action with invalid goto_chain control
net/sched/act_ctinfo.c +3 -3
@@ -93,7 +93,7 @@ TC_INDIRECT_SCOPE int tcf_ctinfo_act(struct sk_buff *skb, cp =rcu_dereference_bh (ca->params);tcf_lastuse_update (&ca->tcf_tm); -bstats_update (&ca->tcf_bstats, skb); +tcf_action_update_bstats (&ca->common, skb); action =READ_ONCE (ca->tcf_action); wlen =skb_network_offset (skb);
@@ -212,8 +212,8 @@ static int tcf_ctinfo_init(struct net *net, struct nlattr *nla, index = actparm->index; err =tcf_idr_check_alloc (tn, &index, a, bind);if (!err) { - ret =tcf_idr_create (tn, index, est, a, - &act_ctinfo_ops, bind, false, flags); + ret =tcf_idr_create_from_flags (tn, index, est, a, + &act_ctinfo_ops, bind, flags);if (ret) {tcf_idr_cleanup (tn, index);return ret;