Skip to contentSkip to conversation

ARM: OMAP: fix apollon USB device support

PATCH New Kyungmin Park 1 participant 1 message Oct 30, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP: fix apollon USB device support

Hi David,

In the previous patch, there's some changes in UDC.
It makes the apollon USB can't work.
After some work, I found that you changed the double-buffering condition. It breaks the apollon behavior.

Please append apollon board condition when we use the pio mode, then don't use double-buffering. and also fix some compiler warning

ARM: OMAP: fix apollon USB device support

- Add apollon use the non-double-buffering in PIO mode
- fix compiler warning

--

drivers/usb/gadget/omap_udc.c +5 -3
index ceba0a4..449b76b 100644
@@ -2579,6 +2579,7 @@ omap_ep_setup(char *name, u8 addr, u8 ty
 		 * (for more reliable behavior)
 		 */
 		if ((!use_dma && (addr & USB_DIR_IN))
+				|| machine_is_omap_apollon()
 				|| cpu_is_omap15xx())
 			dbuf = 0;
 
@@ -2963,9 +2964,10 @@ known:
 	}
 
 	create_proc_file();
-	device_add(&udc->gadget.dev);
-	return 0;
-
+	status = device_add(&udc->gadget.dev);
+	if (!status)
+		return status;
+	/* If fail, fall through */
 #ifdef	USE_ISO
 cleanup3:
 	free_irq(pdev->resource[2].start, udc);