Skip to contentSkip to conversation

usb: dwc3: add 2 registers dump for debugfs

PATCH Superseded Li Jun 2 participants 3 messages Mar 15, 2023 – Mar 16, 2023

Subsystems (2)
USB DesignWare USB3 DRD IP driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Li Jun

author
#0 lore raw

PATCH 1/1 usb: dwc3: add 2 registers dump for debugfs

Add GUCTL3 and GFLADJ register dump for debugfs as they are in use now.

Signed-off-by Li Jun <[email protected]>
---
 drivers/usb/dwc3/debugfs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/dwc3/debugfs.c +2 -0
index 850df0e6bcab..54d4678e6232 100644
@@ -229,6 +229,8 @@ static const struct debugfs_reg32 dwc3_regs[] = {
 	dump_register(GEVNTCOUNT(0)),
 
 	dump_register(GHWPARAMS8),
+	dump_register(GUCTL3),
+	dump_register(GFLADJ),
 	dump_register(DCFG),
 	dump_register(DCTL),
 	dump_register(DEVTEN),
Signature · 1 line
2.34.1
maintainer
#1 lore raw

Hi,

Quoted 24 lines · Li Jun

Add GUCTL3 and GFLADJ register dump for debugfs as they are in use now.

Signed-off-by Li Jun <[email protected]>
---
 drivers/usb/dwc3/debugfs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/dwc3/debugfs.c +2 -0
index 850df0e6bcab..54d4678e6232 100644
@@ -229,6 +229,8 @@ static const struct debugfs_reg32 dwc3_regs[] = {
 	dump_register(GEVNTCOUNT(0)),
 
 	dump_register(GHWPARAMS8),
+	dump_register(GUCTL3),
+	dump_register(GFLADJ),
 	dump_register(DCFG),
 	dump_register(DCTL),
 	dump_register(DEVTEN),
Signature · 1 line
2.34.1

Do you mind to also add VER_NUMBER and VER_TYPE? There are other registers too, but for now those 2 are important.

Thanks,
Thinh

author
#2 lore raw
Quoted 28 lines

-----Original Message-----
From: Thinh Nguyen <[email protected]>
Sent: Thursday, March 16, 2023 3:53 AM
To: Jun Li <[email protected]>
Cc: Thinh Nguyen <[email protected]>; [email protected]; [email protected]
Subject: Re: [PATCH] usb: dwc3: add 2 registers dump for debugfs

Hi,

Quoted 15 lines · Li Jun

Add GUCTL3 and GFLADJ register dump for debugfs as they are in use now.

Signed-off-by Li Jun <[email protected]>
---
 drivers/usb/dwc3/debugfs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/dwc3/debugfs.c +0 -0
index 850df0e6bcab..54d4678e6232 100644
@@ -229,6 +229,8 @@ static const struct debugfs_reg32 dwc3_regs[] = {
 	dump_register(GEVNTCOUNT(0)),
Quoted 12 lines
Quoted 9 lines
drivers/usb/dwc3/debugfs.c +2 -1
 	dump_register(GHWPARAMS8),
+	dump_register(GUCTL3),
+	dump_register(GFLADJ),
 	dump_register(DCFG),
 	dump_register(DCTL),
 	dump_register(DEVTEN),
--

2.34.1

Do you mind to also add VER_NUMBER and VER_TYPE? There are other registers too, but for now those 2 are important.

OK, I will add the 2 ver registers and send v2.

Li Jun

Quoted 3 lines

Thanks,
Thinh