patch "iio: adc: qcom-spmi-adc5: Fix the channel name" added to char-misc-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
iio: adc: qcom-spmi-adc5: Fix the channel name
to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 701c875aded880013aacac608832995c4b052257 Mon Sep 17 00:00:00 2001
From: Andy Shevchenko <[email protected]>
Date: Wed, 18 Jan 2023 12:06:23 +0200
Subject: iio: adc: qcom-spmi-adc5: Fix the channel name
The node name can contain an address part which is unused by the driver. Moreover, this string is propagated into the userspace label, sysfs filenames *and breaking ABI*.
Cut the address part out before assigning the channel name.
--- drivers/iio/adc/qcom-spmi-adc5.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/iio/adc/qcom-spmi-adc5.c +9 -1
@@ -626,12 +626,20 @@ static int adc5_get_fw_channel_data(struct adc5_chip *adc,struct fwnode_handle *fwnode, const struct adc5_data *data) { - const char *name = fwnode_get_name(fwnode), *channel_name; + const char *channel_name; +char *name;u32 chan, value, varr[2 ];u32 sid =0 ;int ret;struct device *dev = adc->dev; + name =devm_kasprintf (dev,GFP_KERNEL ,"%pfwP" , fwnode); +if (!name) +return -ENOMEM ; + +/* Cut the address part */ + name[strchrnul (name,'@' ) - name] ='\0' ; + ret =fwnode_property_read_u32 (fwnode,"reg" , &chan);if (ret) {dev_err (dev,"invalid channel number %s\n" , name);
Signature · 1 line
2.40.0