Skip to contentSkip to conversation

net/netvsc: increase VSP response timeout to 60 seconds

PATCH Applied [email protected] 2 participants 2 messages Jul 26, 2023 – Sep 28, 2023 Network drivers

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 net/netvsc: increase VSP response timeout to 60 seconds

From: Long Li <[email protected]>

The current timeout is set to 5 seconds. In Azure, tests show that it may take up to 15 seconds for VSP to respond on busy nodes. The VSP schedules unbounded work to process VSC resquest, there is no upper limit on how long it takes to send response back to VSC.

In the NETVSC kernel mode driver, it waits forever for VSP response. While in DPDK we can't wait forever, setting the timeout to 60 seconds.

Cc [email protected]
Signed-off-by Long Li <[email protected]>
---
 drivers/net/netvsc/hn_rndis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/netvsc/hn_rndis.c +1 -1
index e6f1f28768..7e9abce8d0 100644
@@ -35,7 +35,7 @@
 #include "hn_rndis.h"
 #include "ndis.h"
 
-#define RNDIS_TIMEOUT_SEC 5
+#define RNDIS_TIMEOUT_SEC 60
 #define RNDIS_DELAY_MS    10
 
 #define HN_RNDIS_XFER_SIZE		0x4000
Signature · 1 line
2.17.1
Applied
#1 lore raw
Quoted 7 lines · On 7/26/2023 11:29 PM, [email protected] wrote:

From: Long Li <[email protected]>

The current timeout is set to 5 seconds. In Azure, tests show that it may take up to 15 seconds for VSP to respond on busy nodes. The VSP schedules unbounded work to process VSC resquest, there is no upper limit on how long it takes to send response back to VSC.

Quoted 6 lines

In the NETVSC kernel mode driver, it waits forever for VSP response. While in DPDK we can't wait forever, setting the timeout to 60 seconds.

Cc [email protected]
Signed-off-by Long Li <[email protected]>

Applied to dpdk-next-net/main, thanks.