Skip to contentSkip to conversation

afs: Fix missing wire-up of afs_retry_request()

PATCH Applied David Howells 2 participants 2 messages Sep 14, 2024 – Sep 17, 2024

Subsystems (3)
lore
Share & tools
lore

David Howells

author maintainer
#0 lore raw

PATCH 1/1 afs: Fix missing wire-up of afs_retry_request()

afs_retry_request() is supposed to be pointed to by the afs_req_ops netfs operations table, but the pointer got lost somewhere. The function is used during writeback to rotate through the authentication keys that were in force when the file was modified locally.

Fix this by adding the pointer to the function.

Fixes 1ecb146f7cd8 ("netfs, afs: Use writeback retry to deal with alternate keys")
cc Marc Dionne <[email protected]>
cc Jeff Layton <[email protected]>
---
 fs/afs/file.c |    1 +
 1 file changed, 1 insertion(+)
fs/afs/file.c +1 -0
index ec1be0091fdb..290f60460ec7 100644
@@ -404,6 +404,7 @@ const struct netfs_request_ops afs_req_ops = {
 	.begin_writeback	= afs_begin_writeback,
 	.prepare_write		= afs_prepare_write,
 	.issue_write		= afs_issue_write,
+	.retry_request		= afs_retry_request,
 };
 
 static void afs_add_open_mmap(struct afs_vnode *vnode)
maintainer Applied
#1 lore raw
Quoted 8 lines · David Howells

afs_retry_request() is supposed to be pointed to by the afs_req_ops netfs operations table, but the pointer got lost somewhere. The function is used during writeback to rotate through the authentication keys that were in force when the file was modified locally.

Fix this by adding the pointer to the function.

[...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] afs: Fix missing wire-up of afs_retry_request()

      https://git.kernel.org/vfs/vfs/c/3fe535cb1a3b