Skip to contentSkip to conversation

[2.6.11] drivers/net/arcnet/arcnet.c gcc4 fixes

PATCH Applied Mikael Pettersson 2 participants 2 messages Mar 15, 2005 – Mar 22, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 [2.6.11] drivers/net/arcnet/arcnet.c gcc4 fixes

Fix

drivers/net/arcnet/arcnet.c: In function 'release_arcbuf':
drivers/net/arcnet/arcnet.c:256: warning: operation on 'i' may be undefined drivers/net/arcnet/arcnet.c: In function 'get_arcbuf':
drivers/net/arcnet/arcnet.c:292: warning: operation on 'i' may be undefined

warnings from gcc4 in arcnet.c.

/Mikael

drivers/net/arcnet/arcnet.c renamed from drivers/net/arcnet/arcnet.c.~1~ +2 -2
@@ -253,7 +253,7 @@ static void release_arcbuf(struct net_de
 	BUGLVL(D_DURING) {
 		BUGMSG(D_DURING, "release_arcbuf: freed #%d; buffer queue is now: ",
 		       bufnum);
-		for (i = lp->next_buf; i != lp->first_free_buf; i = ++i % 5)
+		for (i = lp->next_buf; i != lp->first_free_buf; i = (i+1) % 5)
 			BUGMSG2(D_DURING, "#%d ", lp->buf_queue[i]);
 		BUGMSG2(D_DURING, "\n");
 	}
@@ -289,7 +289,7 @@ static int get_arcbuf(struct net_device 
 
 	BUGLVL(D_DURING) {
 		BUGMSG(D_DURING, "get_arcbuf: got #%d; buffer queue is now: ", buf);
-		for (i = lp->next_buf; i != lp->first_free_buf; i = ++i % 5)
+		for (i = lp->next_buf; i != lp->first_free_buf; i = (i+1) % 5)
 			BUGMSG2(D_DURING, "#%d ", lp->buf_queue[i]);
 		BUGMSG2(D_DURING, "\n");
 	}
Applied
#1 lore raw

applied. but please:

1) include a signed-off-by line in all patches.

2) [administrivia] include the kernel version in the subject line like so:

	[patch 2.6.11] one-line summary...

See http://linux.yyz.us/patch-format.html for more info.

Jeff