Skip to contentSkip to conversation

ASoC: Add rtq9128 audio amplifier

PATCH In review [email protected] 2 participants 4 messages Sep 20, 2023 – Sep 21, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v3 cover ASoC: Add rtq9128 audio amplifier

From: ChiYuan Huang <[email protected]>

This patch series adds Richtek rtq9128 automotive audio amplifier support. It can deliver up to 4x75W into 4Ohm speaker from a 25V supply in automotive applications.

Change log
v3
- Add Reviewed-by tag for dt binding patch
- Refine the source code by reviewer's comments
detail changes listed in the patch
- Add DVDD undervoltage threshold selection from HW guy's suggestion

v2
- dt document fix listed in patch extra comment

ChiYuan Huang (2):
ASoC: dt-bindings: Add Richtek rtq9128 audio amplifier
ASoC: codecs: Add Richtek rtq9128 audio amplifier support

 .../bindings/sound/richtek,rtq9128.yaml       |  54 ++
 sound/soc/codecs/Kconfig                      |  15 +
 sound/soc/codecs/Makefile                     |   2 +
 sound/soc/codecs/rtq9128.c                    | 766 ++++++++++++++++++
 4 files changed, 837 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml
 create mode 100644 sound/soc/codecs/rtq9128.c
Signature · 1 line
2.34.1
#1 lore raw

PATCH v3 1/2 ASoC: dt-bindings: Add Richtek rtq9128 audio amplifier

From: ChiYuan Huang <[email protected]>

Create richtek,rtq9128.yaml for rtq9128 amplifier.

---
v3
- Add Reviewed-by tag

v2
- Dual license
- Add $ref for dai-common.yaml
- Remove delimiter '|' in head of description

---
 .../bindings/sound/richtek,rtq9128.yaml       | 54 +++++++++++++++++++
 1 file changed, 54 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml
Documentation/devicetree/bindings/sound/richtek,rtq9128.yaml new file +54 -0
new file mode 100644
index 000000000000..d117f08fff30
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/richtek,rtq9128.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Richtek RTQ9128 Automative Audio Power Amplifier
+
+maintainers:
+  - ChiYuan Huang <[email protected]>
+
+description:
+  The RTQ9128 is a ultra-low output noise, high-efficiency, four-channel
+  class-D audio power amplifier and delivering 4x75W into 4OHm at 10%
+  THD+N from a 25V supply in automotive applications.
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    enum:
+      - richtek,rtq9128
+
+  reg:
+    maxItems: 1
+
+  enable-gpios:
+    maxItems: 1
+
+  '#sound-dai-cells':
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - '#sound-dai-cells'
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      speaker@1a {
+        compatible = "richtek,rtq9128";
+        reg = <0x1a>;
+        enable-gpios = <&gpio 26 GPIO_ACTIVE_HIGH>;
+        #sound-dai-cells = <0>;
+      };
+    };
Signature · 1 line
2.34.1
#2 lore raw

PATCH v3 2/2 ASoC: codecs: Add Richtek rtq9128 audio amplifier support

In reply to [email protected]

From: ChiYuan Huang <[email protected]>

Add Richtek rtq9128 automotive audio amplifier.

---
Hi,

At v3, the new added item for DVDD undervoltage selection is from our HW guy's suggestion. Only this item is not from the reviewer comment list.

v3
- Fix patch title
- Modify the copyright and author comment text to c++ style
- Change regmap cache type from RBTREE to MAPLE
- Remove magic soc_enum array, change it to each dedicated soc_enum instance
- Change regmap bus read/write BUG_ON to if/errlog/return
- Remove the fixed DVDD undervoltage threshold setting in RTQ9128 DH&DL init table.
- Add DVDD undervoltage threshold selection in mixer control.

---
 sound/soc/codecs/Kconfig   |  15 +
 sound/soc/codecs/Makefile  |   2 +
 sound/soc/codecs/rtq9128.c | 766 +++++++++++++++++++++++++++++++++++++
 3 files changed, 783 insertions(+)
 create mode 100644 sound/soc/codecs/rtq9128.c
sound/soc/codecs/Kconfig +15 -0
index f1e1dbc509f6..dfa7ea7782cc 100644
@@ -218,6 +218,7 @@ config SND_SOC_ALL_CODECS
 	imply SND_SOC_RT1316_SDW
 	imply SND_SOC_RT1318_SDW
 	imply SND_SOC_RT9120
+	imply SND_SOC_RTQ9128
 	imply SND_SOC_SDW_MOCKUP
 	imply SND_SOC_SGTL5000
 	imply SND_SOC_SI476X
@@ -1636,6 +1637,20 @@ config SND_SOC_RT9120
 	  Enable support for Richtek RT9120 20W, stereo, inductor-less,
 	  high-efficiency Class-D audio amplifier.
 
+config SND_SOC_RTQ9128
+	tristate "Richtek RTQ9128 45W Digital Input Amplifier"
+	depends on I2C
+	select REGMAP
+	help
+	  Enable support for Richtek RTQ9128 digital input 4-channel
+	  automotive audio amplifier.  It is a ultra-low output noise,
+	  high-efficiency, four-channel class-D audio power amplifier
+	  that can deliver over 87% power efficienty at 4x75W into 4Ohm,
+	  25V supply in automotive applications.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called snd-soc-rtq9128.
+
 config SND_SOC_SDW_MOCKUP
 	tristate "SoundWire mockup codec"
 	depends on EXPERT
sound/soc/codecs/Makefile +2 -0
index a87e56938ce5..678b41c09210 100644
@@ -245,6 +245,7 @@ snd-soc-rt715-objs := rt715.o rt715-sdw.o
 snd-soc-rt715-sdca-objs := rt715-sdca.o rt715-sdca-sdw.o
 snd-soc-rt722-sdca-objs := rt722-sdca.o rt722-sdca-sdw.o
 snd-soc-rt9120-objs := rt9120.o
+snd-soc-rtq9128-objs := rtq9128.o
 snd-soc-sdw-mockup-objs := sdw-mockup.o
 snd-soc-sgtl5000-objs := sgtl5000.o
 snd-soc-alc5623-objs := alc5623.o
@@ -627,6 +628,7 @@ obj-$(CONFIG_SND_SOC_RT715)     += snd-soc-rt715.o
 obj-$(CONFIG_SND_SOC_RT715_SDCA_SDW)     += snd-soc-rt715-sdca.o
 obj-$(CONFIG_SND_SOC_RT722_SDCA_SDW)     += snd-soc-rt722-sdca.o
 obj-$(CONFIG_SND_SOC_RT9120)	+= snd-soc-rt9120.o
+obj-$(CONFIG_SND_SOC_RTQ9128)	+= snd-soc-rtq9128.o
 obj-$(CONFIG_SND_SOC_SDW_MOCKUP)     += snd-soc-sdw-mockup.o
 obj-$(CONFIG_SND_SOC_SGTL5000)  += snd-soc-sgtl5000.o
 obj-$(CONFIG_SND_SOC_SIGMADSP)	+= snd-soc-sigmadsp.o
sound/soc/codecs/rtq9128.c new file +766 -0

766 lines not on this page · raw message

Signature · 1 line
2.34.1
maintainer
#3 lore raw
In reply to [email protected]
Quoted 4 lines · On Wed, 20 Sep 2023 11:50:32 +0800, [email protected] wrote:

This patch series adds Richtek rtq9128 automotive audio amplifier support. It can deliver up to 4x75W into 4Ohm speaker from a 25V supply in automotive applications.

Quoted 8 lines

Change log
v3
- Add Reviewed-by tag for dt binding patch
- Refine the source code by reviewer's comments
detail changes listed in the patch
- Add DVDD undervoltage threshold selection from HW guy's suggestion

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: dt-bindings: Add Richtek rtq9128 audio amplifier

      commit: 0339eadb871ab1ebf249932fecb75ab13cc3c565
[2/2] ASoC: codecs: Add Richtek rtq9128 audio amplifier support
      commit: 736064c64cf3fc51c6090884a9f4efe047f9f616

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark