Skip to contentSkip to conversation

doc: bitbake-user-manual: grammar fix for the number of "metadata"

PATCH Superseded Michael Opdenacker 2 participants 3 messages Jul 29, 2021 1 message not in the archive

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#1 lore raw

PATCH v2 1/1 doc: bitbake-user-manual: grammar fix for the number of "metadata"

In reply to a message not in the archive

"metadata" is used both as singular and as plural.
The first change fixes a case in which the verb has a singular conjugation but absence of article indicates a plural case.

The second and third changes are for consistency with the first one inside the same paragraph.

---
 doc/bitbake-user-manual/bitbake-user-manual-intro.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
doc/bitbake-user-manual/bitbake-user-manual-intro.rst +3 -3
index eb140665..55effc35 100644
@@ -27,11 +27,11 @@ Linux software stacks using a task-oriented approach.
 Conceptually, BitBake is similar to GNU Make in some regards but has
 significant differences:
 
--  BitBake executes tasks according to provided metadata that builds up
-   the tasks. Metadata is stored in recipe (``.bb``) and related recipe
+-  BitBake executes tasks according to provided metadata that build up
+   the tasks. Metadata are stored in recipe (``.bb``) and related recipe
    "append" (``.bbappend``) files, configuration (``.conf``) and
    underlying include (``.inc``) files, and in class (``.bbclass``)
-   files. The metadata provides BitBake with instructions on what tasks
+   files. The metadata provide BitBake with instructions on what tasks
    to run and the dependencies between those tasks.
 
 -  BitBake includes a fetcher library for obtaining source code from
Signature · 1 line
2.25.1
#2 lore raw
Quoted 30 lines · Michael Opdenacker

"metadata" is used both as singular and as plural.
The first change fixes a case in which the verb has a singular conjugation but absence of article indicates a plural case.

The second and third changes are for consistency with the first one inside the same paragraph.

---
 doc/bitbake-user-manual/bitbake-user-manual-intro.rst | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)
doc/bitbake-user-manual/bitbake-user-manual-intro.rst +0 -0
index eb140665..55effc35 100644
@@ -27,11 +27,11 @@ Linux software stacks using a task-oriented approach.

 Conceptually, BitBake is similar to GNU Make in some regards but has significant differences:

-- BitBake executes tasks according to provided metadata that builds up

doc/bitbake-user-manual/bitbake-user-manual-intro.rst +2 -1
-   the tasks. Metadata is stored in recipe (``.bb``) and related recipe
+-  BitBake executes tasks according to provided metadata that build up
+   the tasks. Metadata are stored in recipe (``.bb``) and related recipe

    "append" (``.bbappend``) files, configuration (``.conf``) and underlying include (``.inc``) files, and in class (``.bbclass``)

doc/bitbake-user-manual/bitbake-user-manual-intro.rst +1 -1
-   files. The metadata provides BitBake with instructions on what tasks
+   files. The metadata provide BitBake with instructions on what tasks
Quoted 1 line

    to run and the dependencies between those tasks.

This change doesn't sound like an improvement to me. I would always say "The metadata provides", not what you have here which doesn't read correctly to me. "builds up" also sounds better to me than "build up". I'd also say "Metadata is" sounds more correct too.

I'm not sure I like the original wording but this doesn't sound right, at least to me.

Cheers,

Richard

#3 lore raw

Hi Richard,

Quoted 37 lines · Richard Purdie
Quoted 30 lines · Michael Opdenacker

"metadata" is used both as singular and as plural.
The first change fixes a case in which the verb has a singular conjugation but absence of article indicates a plural case.

The second and third changes are for consistency with the first one inside the same paragraph.

---
 doc/bitbake-user-manual/bitbake-user-manual-intro.rst | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)
doc/bitbake-user-manual/bitbake-user-manual-intro.rst +0 -0
index eb140665..55effc35 100644
@@ -27,11 +27,11 @@ Linux software stacks using a task-oriented approach.

 Conceptually, BitBake is similar to GNU Make in some regards but has significant differences:

-- BitBake executes tasks according to provided metadata that builds up

doc/bitbake-user-manual/bitbake-user-manual-intro.rst +2 -1
-   the tasks. Metadata is stored in recipe (``.bb``) and related recipe
+-  BitBake executes tasks according to provided metadata that build up
+   the tasks. Metadata are stored in recipe (``.bb``) and related recipe

    "append" (``.bbappend``) files, configuration (``.conf``) and underlying include (``.inc``) files, and in class (``.bbclass``)

doc/bitbake-user-manual/bitbake-user-manual-intro.rst +1 -1
-   files. The metadata provides BitBake with instructions on what tasks
+   files. The metadata provide BitBake with instructions on what tasks
Quoted 1 line

    to run and the dependencies between those tasks.

This change doesn't sound like an improvement to me. I would always say "The metadata provides", not what you have here which doesn't read correctly to me. "builds up" also sounds better to me than "build up". I'd also say "Metadata is" sounds more correct too.

Quoted 2 lines

I'm not sure I like the original wording but this doesn't sound right, at least to me.

Many thanks for the review. I know what to update then :) Cheers
Michael.

Signature · 3 lines
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com