Skip to contentSkip to conversation

mbuf: remove use of now unnecessary extension keyword

PATCH In review Tyler Retzlaff 1 participant 2 messages Nov 7, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mbuf: remove use of now unnecessary extension keyword

Remove the use of __extension__ on nameless struct and union members they are no longer necessary as they are standard in C11

---
 lib/mbuf/rte_mbuf_core.h | 3 ---
 1 file changed, 3 deletions(-)
lib/mbuf/rte_mbuf_core.h +0 -3
index 5688683..d335ed8 100644
@@ -525,7 +525,6 @@ struct rte_mbuf {
 	 */
 	union {
 		uint32_t packet_type; /**< L2/L3/L4 and tunnel information. */
-		__extension__
 		struct {
 			uint8_t l2_type:4;   /**< (Outer) L2 type. */
 			uint8_t l3_type:4;   /**< (Outer) L3 type. */
@@ -537,7 +536,6 @@ struct rte_mbuf {
 				 * RTE_PTYPE_TUNNEL_ESP tunnel type is set
 				 * on both Tx and Rx.
 				 */
-				__extension__
 				struct {
 					uint8_t inner_l2_type:4;
 					/**< Inner L2 type. */
@@ -614,7 +612,6 @@ struct rte_mbuf {
 	/* fields to support TX offloads */
 	union {
 		uint64_t tx_offload;       /**< combined for easy fetch */
-		__extension__
 		struct {
 			uint64_t l2_len:RTE_MBUF_L2_LEN_BITS;
 			/**< L2 (MAC) Header Length for non-tunneling pkt.
Signature · 1 line
1.8.3.1
#1 lore raw

this series will be withdrawn since the keyword was also applied to the bitfields.

sorry for the noise

Quoted 38 lines · Tyler Retzlaff

Remove the use of __extension__ on nameless struct and union members they are no longer necessary as they are standard in C11

---
 lib/mbuf/rte_mbuf_core.h | 3 ---
 1 file changed, 3 deletions(-)
lib/mbuf/rte_mbuf_core.h +0 -3
index 5688683..d335ed8 100644
@@ -525,7 +525,6 @@ struct rte_mbuf {
 	 */
 	union {
 		uint32_t packet_type; /**< L2/L3/L4 and tunnel information. */
-		__extension__
 		struct {
 			uint8_t l2_type:4;   /**< (Outer) L2 type. */
 			uint8_t l3_type:4;   /**< (Outer) L3 type. */
@@ -537,7 +536,6 @@ struct rte_mbuf {
 				 * RTE_PTYPE_TUNNEL_ESP tunnel type is set
 				 * on both Tx and Rx.
 				 */
-				__extension__
 				struct {
 					uint8_t inner_l2_type:4;
 					/**< Inner L2 type. */
@@ -614,7 +612,6 @@ struct rte_mbuf {
 	/* fields to support TX offloads */
 	union {
 		uint64_t tx_offload;       /**< combined for easy fetch */
-		__extension__
 		struct {
 			uint64_t l2_len:RTE_MBUF_L2_LEN_BITS;
 			/**< L2 (MAC) Header Length for non-tunneling pkt.
Signature · 1 line
1.8.3.1