Skip to contentSkip to conversation

Add sound/adc support for RZ/G2L

PATCH Prabhakar Mahadev Lad 3 participants 3 messages Jan 6, 2022 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Prabhakar Mahadev Lad

author
#1 lore raw

Hi Pavel,

Quoted 9 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Lad Prabhakar via lists.cip-project.org
Sent: 29 December 2021 10:15
To: [email protected]; Nobuhiro Iwamatsu <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>
Subject: [cip-dev] [PATCH 5.10.y-cip 00/31] Add sound/adc support for RZ/G2L

Quoted 9 lines

Hi All,

This patch series adds Sound and ADC support for Renesas RZ/G2L SoC and enables RIIC/SOUND/CANFD/ADC on Renesas SMARC EVK.

I have also included the missing driver patch for riic and kernel configs.

All the patches have been cherry picked from v5.16-rc7.

Do you want me to separate out audio related patches and just send the ADC for now until the audio patch comments are resolved/fixed?

Cheers,
Prabhakar

Quoted 80 lines

I have created a MR [0] for cip-kernel-config to support build testing and can be merged once this patch series is accepted.

[0] https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.com%2Fcip-project%2Fcip-
kernel%2Fcip-kernel-config%2F-%2Fmerge_requests%2F55&amp;data=04%7C01%7Cprabhakar.mahadev- lad.rj%40bp.renesas.com%7C448a426ec06a400fd7ee08d9cab42a09%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0% 7C637763697420828810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV CI6Mn0%3D%7C3000&amp;sdata=T6OVaoV3tgK9UsAYD7ZeT%2FwjVctGGJM3Hja2V%2BBd5mU%3D&amp;reserved=0

Cheers,
Prabhakar

Biju Das (21):
ASoC: dt-bindings: Document RZ/G2L bindings
ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support
ASoC: sh: Add RZ/G2L SSIF-2 driver
ASoC: dt-bindings: renesas,rz-ssi: Update slave dma channel
configuration parameter
ASoC: sh: rz-ssi: Add SSI DMAC support
ASoC: sh: rz-ssi: Fix dereference of noderef expression warning
ASoC: sh: rz-ssi: Fix wrong operator used issue
ASoC: sh: rz-ssi: Improve error handling in rz_ssi_dma_request
function
clk: renesas: r9a07g044: Add SSIF-2 clock and reset entries
arm64: dts: renesas: r9a07g044: Add external audio clock nodes
arm64: dts: renesas: r9a07g044: Add SSI support
arm64: dts: renesas: r9a07g044: Add DMA support to SSI
arm64: dts: renesas: rzg2l-smarc: Enable I2C{0,1,3} support
arm64: dts: renesas: rzg2l-smarc: Add WM8978 sound codec
arm64: dts: renesas: rzg2l-smarc: Enable audio
arm64: dts: renesas: rzg2l-smarc: Add Mic routing
arm64: defconfig: Enable SOUND_SOC_RZ
arm64: defconfig: Enable SND_SOC_WM8978
clk: renesas: r9a07g044: Mark IA55_CLK and DMAC_ACLK critical
i2c: riic: Add RZ/G2L support
arm64: defconfig: Enable RIIC

Colin Ian King (1):
iio: adc: rzg2l_adc: Fix -EBUSY timeout error return

Lad Prabhakar (8):
dt-bindings: iio: adc: Add binding documentation for Renesas RZ/G2L
A/D converter
iio: adc: Add driver for Renesas RZ/G2L A/D converter
clk: renesas: r9a07g044: Add clock and reset entries for ADC
arm64: dts: renesas: r9a07g044: Add ADC node
arm64: dts: renesas: rzg2l-smarc-som: Move extal and memory nodes to
SOM DTSI
arm64: dts: renesas: rzg2l-smarc-som: Enable ADC on SMARC platform
arm64: dts: renesas: rzg2l-smarc: Enable CANFD
arm64: defconfig: Enable RZG2L_ADC

Yang Yingliang (1):
iio: adc: rzg2l_adc: add missing clk_disable_unprepare() in
rzg2l_adc_pm_runtime_resume()

 .../bindings/iio/adc/renesas,rzg2l-adc.yaml   |  134 ++
 .../bindings/sound/renesas,rz-ssi.yaml        |  118 ++
 MAINTAINERS                                   |    8 +
 arch/arm64/boot/dts/renesas/r9a07g044.dtsi    |  140 +++
 .../boot/dts/renesas/r9a07g044l2-smarc.dts    |    7 +-
 .../boot/dts/renesas/rzg2l-smarc-som.dtsi     |   35 +
 arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi  |  162 ++-
 arch/arm64/configs/defconfig                  |    4 +
 drivers/clk/renesas/r9a07g044-cpg.c           |   28 +
 drivers/i2c/busses/i2c-riic.c                 |   23 +-
 drivers/iio/adc/Kconfig                       |   10 +
 drivers/iio/adc/Makefile                      |    1 +
 drivers/iio/adc/rzg2l_adc.c                   |  591 +++++++++
 sound/soc/sh/Kconfig                          |    6 +
 sound/soc/sh/Makefile                         |    4 +
 sound/soc/sh/rz-ssi.c                         | 1074 +++++++++++++++++
 16 files changed, 2334 insertions(+), 11 deletions(-)  create mode 100644
Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
 create mode 100644 arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
 create mode 100644 drivers/iio/adc/rzg2l_adc.c  create mode 100644 sound/soc/sh/rz-ssi.c

--
2.17.1

#2 lore raw

Hi Pavel,

Quoted 20 lines

Subject: RE: [cip-dev] [PATCH 5.10.y-cip 00/31] Add sound/adc support for RZ/G2L

Hi Pavel,

Quoted 15 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Lad Prabhakar via lists.cip-project.org
Sent: 29 December 2021 10:15
To: [email protected]; Nobuhiro Iwamatsu <[email protected]>; Pavel Machek <[email protected]>
Cc: Biju Das <[email protected]>
Subject: [cip-dev] [PATCH 5.10.y-cip 00/31] Add sound/adc support for RZ/G2L

Hi All,

This patch series adds Sound and ADC support for Renesas RZ/G2L SoC and enables RIIC/SOUND/CANFD/ADC on Renesas SMARC EVK.

Quoted 7 lines
Quoted 1 line

I have also included the missing driver patch for riic and kernel

configs.

Quoted 3 lines

All the patches have been cherry picked from v5.16-rc7.

Do you want me to separate out audio related patches and just send the ADC for now until the audio patch comments are resolved/fixed?

Just to add, I have tested audio playback/capture continuously for 3 days without anu issues. The race is between atomic context and quit function. Currently it is not triggering any issues. If you can point out a valid case where it can trigger issue, I am happy to check that.

Regards,
Biju

Quoted 93 lines

Cheers,
Prabhakar

Quoted 89 lines

I have created a MR [0] for cip-kernel-config to support build testing and can be merged once this patch series is accepted.

[0]
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl
ab.com%2Fcip-project%2Fcip- kernel%2Fcip-kernel-config%2F-%2Fmerge_requests%2F55&amp;data=04%7C01% 7Cprabhakar.mahadev- lad.rj%40bp.renesas.com%7C448a426ec06a400fd7ee08d9cab42a09%7C53d82571d a1947e49cb4625a166a4a2a%7C0%7C0% 7C637763697420828810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI joiV2luMzIiLCJBTiI6Ik1haWwiLCJXV CI6Mn0%3D%7C3000&amp;sdata=T6OVaoV3tgK9UsAYD7ZeT%2FwjVctGGJM3Hja2V%2BB d5mU%3D&amp;reserved=0

Cheers,
Prabhakar

Biju Das (21):
ASoC: dt-bindings: Document RZ/G2L bindings
ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support
ASoC: sh: Add RZ/G2L SSIF-2 driver
ASoC: dt-bindings: renesas,rz-ssi: Update slave dma channel
configuration parameter
ASoC: sh: rz-ssi: Add SSI DMAC support
ASoC: sh: rz-ssi: Fix dereference of noderef expression warning
ASoC: sh: rz-ssi: Fix wrong operator used issue
ASoC: sh: rz-ssi: Improve error handling in rz_ssi_dma_request
function
clk: renesas: r9a07g044: Add SSIF-2 clock and reset entries
arm64: dts: renesas: r9a07g044: Add external audio clock nodes
arm64: dts: renesas: r9a07g044: Add SSI support
arm64: dts: renesas: r9a07g044: Add DMA support to SSI
arm64: dts: renesas: rzg2l-smarc: Enable I2C{0,1,3} support
arm64: dts: renesas: rzg2l-smarc: Add WM8978 sound codec
arm64: dts: renesas: rzg2l-smarc: Enable audio
arm64: dts: renesas: rzg2l-smarc: Add Mic routing
arm64: defconfig: Enable SOUND_SOC_RZ
arm64: defconfig: Enable SND_SOC_WM8978
clk: renesas: r9a07g044: Mark IA55_CLK and DMAC_ACLK critical
i2c: riic: Add RZ/G2L support
arm64: defconfig: Enable RIIC

Colin Ian King (1):
iio: adc: rzg2l_adc: Fix -EBUSY timeout error return

Lad Prabhakar (8):
dt-bindings: iio: adc: Add binding documentation for Renesas RZ/G2L
A/D converter
iio: adc: Add driver for Renesas RZ/G2L A/D converter
clk: renesas: r9a07g044: Add clock and reset entries for ADC
arm64: dts: renesas: r9a07g044: Add ADC node
arm64: dts: renesas: rzg2l-smarc-som: Move extal and memory nodes to
SOM DTSI
arm64: dts: renesas: rzg2l-smarc-som: Enable ADC on SMARC platform
arm64: dts: renesas: rzg2l-smarc: Enable CANFD
arm64: defconfig: Enable RZG2L_ADC

Yang Yingliang (1):
iio: adc: rzg2l_adc: add missing clk_disable_unprepare() in
rzg2l_adc_pm_runtime_resume()

 .../bindings/iio/adc/renesas,rzg2l-adc.yaml   |  134 ++
 .../bindings/sound/renesas,rz-ssi.yaml        |  118 ++
 MAINTAINERS                                   |    8 +
 arch/arm64/boot/dts/renesas/r9a07g044.dtsi    |  140 +++
 .../boot/dts/renesas/r9a07g044l2-smarc.dts    |    7 +-
 .../boot/dts/renesas/rzg2l-smarc-som.dtsi     |   35 +
 arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi  |  162 ++-
 arch/arm64/configs/defconfig                  |    4 +
 drivers/clk/renesas/r9a07g044-cpg.c           |   28 +
 drivers/i2c/busses/i2c-riic.c                 |   23 +-
 drivers/iio/adc/Kconfig                       |   10 +
 drivers/iio/adc/Makefile                      |    1 +
 drivers/iio/adc/rzg2l_adc.c                   |  591 +++++++++
 sound/soc/sh/Kconfig                          |    6 +
 sound/soc/sh/Makefile                         |    4 +
 sound/soc/sh/rz-ssi.c                         | 1074 +++++++++++++++++
 16 files changed, 2334 insertions(+), 11 deletions(-)  create mode
100644
Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml
 create mode 100644
Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
 create mode 100644 arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
 create mode 100644 drivers/iio/adc/rzg2l_adc.c  create mode 100644

sound/soc/sh/rz-ssi.c

--
2.17.1

#3 lore raw
In reply to Prabhakar Mahadev Lad

Hi!

Quoted 11 lines
Quoted 9 lines

Hi All,

This patch series adds Sound and ADC support for Renesas RZ/G2L SoC and enables RIIC/SOUND/CANFD/ADC on Renesas SMARC EVK.

I have also included the missing driver patch for riic and kernel configs.

All the patches have been cherry picked from v5.16-rc7.

Do you want me to separate out audio related patches and just send the ADC for now until the audio patch comments are resolved/fixed?

Yes, I was thinking about that, too. That would be easy way forward.

Thank you and best regards,
Pavel

Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany