Skip to contentSkip to conversation

classes: Only allow network in existing network accessing code

PATCH Richard Purdie 2 participants 2 messages Jan 7, 2022 – Jan 11, 2022 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 14 lines · Richard Purdie via lists.openembedded.org

Use the newly added network task flag against tasks where network access is expected. This is do_fetch, do_checkuri, do_testimage, do_testsdk and do_testsdkext.

We can't disable networking in sstate tasks due to sstate downloads and also so we can report hash equivalence to the server so network access is enabled in sstate tasks.

Access within build-appliance do_image is also allowed due to the use of pip, this is a poor example made rather obvious now and needs to be reworked.

Network access anywhere else in any other task isn't allowed.

Quoted 8 lines
---
 meta/classes/base.bbclass                                | 1 +
 meta/classes/sstate.bbclass                              | 2 ++
 meta/classes/testimage.bbclass                           | 1 +
 meta/classes/testsdk.bbclass                             | 2 ++
 meta/classes/utility-tasks.bbclass                       | 1 +
 meta/recipes-core/images/build-appliance-image_15.0.0.bb | 2 ++
 6 files changed, 9 insertions(+)

This patch (and corresponding bitbake patches) does the opposite of the previous version, it uses a network flag which allows network access in a task and network access is otherwise disabled. I've shared it since several people requested this form of patch instead of the other.

I think this version may be easier to "abuse". It does highlight the rather poor design choices to support toaster in build-appliance.

Cheers,

Richard

#2 lore raw

I think this is the right way to go. To me, it seems equally easy to subvert both forms, but with this one, the abuse can be easily seen and exposed as such.

Alex

Quoted 54 lines · Richard Purdie
Quoted 2 lines · Richard Purdie via lists.openembedded.org

Use the newly added network task flag against tasks where network access is expected. This is do_fetch, do_checkuri, do_testimage,

do_testsdk

Quoted 8 lines

and do_testsdkext.

We can't disable networking in sstate tasks due to sstate downloads and also so we can report hash equivalence to the server so network access is enabled in sstate tasks.

Access within build-appliance do_image is also allowed due to the use of pip, this is a poor example made rather obvious now and needs to be

reworked.

Quoted 4 lines

Network access anywhere else in any other task isn't allowed.

Quoted 8 lines
---
 meta/classes/base.bbclass                                | 1 +
 meta/classes/sstate.bbclass                              | 2 ++
 meta/classes/testimage.bbclass                           | 1 +
 meta/classes/testsdk.bbclass                             | 2 ++
 meta/classes/utility-tasks.bbclass                       | 1 +
 meta/recipes-core/images/build-appliance-image_15.0.0.bb | 2 ++
 6 files changed, 9 insertions(+)

This patch (and corresponding bitbake patches) does the opposite of the previous
version, it uses a network flag which allows network access in a task and network access is otherwise disabled. I've shared it since several people requested this form of patch instead of the other.

I think this version may be easier to "abuse". It does highlight the rather poor
design choices to support toaster in build-appliance.

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#160272):
https://lists.openembedded.org/g/openembedded-core/message/160272
Mute This Topic: https://lists.openembedded.org/mt/88273730/1686489
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-