Skip to contentSkip to conversation

buildhistory.bbclass: create the buildhistory directory when needed

PATCH Jose Quaresma 2 participants 3 messages Mar 3, 2022 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Can this patch be backported to dunfell?

Jose

Jose Quaresma via lists.openembedded.org <quaresma.jose= [email protected]> escreveu no dia quarta, 2/03/2022 à(s) 00:47:

Quoted 63 lines

When the BUILDHISTORY_RESET is enabled we need to move the content from BUILDHISTORY_DIR to BUILDHISTORY_OLD_DIR but when we start a clean build in the first run we don't have the BUILDHISTORY_DIR so the move of files will fail.

| ERROR: Command execution failed: Traceback (most recent call last):
|  File "/xxx/poky/bitbake/lib/bb/command.py", line 110, in runAsyncCommand
|    commandmethod(self.cmds_async, self, options)
|  File "/xxx/poky/bitbake/lib/bb/command.py", line 564, in buildTargets
|    command.cooker.buildTargets(pkgs_to_build, task)
|  File "/xxx/poky/bitbake/lib/bb/cooker.py", line 1481, in buildTargets
|    bb.event.fire(bb.event.BuildStarted(buildname, ntargets),

self.databuilder.mcdata[mc])
| File "/xxx/home/builder/src/base/poky/bitbake/lib/bb/event.py", line 214, in fire
| fire_class_handlers(event, d)
| File "/xxx/poky/bitbake/lib/bb/event.py", line 121, in fire_class_handlers

|    execute_handler(name, handler, event, d)
|  File "/xxx/poky/bitbake/lib/bb/event.py", line 93, in execute_handler
|    ret = handler(event)
|  File "/xxx/poky/meta/classes/buildhistory.bbclass", line 919, in

buildhistory_eventhandler
| entries = [ x for x in os.listdir(rootdir) if not x.startswith('.') ]
| FileNotFoundError: [Errno 2] No such file or directory:
'/xxx/buildhistory'

---
V2: remove the check to see if the directory exists

 meta/classes/buildhistory.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/buildhistory.bbclass +1 -0
index 49797a6701..8db79a4829 100644
@@ -896,6 +896,7 @@ python buildhistory_eventhandler() {
                 if os.path.isdir(olddir):
                     shutil.rmtree(olddir)
                 rootdir = e.data.getVar("BUILDHISTORY_DIR")
+                bb.utils.mkdirhier(rootdir)
                 entries = [ x for x in os.listdir(rootdir) if not

x.startswith('.') ]
bb.utils.mkdirhier(olddir)
for entry in entries:
--
2.35.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#162587):
https://lists.openembedded.org/g/openembedded-core/message/162587
Mute This Topic: https://lists.openembedded.org/mt/89491842/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Best regards,

José Quaresma
#2 lore raw
Quoted 2 lines · Jose Quaresma

Can this patch be backported to dunfell?

I've added it to my test queue.

Steve

Quoted 64 lines

Jose

Jose Quaresma via lists.openembedded.org <[email protected]> escreveu no dia quarta, 2/03/2022 à(s) 00:47:

Quoted 46 lines

When the BUILDHISTORY_RESET is enabled we need to move the content from BUILDHISTORY_DIR to BUILDHISTORY_OLD_DIR but when we start a clean build in the first run we don't have the BUILDHISTORY_DIR so the move of files will fail.

| ERROR: Command execution failed: Traceback (most recent call last):
|  File "/xxx/poky/bitbake/lib/bb/command.py", line 110, in runAsyncCommand
|    commandmethod(self.cmds_async, self, options)
|  File "/xxx/poky/bitbake/lib/bb/command.py", line 564, in buildTargets
|    command.cooker.buildTargets(pkgs_to_build, task)
|  File "/xxx/poky/bitbake/lib/bb/cooker.py", line 1481, in buildTargets
|    bb.event.fire(bb.event.BuildStarted(buildname, ntargets), self.databuilder.mcdata[mc])
|  File "/xxx/home/builder/src/base/poky/bitbake/lib/bb/event.py", line 214, in fire
|    fire_class_handlers(event, d)
|  File "/xxx/poky/bitbake/lib/bb/event.py", line 121, in fire_class_handlers
|    execute_handler(name, handler, event, d)
|  File "/xxx/poky/bitbake/lib/bb/event.py", line 93, in execute_handler
|    ret = handler(event)
|  File "/xxx/poky/meta/classes/buildhistory.bbclass", line 919, in buildhistory_eventhandler
|    entries = [ x for x in os.listdir(rootdir) if not x.startswith('.') ]
| FileNotFoundError: [Errno 2] No such file or directory: '/xxx/buildhistory'

---
V2: remove the check to see if the directory exists

 meta/classes/buildhistory.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/buildhistory.bbclass +1 -1
index 49797a6701..8db79a4829 100644
@@ -896,6 +896,7 @@ python buildhistory_eventhandler() {
                 if os.path.isdir(olddir):
                     shutil.rmtree(olddir)
                 rootdir = e.data.getVar("BUILDHISTORY_DIR")
+                bb.utils.mkdirhier(rootdir)
                 entries = [ x for x in os.listdir(rootdir) if not x.startswith('.') ]
                 bb.utils.mkdirhier(olddir)
                 for entry in entries:
--

2.35.1

Quoted 8 lines

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#162587): https://lists.openembedded.org/g/openembedded-core/message/162587
Mute This Topic: https://lists.openembedded.org/mt/89491842/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

--
Best regards,

José Quaresma

#3 lore raw

Great, thanks!

Steve Sakoman <[email protected]> escreveu no dia quinta, 3/03/2022 à(s) 14:49:

Quoted 87 lines
Quoted 2 lines · Jose Quaresma

Can this patch be backported to dunfell?

I've added it to my test queue.

Steve

Quoted 4 lines

Jose

Jose Quaresma via lists.openembedded.org <quaresma.jose=

[email protected]> escreveu no dia quarta, 2/03/2022 à(s) 00:47:

Quoted 8 lines
Quoted 8 lines

When the BUILDHISTORY_RESET is enabled we need to move the content from BUILDHISTORY_DIR to BUILDHISTORY_OLD_DIR but when we start a clean build in the first run we don't have the BUILDHISTORY_DIR so the move of files will fail.

| ERROR: Command execution failed: Traceback (most recent call last):
| File "/xxx/poky/bitbake/lib/bb/command.py", line 110, in

runAsyncCommand

Quoted 5 lines
Quoted 5 lines
|    commandmethod(self.cmds_async, self, options)
|  File "/xxx/poky/bitbake/lib/bb/command.py", line 564, in buildTargets
|    command.cooker.buildTargets(pkgs_to_build, task)
|  File "/xxx/poky/bitbake/lib/bb/cooker.py", line 1481, in buildTargets
|    bb.event.fire(bb.event.BuildStarted(buildname, ntargets),

self.databuilder.mcdata[mc])

Quoted 1 line
Quoted 1 line

| File "/xxx/home/builder/src/base/poky/bitbake/lib/bb/event.py", line

214, in fire

Quoted 2 lines
Quoted 2 lines

| fire_class_handlers(event, d)
| File "/xxx/poky/bitbake/lib/bb/event.py", line 121, in

fire_class_handlers

Quoted 4 lines
Quoted 4 lines
|    execute_handler(name, handler, event, d)
|  File "/xxx/poky/bitbake/lib/bb/event.py", line 93, in execute_handler
|    ret = handler(event)
|  File "/xxx/poky/meta/classes/buildhistory.bbclass", line 919, in

buildhistory_eventhandler

Quoted 1 line
Quoted 1 line

| entries = [ x for x in os.listdir(rootdir) if not

x.startswith('.') ]

Quoted 1 line
Quoted 1 line

| FileNotFoundError: [Errno 2] No such file or directory:

'/xxx/buildhistory'

Quoted 9 lines

Review

Quoted 9 lines

---
V2: remove the check to see if the directory exists

 meta/classes/buildhistory.bbclass | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/meta/classes/buildhistory.bbclass

Quoted 9 lines

meta/classes/buildhistory.bbclass python buildhistory_eventhandler() { · line 900

Quoted 9 lines

index 49797a6701..8db79a4829 100644

meta/classes/buildhistory.bbclass +1 -0
@@ -896,6 +896,7 @@ python buildhistory_eventhandler() {
                 if os.path.isdir(olddir):
                     shutil.rmtree(olddir)
                 rootdir = e.data.getVar("BUILDHISTORY_DIR")
+                bb.utils.mkdirhier(rootdir)
                 entries = [ x for x in os.listdir(rootdir) if not

x.startswith('.') ]

Quoted 9 lines
Quoted 9 lines
meta/classes/buildhistory.bbclass +0 -1
                 bb.utils.mkdirhier(olddir)
                 for entry in entries:
--

2.35.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#162587):

https://lists.openembedded.org/g/openembedded-core/message/162587

Quoted 3 lines
Quoted 3 lines

Mute This Topic: https://lists.openembedded.org/mt/89491842/5052612
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [

[email protected]]

Quoted 8 lines
Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-

--
Best regards,

José Quaresma

Signature · 3 lines
Best regards,

José Quaresma