Compile error of fsck.overlay on Fedora30
Hi Zhangyi,
I found a compile error of fsck.overlay on my laptop(fedora 30), it looks like lacking of header in the check.c. After manually added <sys/sysmacros.h> compile succeeded without error.
Detail info of compile error as below:
[cgxu@localhost overlayfs-progs]$ make
gcc -Wall -g -c fsck.c
gcc -Wall -g -c common.c
gcc -Wall -g -c lib.c
gcc -Wall -g -c check.ccheck.c: In function ‘ovl_create_whiteout’:
check.c:173:55: warning: implicit declaration of function ‘makedev’ [-Wimplicit-function-declaration]
173 | if (mknodat(dirfd, pathname, S_IFCHR | WHITEOUT_MOD, makedev(0, 0))) {
| ^~~~~~~
gcc -Wall -g -c mount.c
gcc -Wall -g -c path.c
gcc -Wall -g -c overlayfs.c
gcc -lm fsck.o common.o lib.o check.o mount.o path.o overlayfs.o -o fsck.overlay /usr/bin/ld: check.o: in function `ovl_create_whiteout':/home/cgxu/git/overlayfs-progs/check.c:173: undefined reference to `makedev'
collect2: error: ld returned 1 exit status
make: *** [Makefile:10: overlay] Error 1
Thanks,
Chengguang
Hi Chengguang,
Thanks for reporting, I will check and fix this soon.
Thanks,
Yi.
On 2019/10/31 22:07, Chengguang Xu Wrote:
Quoted 33 lines
Hi Zhangyi,
I found a compile error of fsck.overlay on my laptop(fedora 30), it looks like lacking of header in the
check.c. After manually added <sys/sysmacros.h> compile succeeded without error.Detail info of compile error as below:
[cgxu@localhost overlayfs-progs]$ make
gcc -Wall -g -cfsck.c
gcc -Wall -g -ccommon.c
gcc -Wall -g -clib.c
gcc -Wall -g -ccheck.ccheck.c: In function ‘ovl_create_whiteout’:
check.c:173:55: warning: implicit declaration of function ‘makedev’ [-Wimplicit-function-declaration]
173 | if (mknodat(dirfd, pathname, S_IFCHR | WHITEOUT_MOD, makedev(0, 0))) {
| ^~~~~~~
gcc -Wall -g -cmount.c
gcc -Wall -g -cpath.c
gcc -Wall -g -coverlayfs.c
gcc -lm fsck.o common.o lib.o check.o mount.o path.o overlayfs.o -o fsck.overlay/usr/bin/ld: check.o: in function `ovl_create_whiteout':/home/cgxu/git/overlayfs-progs/check.c:173: undefined reference to `makedev'
collect2: error: ld returned 1 exit status
make: *** [Makefile:10: overlay] Error 1Thanks,
Chengguang.