rwsem-spinlock linkage error
PATCH 1/1 rwsem-spinlock linkage error
The
Andrew Morton:
o rwsem: Make rwsems use interrupt disabling spinlocks
change in 2.4.31-pre1 has a typo: one occurrence of spin_unlock() was changed to spin_unlock_restore() instead of spin_unlock_irqrestore() as was obviously the intention. Since spin_unlock_restore() doesn't exist, this results in linkage errors on x86_64 and other archs using CONFIG_RWSEM_GENERIC_SPINLOCK.
Trival fix below.
lib/rwsem-spinlock.c renamed from lib/rwsem-spinlock.c.~1~ +1 -1
@@ -269,7 +269,7 @@ void fastcall __up_read(struct rw_semaphif (--sem->activity==0 && !list_empty (&sem->wait_list)) sem =__rwsem_wake_one_writer (sem); -spin_unlock_restore (&sem->wait_lock, flags); +spin_unlock_irqrestore (&sem->wait_lock, flags);rwsemtrace (sem,"Leaving __up_read" ); }
Marcelo Tosatti
AppliedApplied, thanks Mikael.
Quoted 26 lines · Mikael Pettersson
The
Andrew Morton:
o rwsem: Make rwsems use interrupt disabling spinlockschange in 2.4.31-pre1 has a typo: one occurrence of
spin_unlock()was changed tospin_unlock_restore()instead ofspin_unlock_irqrestore()as was obviously the intention. Sincespin_unlock_restore()doesn't exist, this results in linkage errors onx86_64and other archs usingCONFIG_RWSEM_GENERIC_SPINLOCK.Trival fix below.
Signed-off-by Mikael Pettersson <[email protected]>lib/rwsem-spinlock.c renamed from lib/rwsem-spinlock.c.~1~ +1
-1@@ -269,7 +269,7 @@ void fastcall __up_read(struct rw_semaphif (--sem->activity==0 && !list_empty (&sem->wait_list)) sem =__rwsem_wake_one_writer (sem); -spin_unlock_restore (&sem->wait_lock, flags); +spin_unlock_irqrestore (&sem->wait_lock, flags);rwsemtrace (sem,"Leaving __up_read" ); }