Skip to contentSkip to conversation

ppc64: fix prom.c compile warning

PATCH New Paul Mackerras 1 participant 1 message May 6, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc64: fix prom.c compile warning

The code in unflatten_device_tree knows that get_property is written to only return with lenp equal to 1 when also returning a valid pointer. The gcc 3.3.3 compiler is not able to prove this to itself, so it warns about a possible uninitialized pointer dereference:

.../arch/ppc64/kernel/prom.c: In function `unflatten_device_tree':
.../arch/ppc64/kernel/prom.c:828:
warning: `p' might be used uninitialized in this function

Unless it is desired to rework the interaction between the two functions, this will keep the existing behavior but quiet the compiler.

---

arch/ppc64/kernel/prom.c +1 -1
diff -urN linux-2.6/arch/ppc64/kernel/prom.c test/arch/ppc64/kernel/prom.c
@@ -834,7 +834,7 @@
 {
 	unsigned long start, mem, size;
 	struct device_node **allnextp = &allnodes;
-	char *p;
+	char *p = NULL;
 	int l = 0;
 
 	DBG(" -> unflatten_device_tree()\n");