fabrics: Fix fast_io_fail_tmo option
PATCH 1/1 fabrics: Fix fast_io_fail_tmo option
The option was partially removed by a refactoring commit. Return it back, because it is still supported by the kernel driver.
--- fabrics.c | 2 ++ 1 file changed, 2 insertions(+)
fabrics.c +2 -0
@@ -78,6 +78,7 @@ static const char *nvmf_queue_size = "number of io queue elements to use (defaulstatic const char *nvmf_keep_alive_tmo ="keep alive timeout period in seconds" ;static const char *nvmf_reconnect_delay ="reconnect timeout period in seconds" ;static const char *nvmf_ctrl_loss_tmo ="controller loss timeout period in seconds" ; +static const char *nvmf_fast_io_fail_tmo ="fast I/O fail timeout (default off)" ;static const char *nvmf_tos ="type of service" ;static const char *nvmf_keyring ="Keyring for TLS key lookup" ;static const char *nvmf_tls_key ="TLS key to use" ;
@@ -108,6 +109,7 @@ static const char *nvmf_context = "execution context identification string";OPT_INT ("keep-alive-tmo" ,'k' , &c.keep_alive_tmo, nvmf_keep_alive_tmo), \OPT_INT ("reconnect-delay" ,'c' , &c.reconnect_delay, nvmf_reconnect_delay), \OPT_INT ("ctrl-loss-tmo" ,'l' , &c.ctrl_loss_tmo, nvmf_ctrl_loss_tmo), \ +OPT_INT ("fast_io_fail_tmo" ,'F' , &c.fast_io_fail_tmo, nvmf_fast_io_fail_tmo),\OPT_INT ("tos" ,'T' , &c.tos, nvmf_tos), \OPT_INT ("keyring" ,0 , &c.keyring, nvmf_keyring), \ OPT_INT("tls_key", 0, &c.tls_key, nvmf_tls_key), \
Signature · 1 line
2.34.1
Quoted 23 lines · Israel Rukshin
The option was partially removed by a refactoring commit. Return it back, because it is still supported by the kernel driver.
Fixes 18de3a6d61a7 ("Convert to libnvme")Signed-off-by Israel Rukshin <[email protected]>--- fabrics.c | 2 ++ 1 file changed, 2 insertions(+)fabrics.c +1
-0@@ -78,6 +78,7 @@ static const char *nvmf_queue_size = "number of io queue elements to use (defaulstatic const char *nvmf_keep_alive_tmo ="keep alive timeout period in seconds" ;static const char *nvmf_reconnect_delay ="reconnect timeout period in seconds" ;static const char *nvmf_ctrl_loss_tmo ="controller loss timeout period in seconds" ; +static const char *nvmf_fast_io_fail_tmo ="fast I/O fail timeout (default off)" ;static const char *nvmf_tos ="type of service" ;static const char *nvmf_keyring ="Keyring for TLS key lookup" ;static const char *nvmf_tls_key ="TLS key to use" ;
fabrics.c static const char *nvmf_context = "execution context identification string"; · line 115
Quoted 7 lines
fabrics.c +1
-0@@ -108,6 +109,7 @@ static const char *nvmf_context = "execution context identification string";OPT_INT ("keep-alive-tmo" ,'k' , &c.keep_alive_tmo, nvmf_keep_alive_tmo), \OPT_INT ("reconnect-delay" ,'c' , &c.reconnect_delay, nvmf_reconnect_delay), \OPT_INT ("ctrl-loss-tmo" ,'l' , &c.ctrl_loss_tmo, nvmf_ctrl_loss_tmo), \ +OPT_INT ("fast_io_fail_tmo" ,'F' , &c.fast_io_fail_tmo, nvmf_fast_io_fail_tmo),\OPT_INT ("tos" ,'T' , &c.tos, nvmf_tos), \OPT_INT ("keyring" ,0 , &c.keyring, nvmf_keyring), \ OPT_INT("tls_key", 0, &c.tls_key, nvmf_tls_key), \
In the previous version I've noticed that the short symbol was 'f':
"
- OPT_INT("fast_io_fail_tmo",'f',&fabrics_cfg.fast_io_fail_tmo, "fast I/O fail timeout (default off)"), "
Any reason to make it 'F' now ?
Otherwise looks good,
Quoted 7 lines · Max Gurtovoy
In the previous version I've noticed that the short symbol was 'f':
"
-OPT_INT("fast_io_fail_tmo",'f',&fabrics_cfg.fast_io_fail_tmo, "fast I/O fail timeout (default off)"),
"Any reason to make it 'F' now ?
Yes, 'f' is now taken by "host-iface".
Quoted 4 lines
Otherwise looks good,
Reviewed-by Max Gurtovoy <[email protected]>
Daniel Wagner
AppliedQuoted 5 lines · Israel Rukshin
The option was partially removed by a refactoring commit. Return it back, because it is still supported by the kernel driver.
Applied, thanks!
[1/1] fabrics: Fix fast_io_fail_tmo option
commit: 14ee80dfe872e138dced8eb3f33aee46329eb078
Best regards,
Signature · 1 line
Daniel Wagner <[email protected]>