Skip to contentSkip to conversation

RDMA/bnxt_re: Fix the max msix vectors macro

PATCH Applied Selvin Xavier 2 participants 2 messages May 20, 2024 – May 30, 2024

Subsystems (2)
lore
Share & tools
lore

Selvin Xavier

author maintainer
#0 lore raw

PATCH 1/1 RDMA/bnxt_re: Fix the max msix vectors macro

bnxt_re no longer decide the number of MSI-x vectors used by itself. Its decided by bnxt_en now. So when bnxt_en changes this value, system crash is seen.

Depend on the max value reported by bnxt_en instead of using the its own macros.

Fixes 303432211324 ("bnxt_en: Remove runtime interrupt vector allocation")
---
 drivers/infiniband/hw/bnxt_re/bnxt_re.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/infiniband/hw/bnxt_re/bnxt_re.h +1 -3
index 9dca451..6974922 100644
@@ -107,8 +107,6 @@ struct bnxt_re_gsi_context {
 	struct	bnxt_re_sqp_entries *sqp_tbl;
 };
 
-#define BNXT_RE_MIN_MSIX		2
-#define BNXT_RE_MAX_MSIX		9
 #define BNXT_RE_AEQ_IDX			0
 #define BNXT_RE_NQ_IDX			1
 #define BNXT_RE_GEN_P5_MAX_VF		64
@@ -168,7 +166,7 @@ struct bnxt_re_dev {
 	struct bnxt_qplib_rcfw		rcfw;
 
 	/* NQ */
-	struct bnxt_qplib_nq		nq[BNXT_RE_MAX_MSIX];
+	struct bnxt_qplib_nq		nq[BNXT_MAX_ROCE_MSIX];
 
 	/* Device Resources */
 	struct bnxt_qplib_dev_attr	dev_attr;
Signature · 1 line
2.5.5
#1 lore raw
Quoted 8 lines · Selvin Xavier

bnxt_re no longer decide the number of MSI-x vectors used by itself. Its decided by bnxt_en now. So when bnxt_en changes this value, system crash is seen.

Depend on the max value reported by bnxt_en instead of using the its own macros.

[...]

Applied, thanks!

[1/1] RDMA/bnxt_re: Fix the max msix vectors macro

      https://git.kernel.org/rdma/rdma/c/056620da899527

Best regards,

Signature · 1 line
Leon Romanovsky <[email protected]>