doc: enhance build instructions on windows
PATCH 1/1 doc: enhance build instructions on windows
* Updated about old Meson issue
* Added instruction to get developer prompt
Andre Muezerie (1):
doc: enhanced build instructions on Windows
.mailmap | 1 + doc/guides/windows_gsg/build_dpdk.rst | 16 +++++++++++----- 2 files changed, 12 insertions(+), 5 deletions(-)
Signature · 1 line
1.8.3.1
PATCH 1/1 doc: enhanced build instructions on Windows
--- .mailmap | 1 + doc/guides/windows_gsg/build_dpdk.rst | 16 +++++++++++----- 2 files changed, 12 insertions(+), 5 deletions(-)
.mailmap +1 -0
@@ -98,6 +98,7 @@ Anatolii Gerasymenko <[email protected]> Anatoly Burakov <[email protected]> Anbarasan Murugesan <[email protected]> Anders Roxell <[email protected]> +Andre Muezerie <[email protected]> <[email protected]> Andrea Arcangeli <[email protected]> Andrea Grandi <[email protected]> Andre Richter <[email protected]>
doc/guides/windows_gsg/build_dpdk.rst +11 -5
@@ -72,10 +72,9 @@ A good option to choose is the MSI installer for both meson and ninja together:: http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22 -Required version is Meson 0.57. - -Versions starting from 0.58 are unusable with LLVM toolchain -because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_. +Meson version 0.58 was unusable with LLVM toolchain +because of an `issue <https://github.com/mesonbuild/meson/issues/8981>`_, but +more recent versions are working fine. Install the Backend
@@ -129,13 +128,20 @@ Depending on the distribution, paths in this file may need adjustments. Option 3. Native Build on Windows using MSVC ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Open a 'Developer PowerShell for VS 2022' prompt from the start menu. +Open a 'Visual Studio Developer Command Prompt'. When doing so, it's recommended +to specify the Target Architecture (-arch) and the Host Architecture (-host_arch). The developer prompt will configure the environment to select the appropriate compiler, linker and SDK paths required to build with Visual Studio 2022. .. code-block:: console + "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64 + +Compile the code from the developer prompt. + +.. code-block:: console + cd C:\Users\me\dpdk meson setup -Denable_stdatomic=true build meson compile -C build
Signature · 1 line
1.8.3.1
Re: [PATCH] doc: enhanced build instructions on Windows
Hello and welcome,
25/10/2024 16:15, Andre Muezerie:
Quoted 5 lines
Signed-off-by Andre Muezerie <[email protected]>---
doc/guides/windows_gsg/build_dpdk.rst A good option to choose is the MSI installer for both meson and ninja together:: · line 77
Quoted 10 lines
doc/guides/windows_gsg/build_dpdk.rst +3
-4@@ -72,10 +72,9 @@ A good option to choose is the MSI installer for both meson and ninja together:: http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22 -Required version is Meson 0.57. - -Versions starting from 0.58 are unusable with LLVM toolchain -because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_. +Meson version 0.58 was unusable with LLVM toolchain +because of an `issue <https://github.com/mesonbuild/meson/issues/8981>`_, but +more recent versions are working fine.
Please could we be more explicit about which version is working fine?
v2 cover doc: enhance build instructions on windows
* Updated about old Meson issue
* Added instruction to get developer prompt
---
v2:
- provide Meson version that works
Andre Muezerie (2):
doc: enhanced build instructions on Windows
doc: provide Meson version that works
.mailmap | 1 + doc/guides/windows_gsg/build_dpdk.rst | 16 +++++++++++----- 2 files changed, 12 insertions(+), 5 deletions(-)
Signature · 1 line
1.8.3.1
PATCH v2 1/2 doc: enhanced build instructions on Windows
--- .mailmap | 1 + doc/guides/windows_gsg/build_dpdk.rst | 16 +++++++++++----- 2 files changed, 12 insertions(+), 5 deletions(-)
.mailmap +1 -0
@@ -98,6 +98,7 @@ Anatolii Gerasymenko <[email protected]> Anatoly Burakov <[email protected]> Anbarasan Murugesan <[email protected]> Anders Roxell <[email protected]> +Andre Muezerie <[email protected]> <[email protected]> Andrea Arcangeli <[email protected]> Andrea Grandi <[email protected]> Andre Richter <[email protected]>
doc/guides/windows_gsg/build_dpdk.rst +11 -5
@@ -72,10 +72,9 @@ A good option to choose is the MSI installer for both meson and ninja together:: http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22 -Required version is Meson 0.57. - -Versions starting from 0.58 are unusable with LLVM toolchain -because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_. +Meson version 0.58 was unusable with LLVM toolchain +because of an `issue <https://github.com/mesonbuild/meson/issues/8981>`_, but +more recent versions are working fine. Install the Backend
@@ -129,13 +128,20 @@ Depending on the distribution, paths in this file may need adjustments. Option 3. Native Build on Windows using MSVC ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Open a 'Developer PowerShell for VS 2022' prompt from the start menu. +Open a 'Visual Studio Developer Command Prompt'. When doing so, it's recommended +to specify the Target Architecture (-arch) and the Host Architecture (-host_arch). The developer prompt will configure the environment to select the appropriate compiler, linker and SDK paths required to build with Visual Studio 2022. .. code-block:: console + "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64 + +Compile the code from the developer prompt. + +.. code-block:: console + cd C:\Users\me\dpdk meson setup -Denable_stdatomic=true build meson compile -C build
Signature · 1 line
1.8.3.1
Re: [PATCH v2 1/2] doc: enhanced build instructions on Windows
2024-10-25 12:30 (UTC-0700), Andre Muezerie:
doc/guides/windows_gsg/build_dpdk.rst Depending on the distribution, paths in this file may need adjustments. · line 132
Quoted 3 lines
doc/guides/windows_gsg/build_dpdk.rst +2
-1-Open a 'Developer PowerShell for VS 2022' prompt from the start menu. +Open a 'Visual Studio Developer Command Prompt'. When doing so, it's recommended +to specify the Target Architecture (-arch) and the Host Architecture (-host_arch).
It seems that Microsoft documentation [1] uses "target" and "host" terms for what Meson documentation [2] calls "host" and "build" respectively. This deserves a notice to avoid confusion.
[1]: https://learn.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2022
[2]: https://mesonbuild.com/Cross-compilation.html
Why manually specifying architectures is recommended?
If it is mandatory, please use imperative so that no one skips this step. However, Meson has cross-compilation features, don't they work (cross-compilation from Windows has never been considered yet)?
Quoted 15 lines
The developer prompt will configure the environment to select the appropriate compiler, linker and SDK paths required to build with Visual Studio 2022.
.. code-block:: console
doc/guides/windows_gsg/build_dpdk.rst +6
-0+ "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64 + +Compile the code from the developer prompt. + +.. code-block:: console + cd C:\Users\me\dpdk meson setup -Denable_stdatomic=true build meson compile -C build
PATCH v3 1/1 doc: enhance build instructions on Windows
Enhance build instructions on Windows
---
v3:
- Recommended Meson version to use and removed mention about old bug.
- Set VS developer prompt to produce 64 bit binaries if needed.
v2:
- provide Meson version that works
.mailmap | 1 + doc/guides/windows_gsg/build_dpdk.rst | 19 ++++++++++++++----- 2 files changed, 15 insertions(+), 5 deletions(-)
.mailmap +1 -0
@@ -98,6 +98,7 @@ Anatolii Gerasymenko <[email protected]> Anatoly Burakov <[email protected]> Anbarasan Murugesan <[email protected]> Anders Roxell <[email protected]> +Andre Muezerie <[email protected]> <[email protected]> Andrea Arcangeli <[email protected]> Andrea Grandi <[email protected]> Andre Richter <[email protected]>
doc/guides/windows_gsg/build_dpdk.rst +14 -5
@@ -72,10 +72,7 @@ A good option to choose is the MSI installer for both meson and ninja together:: http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22 -Required version is Meson 0.57. - -Versions starting from 0.58 are unusable with LLVM toolchain -because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_. +Meson version 1.5.2 or newer is recommended. Install the Backend
@@ -129,11 +126,23 @@ Depending on the distribution, paths in this file may need adjustments. Option 3. Native Build on Windows using MSVC ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Open a 'Developer PowerShell for VS 2022' prompt from the start menu. +Open a 'Visual Studio Developer Command Prompt'. The developer prompt will configure the environment to select the appropriate compiler, linker and SDK paths required to build with Visual Studio 2022. +Windows 32-bit is currently not supported, so if your Visual Studio environment defaults +to 32-bits you can instruct the toolset to produce 64-bit binaries using "-arch" parameter. +For more details about the Developer Prompt options look at the `Visual Studio Developer +Command Prompt and Developer PowerShell +<https://learn.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2022>`_. + +.. code-block:: console + + "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 + +Compile the code from the developer prompt. + .. code-block:: console cd C:\Users\me\dpdk
Signature · 1 line
1.8.3.1
Re: [PATCH v3] doc: enhance build instructions on Windows
2024-10-28 12:45 (UTC-0700), Andre Muezerie:
Quoted 1 line
Enhance build instructions on Windows
Commit messages should explain why the previous state had been problematic and how the new state solves the issues. For example:
doc: modernize build instructions on Windows
Meson 0.57 was an unstable version and is now outdated. The referenced bug in Meson 0.58 is fixed in stable releases. Recommend the latest stable release which is tested.
...likewise about command prompt changes...
[...]
Quoted 15 lines
doc/guides/windows_gsg/build_dpdk.rst +6
-1@@ -129,11 +126,23 @@ Depending on the distribution, paths in this file may need adjustments. Option 3. Native Build on Windows using MSVC ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Open a 'Developer PowerShell for VS 2022' prompt from the start menu. +Open a 'Visual Studio Developer Command Prompt'. The developer prompt will configure the environment to select the appropriate compiler, linker and SDK paths required to build with Visual Studio 2022. +Windows 32-bit is currently not supported, so if your Visual Studio environment defaults +to 32-bits you can instruct the toolset to produce 64-bit binaries using "-arch" parameter. +For more details about the Developer Prompt options look at the `Visual Studio Developer +Command Prompt and Developer PowerShell +<https://learn.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2022>`_.
doc/guides/windows_gsg/build_dpdk.rst Depending on the distribution, paths in this file may need adjustments. · line 148
Quoted 10 lines
doc/guides/windows_gsg/build_dpdk.rst +7
-0+ +.. code-block:: console + + "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 + +Compile the code from the developer prompt. + .. code-block:: console cd C:\Users\me\dpdk
It will be unclear to the reader to which machine "32-bit" refers. Suggestion:
Building DPDK applications that run on 32-bit Windows is currently not supported. If your Visual Studio environment defaults to producing 32-bit binaries...
With the above corrections,
PATCH v4 1/1 doc: modernize build instructions on Windows
Meson 0.57 was an unstable version and is now outdated. The referenced bug in Meson 0.58 is fixed in stable releases. Recommend the latest stable release which is tested.
Building DPDK applications that run on 32-bit Windows is currently not supported. However, some Visual Studio environments default to producing 32-bit binaries.
Recommend instructing the developer prompt to produce 64-bit binaries when that is the case.
---
v4:
- Clarified that "32-bit binaries" were refering to the Windows environment.
- Added clarifying commit messages.
v3:
- Recommended Meson version to use and removed mention about old bug.
- Set VS developer prompt to produce 64 bit binaries if needed.
v2:
- provide Meson version that works
.mailmap | 1 + doc/guides/windows_gsg/build_dpdk.rst | 22 ++++++++++++++++------ 2 files changed, 17 insertions(+), 6 deletions(-)
.mailmap +1 -0
@@ -98,6 +98,7 @@ Anatolii Gerasymenko <[email protected]> Anatoly Burakov <[email protected]> Anbarasan Murugesan <[email protected]> Anders Roxell <[email protected]> +Andre Muezerie <[email protected]> <[email protected]> Andrea Arcangeli <[email protected]> Andrea Grandi <[email protected]> Andre Richter <[email protected]>
doc/guides/windows_gsg/build_dpdk.rst +16 -6
@@ -72,10 +72,7 @@ A good option to choose is the MSI installer for both meson and ninja together:: http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22 -Required version is Meson 0.57. - -Versions starting from 0.58 are unusable with LLVM toolchain -because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_. +Meson version 1.5.2 or newer is recommended. Install the Backend
@@ -129,13 +126,26 @@ Depending on the distribution, paths in this file may need adjustments. Option 3. Native Build on Windows using MSVC ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Open a 'Developer PowerShell for VS 2022' prompt from the start menu. +Open a 'Visual Studio Developer Command Prompt'. The developer prompt will configure the environment to select the appropriate compiler, linker and SDK paths required to build with Visual Studio 2022. +Building DPDK applications that run on 32-bit Windows is currently not +supported. If your Visual Studio environment defaults to producing +32-bit binaries you can instruct the toolset to produce 64-bit binaries using "-arch" parameter. +For more details about the Developer Prompt options look at the `Visual Studio Developer +Command Prompt and Developer PowerShell +<https://learn.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2022>`_. + +.. code-block:: console + + "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 + +Compile the code from the developer prompt. + .. code-block:: console cd C:\Users\me\dpdk meson setup -Denable_stdatomic=true build - meson compile -C build + meson compile -C build
Signature · 1 line
1.8.3.1
Re: [PATCH v4] doc: modernize build instructions on Windows
Quoted 73 lines · On Wed, 30 Oct 2024 08:19:45 -0700 Andre Muezerie…
Meson 0.57 was an unstable version and is now outdated. The referenced bug in Meson 0.58 is fixed in stable releases. Recommend the latest stable release which is tested.
Building DPDK applications that run on 32-bit Windows is currently not supported. However, some Visual Studio environments default to producing 32-bit binaries.
Recommend instructing the developer prompt to produce 64-bit binaries when that is the case.Signed-off-by Andre Muezerie <[email protected]>---
v4:
- Clarified that "32-bit binaries" were refering to the Windows environment.
- Added clarifying commit messages.
v3:
- Recommended Meson version to use and removed mention about old bug.
- Set VS developer prompt to produce 64 bit binaries if needed.
v2:
- provide Meson version that works.mailmap | 1 + doc/guides/windows_gsg/build_dpdk.rst | 22 ++++++++++++++++------ 2 files changed, 17 insertions(+), 6 deletions(-).mailmap +1
-0@@ -98,6 +98,7 @@ Anatolii Gerasymenko <[email protected]> Anatoly Burakov <[email protected]> Anbarasan Murugesan <[email protected]> Anders Roxell <[email protected]> +Andre Muezerie <[email protected]> <[email protected]> Andrea Arcangeli <[email protected]> Andrea Grandi <[email protected]> Andre Richter <[email protected]>doc/guides/windows_gsg/build_dpdk.rst +12
-5@@ -72,10 +72,7 @@ A good option to choose is the MSI installer for both meson and ninja together:: http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22 -Required version is Meson 0.57. - -Versions starting from 0.58 are unusable with LLVM toolchain -because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_. +Meson version 1.5.2 or newer is recommended. Install the Backend@@ -129,13 +126,26 @@ Depending on the distribution, paths in this file may need adjustments. Option 3. Native Build on Windows using MSVC ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Open a 'Developer PowerShell for VS 2022' prompt from the start menu. +Open a 'Visual Studio Developer Command Prompt'. The developer prompt will configure the environment to select the appropriate compiler, linker and SDK paths required to build with Visual Studio 2022. +Building DPDK applications that run on 32-bit Windows is currently not +supported. If your Visual Studio environment defaults to producing +32-bit binaries you can instruct the toolset to produce 64-bit binaries using "-arch" parameter. +For more details about the Developer Prompt options look at the `Visual Studio Developer +Command Prompt and Developer PowerShell +<https://learn.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2022>`_. + +.. code-block:: console + + "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64
doc/guides/windows_gsg/build_dpdk.rst Depending on the distribution, paths in this file may need adjustments. · line 151
Quoted 10 lines
doc/guides/windows_gsg/build_dpdk.rst +4
-1+ +Compile the code from the developer prompt. + .. code-block:: console cd C:\Users\me\dpdk meson setup -Denable_stdatomic=true build - meson compile -C build + meson compile -C build
Please fix the file to have newline at end.
PATCH v5 1/1 doc: modernize build instructions on Windows
Meson 0.57 was an unstable version and is now outdated. The referenced bug in Meson 0.58 is fixed in stable releases. Recommend the latest stable release which is tested.
Building DPDK applications that run on 32-bit Windows is currently not supported. However, some Visual Studio environments default to producing 32-bit binaries.
Recommend instructing the developer prompt to produce 64-bit binaries when that is the case.
---
v5:
- Added new line at end of file build_dpdk.rst
v4:
- Clarified that "32-bit binaries" was refering to the Windows environment.
- Added clarifying commit messages.
v3:
- Recommended Meson version to use and removed mention about old bug.
- Set VS developer prompt to produce 64 bit binaries if needed.
v2:
- provide Meson version that works
.mailmap | 1 + doc/guides/windows_gsg/build_dpdk.rst | 20 +++++++++++++++----- 2 files changed, 16 insertions(+), 5 deletions(-)
.mailmap +1 -0
@@ -98,6 +98,7 @@ Anatolii Gerasymenko <[email protected]> Anatoly Burakov <[email protected]> Anbarasan Murugesan <[email protected]> Anders Roxell <[email protected]> +Andre Muezerie <[email protected]> <[email protected]> Andrea Arcangeli <[email protected]> Andrea Grandi <[email protected]> Andre Richter <[email protected]>
doc/guides/windows_gsg/build_dpdk.rst +15 -5
@@ -72,10 +72,7 @@ A good option to choose is the MSI installer for both meson and ninja together:: http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22 -Required version is Meson 0.57. - -Versions starting from 0.58 are unusable with LLVM toolchain -because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_. +Meson version 1.5.2 or newer is recommended. Install the Backend
@@ -129,11 +126,24 @@ Depending on the distribution, paths in this file may need adjustments. Option 3. Native Build on Windows using MSVC ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Open a 'Developer PowerShell for VS 2022' prompt from the start menu. +Open a 'Visual Studio Developer Command Prompt'. The developer prompt will configure the environment to select the appropriate compiler, linker and SDK paths required to build with Visual Studio 2022. +Building DPDK applications that run on 32-bit Windows is currently not +supported. If your Visual Studio environment defaults to producing +32-bit binaries you can instruct the toolset to produce 64-bit binaries using "-arch" parameter. +For more details about the Developer Prompt options look at the `Visual Studio Developer +Command Prompt and Developer PowerShell +<https://learn.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2022>`_. + +.. code-block:: console + + "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 + +Compile the code from the developer prompt. + .. code-block:: console cd C:\Users\me\dpdk
Signature · 1 line
1.8.3.1
Re: [PATCH v5] doc: modernize build instructions on Windows
31/10/2024 04:08, Andre Muezerie:
doc/guides/windows_gsg/build_dpdk.rst A good option to choose is the MSI installer for both meson and ninja together:: · line 75
Quoted 5 lines
doc/guides/windows_gsg/build_dpdk.rst +1
-4-Required version is Meson 0.57. - -Versions starting from 0.58 are unusable with LLVM toolchain -because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_. +Meson version 1.5.2 or newer is recommended.
I would prefer to know which minimal version is supported. Giving the latest version is not so helpful.
PS: when sending a new version, please reply to the very first version to avoid excessive indent in mail list, thanks.
Re: [PATCH v5] doc: modernize build instructions on Windows
Quoted 10 lines · Thomas Monjalon
31/10/2024 04:08, Andre Muezerie:
doc/guides/windows_gsg/build_dpdk.rst A good option to choose is the MSI installer for both meson and ninja together:: · line 75
Quoted 5 lines
doc/guides/windows_gsg/build_dpdk.rst +1
-4-Required version is Meson 0.57. - -Versions starting from 0.58 are unusable with LLVM toolchain -because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_. +Meson version 1.5.2 or newer is recommended.I would prefer to know which minimal version is supported. Giving the latest version is not so helpful.
Quoted 4 lines
PS: when sending a new version, please reply to the very first version to avoid excessive indent in mail list, thanks.
Sorry for the late reply.
The Meson issue previously mentioned in the documentation took a significant amount of time to get fixed. The fix only showed up in the main tree on August 7:
https://github.com/mesonbuild/meson/pull/11715#event-13793516174
Meson 1.5.2 was the first release containing that fix:
https://github.com/mesonbuild/meson/releases
That's the reason we added that specific version information to the patch, not just because it was the newest. But I see how it looked like that was the reason.
I'll change the wording a little to make it more clear, and reply to the first version as suggested.
Thanks for all the suggestions. They are greatly appreciated.
PATCH v2 2/2 doc: provide Meson version that works
In reply to Andre Muezerie--- doc/guides/windows_gsg/build_dpdk.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/windows_gsg/build_dpdk.rst +1 -1
@@ -74,7 +74,7 @@ A good option to choose is the MSI installer for both meson and ninja together:: Meson version 0.58 was unusable with LLVM toolchain because of an `issue <https://github.com/mesonbuild/meson/issues/8981>`_, but -more recent versions are working fine. +more recent versions are working fine. Meson version 1.5.2 was tested and worked. Install the Backend
Signature · 1 line
1.8.3.1
Re: [PATCH v2 2/2] doc: provide Meson version that works
2024-10-25 12:30 (UTC-0700), Andre Muezerie:
Quoted 10 lines
Signed-off-by Andre Muezerie <[email protected]>--- doc/guides/windows_gsg/build_dpdk.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)doc/guides/windows_gsg/build_dpdk.rst +0
-0
doc/guides/windows_gsg/build_dpdk.rst A good option to choose is the MSI installer for both meson and ninja together:: · line 80
Quoted 8 lines
doc/guides/windows_gsg/build_dpdk.rst +1
-1@@ -74,7 +74,7 @@ A good option to choose is the MSI installer for both meson and ninja together:: Meson version 0.58 was unusable with LLVM toolchain because of an `issue <https://github.com/mesonbuild/meson/issues/8981>`_, but -more recent versions are working fine. +more recent versions are working fine. Meson version 1.5.2 was tested and worked. Install the Backend
In order to address reviewer feedback on a single patch, you are supposed to send an updated version of that patch, not a series of the original patch (as v2 1/2)
and a patch with amendments (as v2 2/2, i.e. this patch). IOW, you should have sent a single v2 patch with the proper text.
As for this documentation paragraph: please drop the mention of Meson 0.58 and simply state that Meson 1.5.2 or newer is recommended.
The warning was put in place because the bug lasted many Meson versions.
PATCH v6 1/1 doc: modernize build instructions on Windows
In reply to Andre MuezerieMeson 0.57 was an unstable version and is now outdated. The referenced bug in Meson 0.58 is fixed in stable releases. Recommend the first version containing the fix: 1.5.2.
Building DPDK applications that run on 32-bit Windows is currently not supported. However, some Visual Studio environments default to producing 32-bit binaries.
Recommend instructing the developer prompt to produce 64-bit binaries when that is the case.
--- .mailmap | 1 + doc/guides/windows_gsg/build_dpdk.rst | 20 +++++++++++++++----- 2 files changed, 16 insertions(+), 5 deletions(-)
.mailmap +1 -0
@@ -98,6 +98,7 @@ Anatolii Gerasymenko <[email protected]> Anatoly Burakov <[email protected]> Anbarasan Murugesan <[email protected]> Anders Roxell <[email protected]> +Andre Muezerie <[email protected]> <[email protected]> Andrea Arcangeli <[email protected]> Andrea Grandi <[email protected]> Andre Richter <[email protected]>
doc/guides/windows_gsg/build_dpdk.rst +15 -5
@@ -72,10 +72,7 @@ A good option to choose is the MSI installer for both meson and ninja together:: http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22 -Required version is Meson 0.57. - -Versions starting from 0.58 are unusable with LLVM toolchain -because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_. +The minimal Meson supported version is 1.5.2. Install the Backend
@@ -129,11 +126,24 @@ Depending on the distribution, paths in this file may need adjustments. Option 3. Native Build on Windows using MSVC ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Open a 'Developer PowerShell for VS 2022' prompt from the start menu. +Open a 'Visual Studio Developer Command Prompt'. The developer prompt will configure the environment to select the appropriate compiler, linker and SDK paths required to build with Visual Studio 2022. +Building DPDK applications that run on 32-bit Windows is currently not +supported. If your Visual Studio environment defaults to producing +32-bit binaries you can instruct the toolset to produce 64-bit binaries using "-arch" parameter. +For more details about the Developer Prompt options look at the `Visual Studio Developer +Command Prompt and Developer PowerShell +<https://learn.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2022>`_. + +.. code-block:: console + + "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 + +Compile the code from the developer prompt. + .. code-block:: console cd C:\Users\me\dpdk
Signature · 1 line
2.34.1
Re: [PATCH v6] doc: modernize build instructions on Windows
11/11/2024 17:14, Andre Muezerie:
Quoted 1 line
+The minimal Meson supported version is 1.5.2.
OK looks good, thanks.
Re: [PATCH v6] doc: modernize build instructions on Windows
In reply to Andre Muezerie2024-11-11 08:14 (UTC-0800), Andre Muezerie:
Quoted 11 lines
Meson 0.57 was an unstable version and is now outdated. The referenced bug in Meson 0.58 is fixed in stable releases. Recommend the first version containing the fix: 1.5.2.
Building DPDK applications that run on 32-bit Windows is currently not supported. However, some Visual Studio environments default to producing 32-bit binaries.
Recommend instructing the developer prompt to produce 64-bit binaries when that is the case.Signed-off-by Andre Muezerie <[email protected]>
Thomas Monjalon
AppliedRe: [PATCH v6] doc: modernize build instructions on Windows
12/11/2024 10:56, Dmitry Kozlyuk:
Quoted 11 lines
2024-11-11 08:14 (UTC-0800), Andre Muezerie:
Quoted 10 lines
Meson 0.57 was an unstable version and is now outdated. The referenced bug in Meson 0.58 is fixed in stable releases. Recommend the first version containing the fix: 1.5.2.
Building DPDK applications that run on 32-bit Windows is currently not supported. However, some Visual Studio environments default to producing 32-bit binaries.
Recommend instructing the developer prompt to produce 64-bit binaries when that is the case.
Quoted 3 lines
Quoted 1 line
Signed-off-by Andre Muezerie <[email protected]>Acked-by Dmitry Kozlyuk <[email protected]>
Applied, thanks.