Skip to contentSkip to conversation

tiff: Security fix for CVE-2022-3970

PATCH Qiu, Zheng 1 participant 1 message Nov 22, 2022 1 message not in the archive

lore
Share & tools
lore

Qiu, Zheng

author
#1 lore raw
In reply to a message not in the archive

This patch has a problem. Please waiting for v2.

Zheng Qiu
Linux Developer

M/ (437) 341-1849

Quoted 96 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Qiu, Zheng via lists.openembedded.org
Sent: Tuesday, November 22, 2022 10:38 AM
To: [email protected]
Cc: Qiu, Zheng <[email protected]>; MacLeod, Randy <[email protected]>
Subject: [OE-core] [master][PATCH] tiff: Security fix for CVE-2022-3970

This patch contains a fix for CVE-2022-3970

Reference:
https://nvd.nist.gov/vuln/detail/CVE-2022-3970
https://security-tracker.debian.org/tracker/CVE-2022-3970

Patch generated from :
https://gitlab.com/libtiff/libtiff/-
/commit/227500897dfb07fb7d27f7aa570050e62617e3be

Upstream-Status: Accepted

---
.../libtiff/tiff/CVE-2022-3970.patch | 38 +++++++++++++++++++
meta/recipes-multimedia/libtiff/tiff_4.3.0.bb | 1 +

2 files changed, 39 insertions(+)

create mode 100644 meta/recipes-multimedia/libtiff/tiff/CVE-2022- 3970.patch

meta/recipes-multimedia/libtiff/tiff/CVE-2022-3970.patch new file +1 -0
new file mode 100644
index 0000000000..e8f143933a
@@ -0,0 +1,38 @@
+From 227500897dfb07fb7d27f7aa570050e62617e3be Mon Sep 17 00:00:00

2001

meta/recipes-multimedia/libtiff/tiff/CVE-2022-3970.patch new file +15 -0
+From: Even Rouault <[email protected]>
+Date: Tue, 8 Nov 2022 15:16:58 +0100
+Subject: [PATCH] TIFFReadRGBATileExt(): fix (unsigned) integer overflow
+on  strips/tiles > 2 GB
+
+Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=53137
+---
+ libtiff/tif_getimage.c | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/libtiff/tif_getimage.c b/libtiff/tif_getimage.c index
+a4d0c1d6..60b94d8e 100644
+--- a/libtiff/tif_getimage.c
++++ b/libtiff/tif_getimage.c
+@@ -3016,15 +3016,15 @@ TIFFReadRGBATileExt(TIFF* tif, uint32_t col,

uint32_t row, uint32_t * raster, in

meta/recipes-multimedia/libtiff/tiff/CVE-2022-3970.patch new file +25 -0
+         return( ok );
+
+     for( i_row = 0; i_row < read_ysize; i_row++ ) {
+-        memmove( raster + (tile_ysize - i_row - 1) * tile_xsize,
+-                 raster + (read_ysize - i_row - 1) * read_xsize,
++        memmove( raster + (size_t)(tile_ysize - i_row - 1) * tile_xsize,
++                 raster + (size_t)(read_ysize - i_row - 1) *
++ read_xsize,
+                  read_xsize * sizeof(uint32_t) );
+-        _TIFFmemset( raster + (tile_ysize - i_row - 1) * tile_xsize+read_xsize,
++        _TIFFmemset( raster + (size_t)(tile_ysize - i_row - 1) *
++ tile_xsize+read_xsize,
+                      0, sizeof(uint32_t) * (tile_xsize - read_xsize) );
+     }
+
+     for( i_row = read_ysize; i_row < tile_ysize; i_row++ ) {
+-        _TIFFmemset( raster + (tile_ysize - i_row - 1) * tile_xsize,
++        _TIFFmemset( raster + (size_t)(tile_ysize - i_row - 1) *
++ tile_xsize,
+                      0, sizeof(uint32_t) * tile_xsize );
+     }
+
+--
+2.33.0
+
meta/recipes- renamed from meta/recipes-multimedia/libtiff/tiff_4.3.0.bb +0 -0

multimedia/libtiff/tiff_4.3.0.bb
index f84057c46b..0fbe515e9d 100644

meta/recipes-multimedia/libtiff/tiff_4.3.0.bb +1 -1
@@ -24,6 +24,7 @@ SRC_URI = "http://download.osgeo.org/libtiff/tiff-
 ${PV}.tar.gz \
           file://CVE-2022-34526.patch \
           file://CVE-2022-2869.patch \
           file://CVE-2022-2867.patch \
+           file://CVE-2022-3970.patch \
           file://b258ed69a485a9cfb299d9f060eb2a46c54e5903.patch \
           "
 
--

2.33.0