Incorrect escape sequences in u-boot-1.3.3/common/usb.c
PATCH 1/1 Incorrect escape sequences in u-boot-1.3.3/common/usb.c
Hi,
Thanks to wd and all people who contributed for release of u-boot-1.3.3.
While going through some the files that i use for my u-boot version, i found an incorrect escape sequence mentioned in u-boot-1.3.3/common/usb.c. Below is the patch that corrects the same.
Here in my company i cannot use git and hence no git-patch or git-mail. sorry for that..
Regards
Gururaja
Signed off by: Gururaja Hebbar <[email protected]>
common/usb.c +0 -1
@@ -1088,7 +1088,7 @@ int usb_hub_configure(struct usb_device/* silence compiler warning if USB_BUFSIZ is > 256 [= sizeof(char)] */ i = descriptor->bLength;if (i >USB_BUFSIZ ) { - USB_HUB_PRINTF("usb_hub_configure: failed to get hub descriptor - too
long: %d\N",
+ USB_HUB_PRINTF("usb_hub_configure: failed to get hub descriptor - too
long: %d\n",
descriptor->bLength);
return -1;
}
http://www.nabble.com/file/p17336362/uboot-1.3.3-usb_driver-incorrect_escape_sequence.diff
uboot-1.3.3-usb_driver-incorrect_escape_sequence.diff
Signature · 2 lines
View this message in context: http://www.nabble.com/-PATCH--Incorrect-escape-sequences-in-u-boot-1.3.3-common-usb.c-tp17336362p17336362.html Sent from the Uboot - Users mailing list archive at Nabble.com.
PATCH 1/1 Incorrect escape sequences in u-boot-1.3.3/common/usb.c
Dear Gururaja,
Quoted 4 lines · in message <[email protected]> you wrote:
While going through some the files that i use for my u-boot version, i found an incorrect escape sequence mentioned in
u-boot-1.3.3/common/usb.c. Below is the patch that corrects the same.
Thanks. Had to apply manually, as your patch is line-wrapped.
Quoted 2 lines
Here in my company i cannot use git and hence no git-patch or git-mail. sorry for that..
What could you prevent from using git? I cannot imagine...
Quoted 2 lines
common/usb.c +0
-1- USB_HUB_PRINTF("usb_hub_configure: failed to get hub descriptor - toolong: %d\N",
^^^^^^^^^^^^^^^^^^
Quoted 2 lines
(quoted diff) +1
-0+ USB_HUB_PRINTF("usb_hub_configure: failed to get hub descriptor - toolong: %d\n",
^^^^^^^^^^^^^^^^^^
Please fix your mailer to not wrap lines!
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Do not underestimate the value of print statements for debugging. Don't have aesthetic convulsions when using them, either.
PATCH 1/1 Incorrect escape sequences in u-boot-1.3.3/common/usb.c
Quoted 7 lines
Quoted 7 lines
Thanks. Had to apply manually, as your patch is line-wrapped.
Please fix your mailer to not wrap lines!
I sent the patch from nabble forum becuase i thought microsoft outlook will line wrap the mails. Also i uploaded patch along with the mail rom nable forum.
Quoted 1 line
Quoted 1 line
What could you prevent from using git? I cannot imagine...
Even i dont know y and i am trying to convince them.
Will try to solve this at the earliest.
Regards
Gururaja
Signature · 2 lines
View this message in context: http://www.nabble.com/-PATCH--Incorrect-escape-sequences-in-u-boot-1.3.3-common-usb.c-tp17336362p17336578.html Sent from the Uboot - Users mailing list archive at Nabble.com.
PATCH 1/1 Incorrect escape sequences in u-boot-1.3.3/common/usb.c
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 2 lines
Quoted 2 lines
What could you prevent from using git? I cannot imagine...
Even i dont know y and i am trying to convince them.
I mean: what prevents you from installing it locally in your $HOME dir?
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The man on tops walks a lonely street; the "chain" of command is often a noose.
PATCH 1/1 Incorrect escape sequences in u-boot-1.3.3/common/usb.c
In reply to HebbarQuoted 30 lines · Hebbar
Hi,
Thanks to wd and all people who contributed for release of u-boot-1.3.3.
While going through some the files that i use for my u-boot version, i found an incorrect escape sequence mentioned in
u-boot-1.3.3/common/usb.c. Below is the patch that corrects the same.Here in my company i cannot use git and hence no git-patch or git-mail. sorry for that..
Regards
GururajaSigned off by: Gururaja Hebbar <[email protected]>
diff -purN
u-boot-1.3.3/common/usb.cu-boot-1.3.3-modified/common/usb.ccommon/usb.c +1
-1@@ -1088,7 +1088,7 @@ int usb_hub_configure(struct usb_device/* silence compiler warning if USB_BUFSIZ is > 256 [= sizeof(char)] */ i = descriptor->bLength;if (i >USB_BUFSIZ ) { -USB_HUB_PRINTF ("usb_hub_configure: failed to get hub descriptor - too long: %d\N", + USB_HUB_PRINTF("usb_hub_configure: failed to get hub descriptor - too long: %d\n", descriptor->bLength);
common/usb.c
Quoted 2 lines
common/usb.c +0
-0return -1 ; }
I'll send tomorow a full coding style patch
Best Regards,
J.
PATCH 1/1 Incorrect escape sequences in u-boot-1.3.3/common/usb.c
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 4 lines
diff -purN
u-boot-1.3.3/common/usb.cu-boot-1.3.3-modified/common/usb.ccommon/usb.c +0
-0
...
Quoted 1 line
I'll send tomorow a full coding style patch
Mind my pending whitespace-cleanup patch which touches this file, too.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Digital computers are themselves more complex than most things people build: They have very large numbers of states. This makes conceiving, describing, and testing them hard. Software systems have orders-of- magnitude more states than computers do. - Fred Brooks, Jr.